| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
This illustrates the purpose of the block for `link_to_if` and
`link_to_unless` helper methods.
It should help to prevent further mistakes like #19844.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stevenspiel/link_to_if_block_helper_addition"
This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing
changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3.
:sweat:
The block is not supposed to be passed to `link_to`. It's used for a
customized behavior of the `condtion = false` case. The docs
illustrate that like so:
```
<%=
link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do
link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user })
end
%>
```
|
|\
| |
| |
| | |
Update url_helper.rb
|
| |
| |
| | |
add block to link_to_if when condition is true
|
| | |
|
|\ \
| | |
| | | |
Correct translate helper docs [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The documentation previously stated that calling `translate(".foo")` was
equivalent to calling `I18n.translate("people.index.foo")` which is
incorrect due to the various other functions of the `translate` view
helper. This has been fixed.
Additionally, a note about forcing the view helper to re-raise
exceptions was added to the section detailing the handling of missing
translations.
Other cleanup includes:
* Consistent formatting of code
* Stop indenting bulleted list as a code sample
* Tighten some of the language
* Wrap at 80 characters.
|
| | | |
|
|/ /
| |
| |
| | |
This method is not in use since 479c7cacd5db58ab7200bc1de58c829a1a643278
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Running Action View test case currently printing out this warning:
lib/mathn.rb is deprecated
This should silence the warning since we really want to require this
file in this test.
|
|/ |
|
| |
|
|\
| |
| | |
[Skip ci] Add information about :host options
|
| |
| |
| |
| |
| |
| | |
Added informations about :host options for each url helper
(#javascript_url, #video_url, #stylesheet_url, etc) based on #asser_url
method.
|
|\ \
| | |
| | | |
Set default form builder for a controller
|
| | | |
|
|\ \ \
| | | |
| | | | |
Upgrade to Ruby 2.2.2
|
| | | |
| | | |
| | | |
| | | | |
and fix the grammar in the ruby_version_check.rb user message.
|
|\ \ \ \
| |_|/ /
|/| | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] remove duplicate doc for current_page?
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
JackDanger/danger/use-default-view-pattern-in-docs
[docs] Using the real resolver pattern in docs
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If someone copies the docs into their app they'll find it simply doesn't
work because the locale pattern doesn't have the same logic. This makes
the doc examples work exactly as written.
[ci skip]
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
fix for actionview parent layout bug
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit fixes issue #19626
Don't need to check layout conditions if there is no condition
test for parent layout bug fix
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Accept lambda as child_index option in #fields_for method
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
correct output of auto_discovery_link_tag [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Allow an array to be a default translation value.
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
4.2.1 introduced a change to the way `translate`/`t` works with an
option of `default: [[]]`. In 4.2.0, this would give a default value of
`[]`, but in 4.2.1, it leads to a missing translation.
`default: [[]]` is again allowed for cases where a default of `[]` is
needed.
This addresses GitHub issue 19640.
|
|/ / / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://github.com/ruby/ruby/pull/579 - there is a new optimization
since ruby 2.2
Previously regexp patterns were faster (since a string was converted to
regexp underneath anyway). But now string patterns are faster and
better reflect the purpose.
Benchmark.ips do |bm|
bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') }
bm.report('string') { 'this is ::a random string'.gsub('::', '/') }
bm.compare!
end
# string: 753724.4 i/s
# regexp: 501443.1 i/s - 1.50x slower
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
[ci skip] Unify the code comment in ActionView::Renderer#render_template...
|
| | |/
| |/| |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/4_0_release_notes.md
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
No need to merge hashes when simply setting options does the job.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous change 92a3c8dcdf174dab5e8759031b6bbe6cd891fe3c improved
this example, but calling .create + #valid? ends up running validations
twice, and we don't want to showcase that.
Lets use the normal use case of building a new object and calling #save
on it, which is what a basic scaffold with Active Record does.
[ci skip]
|
| | | |
|
| | |
| | |
| | |
| | | |
Strip nils out of default translations. Fixes #19419
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Preserving RACK_ENV behavior.
This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing
changes made to 45786be516e13d55a1fca9a4abaddd5781209103.
|