aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #30001 from y-yagi/fix_test_directoryKasper Timm Hansen2017-07-303-3/+3
|\ | | | | Fix test directory to correct path
| * Fix test directory to correct pathyuuji.yaginuma2017-07-303-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ```
* | Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-252-0/+10
|/
* Suppress warning from actionview controller helper.Christina Thompson2017-07-241-1/+1
| | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
* Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-24177-1/+350
|\ | | | | Use frozen string literal in actionview/
| * Use frozen string literal in actionview/Kir Shatrov2017-07-24177-1/+350
| |
* | Merge pull request #29792 from lugray/delegate_respond_toRafael França2017-07-242-2/+21
|\ \ | |/ |/| Delegate respond_to? in ActionView::Helpers::ControllerHelper
| * Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-192-2/+21
| | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* | Make actionview ready for frozen stringsKir Shatrov2017-07-231-1/+2
| |
* | Merge pull request #29884 from padi/update_rails_5_upgrade_guideRafael França2017-07-211-2/+2
|\ \ | | | | | | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
| * | Suppress documentation for content_tag_for and div_for since they were ↵Marc Rendl Ignacio2017-07-211-2/+2
| | | | | | | | | | | | removed already
* | | Remove log directory in test postprocessingyuuji.yaginuma2017-07-211-1/+1
| | | | | | | | | | | | The "log" is directory. So it is necessary to use `FileUtils.rm_rf`.
* | | Add jQuery to test vendor filesMarc Rendl Ignacio2017-07-202-1/+9832
| |/ |/| | | | | | | ... so that we can run most, if not all, of rails-ujs tests without necessarily requiring an internet connection.
* | [ci skip]Replace jquery-ujs with rails-ujswillnet2017-07-191-1/+1
| |
* | Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-172-24/+24
|/ | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
* [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-113-0/+3
|
* Prepare AP and AR to be frozen string friendlyKir Shatrov2017-07-062-1/+3
|
* Merge branch 'master' into require_relative_2017Xavier Noria2017-07-0224-236/+257
|\
| * Expectation firstAkira Matsuda2017-07-022-8/+8
| |
| * Avoid shadowed variableMatthew Draper2017-07-021-2/+2
| |
| * Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-02191-191/+1
| | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
| * Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-02191-1/+191
| |\ | | | | | | | | | Enforce frozen string in Rubocop
| | * Enforce frozen string in RubocopKir Shatrov2017-07-01191-1/+191
| | |
| * | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-0221-225/+225
| |\ \ | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| | * | Make ActionView frozen string literal friendly.Pat Allan2017-06-2019-220/+220
| | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches.
| | * | Make ActionMailer frozen string literal friendly.Pat Allan2017-06-202-3/+3
| | | |
| | * | Make ActiveModel frozen string literal friendly.Pat Allan2017-06-201-2/+2
| | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite.
| * | | Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-023-3/+24
| |\ \ \ | | | | | | | | | | | | | | | Add srcset option to image_tag helper
| | * | | Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-293-2/+23
| | | |/ | | |/|
* | / | [Action View] require => require_relativeAkira Matsuda2017-07-0125-35/+35
|/ / /
* / / Fallback Parameters#to_s to Hash#to_sKir Shatrov2017-06-301-0/+6
|/ / | | | | Fixes https://github.com/rails/rails/issues/29617
* | Merge pull request #29588 from greysteil/add-gemspec-linksRafael França2017-06-281-0/+5
|\ \ | | | | | | Add source code and changelog links to gemspecs
| * | Add source code and changelog links to gemspecsGrey Baker2017-06-281-0/+5
| | |
* | | :scissors:Ryuta Kamizono2017-06-281-4/+4
|/ / | | | | | | [ci skip]
* | Add changes to CHANGELOGsavroff2017-06-191-0/+6
| | | | | | | | | | | | fix fix
* | Fix current_page? helper issue with engine root pathsavroff2017-06-192-4/+17
|/
* Use `require_relative` instead of `require` with full pathbogdanvlviv2017-06-141-1/+1
|
* Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-114-18/+28
| | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* Don't rely on the @view_renderer being defined.Kasper Timm Hansen2017-06-081-2/+2
| | | | That won't be true for Action Pack and Action Mailer.
* Merge pull request https://github.com/rails/rails/pull/28637 from ↵Kasper Timm Hansen2017-06-086-33/+42
| | | | st0012/fix-partial-cache-logging
* Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-087-3/+51
| | | | boolean.
* Don't support namespace in form_with.Kasper Timm Hansen2017-06-071-18/+0
| | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there.
* Move slicing to initializer.Kasper Timm Hansen2017-06-072-2/+2
| | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca
* Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-037-25/+13
|
* Merge pull request #29187 from robin850/remove-mathnRafael França2017-05-301-3/+11
|\ | | | | Remove requirement on mathn
| * Remove requirement on mathnRobin Dupret2017-05-301-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The test using mathn was first introduced in f1d9179 to check that the `distance_of_time_in_words` properly doesn't use the `Fixnum#/` method by explicitly requiring this library as it redefines this method. Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since version 2.2, we can certainly safely assume that people will most-likely not require this library in their application. However, to make sure that we don't regress, let's add a test similar to the one before f1d9179.
* | Grammar fixesJon Moss2017-05-291-2/+3
| | | | | | | | [ci skip]
* | Merge pull request #29191 from ↵Kasper Timm Hansen2017-05-291-1/+1
|\ \ | | | | | | | | | | | | bogdanvlviv/pass_params_filename_lineno_to_class_eval Pass params __FILE__ and __LINE__ + 1 if class_eval with <<
| * | Pass params __FILE__ and __LINE__ + 1 if class_eval with <<bogdanvlviv2017-05-291-1/+1
| |/
* | Merge pull request #29151 from onemanstartup/jquery_slim_fixGuillermo Iguaran2017-05-291-1/+1
|\ \ | | | | | | Check for jQuery ajax
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 20:29:14 +0000