Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Collections automatically cache and fetch partials. | Kasper Timm Hansen | 2015-02-21 | 7 | -3/+101 |
| | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ``` | ||||
* | Merge multi_fetch_fragments. | Kasper Timm Hansen | 2015-02-20 | 6 | -2/+95 |
| | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template. | ||||
* | Merge pull request #18845 from bogdan/remove-code-dups-in-action-view | Rafael Mendonça França | 2015-02-11 | 2 | -33/+25 |
|\ | | | | | Remove some code duplication in ActionView tags code | ||||
| * | Remove code duplication in ActionView::Helpers::Tags::Base | Bogdan Gusiev | 2015-02-11 | 2 | -33/+25 |
| | | |||||
* | | Remove warning from ActionView::Helpers::Tags::Translator | Yuki Nishijima | 2015-02-08 | 1 | -1/+3 |
|/ | | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute? | ||||
* | use kwargs instead of xhr method. refs #18771. | yuuji.yaginuma | 2015-02-07 | 1 | -2/+2 |
| | |||||
* | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_for | Miklos Fazekas | 2015-02-06 | 2 | -1/+13 |
| | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model) | ||||
* | Indicate link_to creates an anchor element | Colin Rymer | 2015-02-06 | 1 | -2/+2 |
| | | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip] | ||||
* | Rename method to make explicit its intention | Rafael Mendonça França | 2015-02-05 | 3 | -3/+3 |
| | | | | call is too generic | ||||
* | Use kwags to make the argument meaning explicit | Rafael Mendonça França | 2015-02-05 | 3 | -6/+6 |
| | |||||
* | Use new hash syntax | Rafael Mendonça França | 2015-02-05 | 1 | -1/+1 |
| | |||||
* | Change the method visibility | Rafael Mendonça França | 2015-02-05 | 1 | -2/+4 |
| | | | | Thse methods are used only inside this class | ||||
* | Add tests to make sure label and placeholder respect to_model | Rafael Mendonça França | 2015-02-05 | 2 | -0/+58 |
| | |||||
* | Only check if object respond_to to_model once | Rafael Mendonça França | 2015-02-05 | 1 | -6/+2 |
| | |||||
* | placeholder doesn't exist inside this context | Rafael Mendonça França | 2015-02-05 | 1 | -2/+2 |
| | |||||
* | Merge pull request #18647 from mcls/placeholderable-to-model | Rafael Mendonça França | 2015-02-05 | 4 | -28/+47 |
|\ | | | | | | | The `model_name` method should be called on `to_model` | ||||
| * | Reduce duplication when generating translations | Maarten Claes | 2015-01-22 | 4 | -34/+47 |
| | | |||||
| * | Convert with `to_model` before calling ActiveModel methods on `object` | Maarten Claes | 2015-01-22 | 2 | -8/+14 |
| | | |||||
* | | Partial template name does no more have to be a valid Ruby identifier | Akira Matsuda | 2015-02-06 | 5 | -16/+21 |
| | | | | | | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484 | ||||
* | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 6 | -6/+0 |
| | | | | | | | | onwards. | ||||
* | | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 4 | -4/+4 |
| | | | | | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
* | | Fixed test for deprecation warning in actionview, renaming from ↵ | Vipul A M | 2015-01-31 | 3 | -29/+29 |
| | | | | | | | | https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a | ||||
* | | Add missing options to `datetime_select` [ci skip] | yachibit | 2015-01-25 | 1 | -0/+2 |
|/ | |||||
* | Merge pull request #18546 from brainopia/action_view_render | Rafael Mendonça França | 2015-01-22 | 2 | -2/+14 |
|\ | | | | | A shortcut to setup controller environment | ||||
| * | Support `:assigns` option when rendering with controllers/mailers. | brainopia | 2015-01-22 | 2 | -2/+14 |
| | | |||||
* | | Single instead of double quotes | T.J. Schuck | 2015-01-20 | 1 | -2/+2 |
| | | | | | | [ci skip] | ||||
* | | Rewrite SanitizeHelper docs | T.J. Schuck | 2015-01-20 | 1 | -77/+50 |
| | | |||||
* | | Fix code formatting in sanitize docs | T.J. Schuck | 2015-01-20 | 1 | -9/+11 |
| | | |||||
* | | fix typo in number_field_tag documentation [ci skip] | yuuji.yaginuma | 2015-01-19 | 1 | -2/+2 |
| | | |||||
* | | Use existing constant for joining instead of '_' | Prathamesh Sonpatki | 2015-01-18 | 1 | -1/+1 |
| | | |||||
* | | nodoc ActionView::ModelNaming module | Prathamesh Sonpatki | 2015-01-18 | 1 | -1/+1 |
| | | | | | | | | | | - Its only used by ActionView internals and not supposed to be used through public API. | ||||
* | | Eliminate a ruby warning in a test in Action View | Yuki Nishijima | 2015-01-17 | 1 | -1/+5 |
| | | | | | | | | | | | | | | This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here | ||||
* | | Use option url: false to allow entries without a link tag | Daniel Gomez de Souza | 2015-01-16 | 3 | -2/+30 |
|/ | |||||
* | Only use the `_before_type_cast` in the form when from user input | Sean Griffin | 2015-01-14 | 2 | -2/+26 |
| | | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values. | ||||
* | Add tests with an explanation of why we're using `_before_type_cast` | Sean Griffin | 2015-01-14 | 1 | -3/+4 |
| | | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0. | ||||
* | Revert "Don't use the `_before_type_cast` version of attributes in the form" | Sean Griffin | 2015-01-14 | 4 | -3/+13 |
| | | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd. | ||||
* | Don't use the `_before_type_cast` version of attributes in the form | Sean Griffin | 2015-01-14 | 4 | -13/+3 |
| | | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523. | ||||
* | Fix typo in ActionView CHANGELOG [ci skip] | Prathamesh Sonpatki | 2015-01-14 | 1 | -1/+1 |
| | |||||
* | No need of requiring `rbconfig`, it is by-default loaded | Kuldeep Aggarwal | 2015-01-10 | 1 | -1/+0 |
| | |||||
* | Avoid changing the global state on the tests | Rafael Mendonça França | 2015-01-05 | 1 | -1/+6 |
| | |||||
* | Merge pull request #17676 from ↵ | Rafael Mendonça França | 2015-01-05 | 2 | -6/+27 |
|\ | | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832 | ||||
| * | Fix I18n regression introduced by #13832 | Christopher Dell | 2014-11-19 | 2 | -6/+27 |
| | | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used. | ||||
* | | Merge pull request #18328 from brainopia/remove_tz_proxy | Rafael Mendonça França | 2015-01-04 | 1 | -1/+1 |
|\ \ | | | | | | | Use directly TZInfo::Timezone without proxy | ||||
| * | | Use directly TZInfo::Timezone without proxy | brainopia | 2015-01-04 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create` | ||||
* | | | Remove wrong TODO comment | Rafael Mendonça França | 2015-01-04 | 1 | -1/+1 |
| | | | |||||
* | | | Remove version conditional for find_template_paths | Rafael Mendonça França | 2015-01-04 | 1 | -18/+6 |
|/ / | | | | | | | | | Now that we only support Ruby 2.2+ we don't need this conditional anymore | ||||
* | | Remove unneeded `require 'as/deprecation'` | claudiob | 2015-01-04 | 1 | -1/+0 |
| | | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed. | ||||
* | | Remove unneeded requires | Rafael Mendonça França | 2015-01-04 | 1 | -1/+0 |
| | | | | | | | | These requires were added only to change deprecation message | ||||
* | | Change the default template handler from `ERB` to `Raw`. | Rafael Mendonça França | 2015-01-04 | 3 | -8/+9 |
| | | | | | | | | | | Files without a template handler in their extension will be rended using the raw handler instead of ERB. | ||||
* | | Remove deprecated `AbstractController::Base::parent_prefixes` | Rafael Mendonça França | 2015-01-04 | 3 | -35/+7 |
| | |