aboutsummaryrefslogtreecommitdiffstats
path: root/actionview
Commit message (Collapse)AuthorAgeFilesLines
...
* | | We need an explicit returnRafael Mendonça França2014-05-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we don't return early Ruby will memoize the value of the prefix of the parent class what will make the subsequent searchs to not work as expected. If the early return we are avoiding the memoization. But when using the deprecated path we need to memoize the value, so we are not using early return for the deprecated path.
* | | Following documentation guidelineRafael Mendonça França2014-05-141-4/+3
| | |
* | | Refactoring the code to make consitional return explicitRafael Mendonça França2014-05-141-4/+9
| | |
* | | Follow the documentation guidelineRafael Mendonça França2014-05-141-1/+1
| | |
* | | Mark _prefix as nodocRafael Mendonça França2014-05-141-3/+2
| | | | | | | | | | | | These methods are private API.
* | | ._prefix is private API so we should not recommend to override itRafael Mendonça França2014-05-141-2/+2
| | |
* | | Improve CHANGELOG entryRafael Mendonça França2014-05-141-2/+4
| | |
* | | Merge remote-tracking branch 'apotonick/simplify-prefixes'Rafael Mendonça França2014-05-143-15/+75
|\ \ \ | | | | | | | | | | | | | | | | | | | | This is the rebased version of #15026 Closes #15026
| * | | deprecate AbC:Base::parent_prefixes.Nick Sutterer2014-05-133-4/+69
| | | | | | | | | | | | | | | | | | | | | | | | rename ::_local_prefixes to ::local_prefixes to state the public attribute. document the latter. make ::local_prefixes private, test overriding it and remove documentation for overriding ::_parent_prefixes.
| * | | simplify AC:ViewPaths::_prefixes. by making it recursively traversing up the ↵Nick Sutterer2014-05-131-15/+10
| | |/ | |/| | | | | | | inheritance chain, classes can override local prefixes.
* | | minor: point to the right test suite locationazul2014-05-141-1/+1
| | |
* | | Fix assertion order and :scissors: extra spacesCarlos Antonio da Silva2014-05-132-4/+3
| | |
* | | Merge pull request #15068 from josepjaume/patch-1Aaron Patterson2014-05-132-0/+8
|\ \ \ | | | | | | | | Dup options hash to prevent modifications
| * | | Dup options hash to prevent modificationsJosep Jaume Rey2014-05-132-0/+8
| |/ / | | | | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object.
* | | fix bad mergeAaron Patterson2014-05-121-15/+0
| | |
* | | :cry::gun: use an empty hash for magical speed.Aaron Patterson2014-05-121-1/+5
| | | | | | | | | | | | | | | | | | For some reason, if the hash is empty, we choose "optimized" routes. I am not sure how or why optimized routes differ from regular routes. But, if we make sure the hash is empty, we get a nice speed improvement.
* | | use the helper method builder to construct helper methodsAaron Patterson2014-05-121-2/+6
| | |
* | | probably should not check in a raiseAaron Patterson2014-05-121-1/+0
| | |
* | | undo optimized calls until the builder object is finishedAaron Patterson2014-05-121-4/+3
| | |
* | | fix url_for with classesAaron Patterson2014-05-121-1/+1
| | |
* | | break each polymorphic type to it's own methodAaron Patterson2014-05-121-1/+5
| | |
* | | add a test for the parameters sent to the url helper for new recordsAaron Patterson2014-05-121-0/+15
| | |
* | | simplified route method name generationCoraline Ada Ehmke + Aaron Patterson2014-05-121-0/+2
| | |
* | | add a test with three objectsAaron Patterson2014-05-121-2/+13
| | |
* | | add a test for passing two models to the polymorphic_url methodAaron Patterson2014-05-121-0/+8
|/ /
* | feature detect for FNM_EXTGLOB for older Ruby. Fixes #15053Aaron Patterson2014-05-101-5/+21
| |
* | use fnmatch to test for case insensitive file systemsAaron Patterson2014-05-091-4/+2
| | | | | | | | | | | | this is due to: https://bugs.ruby-lang.org/issues/5994
* | add tests for path based url_for callsAaron Patterson2014-05-081-2/+19
| |
* | don't manipulate the testclass, just add helpers to the instanceAaron Patterson2014-05-081-10/+11
| |
* | add a test for classes with optionsAaron Patterson2014-05-081-0/+7
| |
* | add tests for the polymorphic_path methodAaron Patterson2014-05-081-0/+3
| |
* | add more tests around the polymorphic url apiAaron Patterson2014-05-081-0/+12
|/
* test for inconsistency between String and Symbol url_for handlingAaron Patterson2014-05-071-0/+4
|
* add tests for symbols passed to polymorphic_urlAaron Patterson2014-05-071-0/+12
|
* apparently passing a string to polymorphic_url is something we supportAaron Patterson2014-05-061-0/+12
| | | | o_O
* make sure url_for works similar to polymorphic_urlAaron Patterson2014-05-061-38/+43
|
* add a test for the parameters sent to the url helper for new recordsAaron Patterson2014-05-061-0/+15
|
* Merge pull request #14997 from jpcody/nested_value_i18nRafael Mendonça França2014-05-063-2/+31
|\ | | | | Include label value in i18n attribute lookup
| * Include label value in i18n attribute lookupJoshua Cody2014-05-063-2/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post".
* | Ensure that .process return the method returnArthur Neves2014-05-062-9/+13
|/
* Typo, grammar and textual changes [ci skip]Akshay Vishnoi2014-05-031-4/+5
|
* passing a nil in the polymorphic array is not supported. remove nils before ↵Aaron Patterson2014-05-021-4/+4
| | | | you call the method
* passing a nil should always raise an ArgumentErrorAaron Patterson2014-05-021-0/+25
|
* Enhance a bit a few changelog entries [ci skip]Robin Dupret2014-05-021-2/+2
|
* Form_tag_helper grammar fix [skip ci]Jon Atack2014-05-021-1/+1
|
* always pass options to the _url methodAaron Patterson2014-05-011-3/+13
|
* always use File.joinphoet2014-05-013-2/+20
|
* Add documentation to select_tag for :selected optionRizwan Reza2014-04-301-1/+5
|
* split nil / Hash cases in url_forAaron Patterson2014-04-301-4/+4
| | | | | | | this reduces the number of comparisons and method calls `url_for` requires. The nil case no longer calls `symbolize_keys`, we already know options is nil, so no more ||=, and since it is nil we already know that options[:host] will be nil too.
* rewrites the API docs of favicon_link_tag [ci skip]Xavier Noria2014-04-291-9/+16
| | | | Motivated by #14907.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 23:17:51 +0000