Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #29127 from DmytroVasin/rails-ujs-remote-callbacks | Guillermo Iguaran | 2017-10-19 | 1 | -63/+29 |
|\ | | | | | Fix callback in rails ujs | ||||
| * | Fix callback in rails ujs | Vasin Dmitriy | 2017-06-07 | 1 | -63/+29 |
| | | |||||
* | | Fix test directory to correct path | yuuji.yaginuma | 2017-07-30 | 2 | -2/+2 |
|/ | | | | | | | | | | | | | | Together, fix to the following lint violation. ``` rails/actionview/test/ujs/public/test/data-confirm.js 303:11 error Strings must use singlequote quotes rails/actionview/test/ujs/public/test/data-remote.js 414:32 error Extra semicolon semi ✖ 2 problems (2 errors, 0 warnings) ``` | ||||
* | Fix mistake in JS response parser: | Dmytro Vasin | 2017-04-13 | 1 | -0/+28 |
| | | | | | | - Restore ability to accept ecmascript JS response should not modify DOM. | ||||
* | Set current page as default for ajax requests | Dmytro Vasin | 2017-04-11 | 1 | -22/+45 |
| | |||||
* | Prevent event propogation if element is disabled when event chain begins. | Patrick Toomey | 2017-03-09 | 1 | -0/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | | The existing UJS event behavior relies on browsers not sending events for various events when an element is disabled. For example, imagine the following: <button type="submit" disabled="disabled">Click me</button> The above button is disabled, so browsers will not trigger a click event and all UJS behavior is prevented. However, imagine a button like this: <button type="submit" disabled="disabled"><strong>Click me</strong></button> The above is treated differently by browsers such as Chrome/Safari. These browsers do not consider the strong tag to be disabled, and will trigger click events. UJS has logic to walk up the DOM to find an associated element subject to UJS behavior. But, this logic does not take into account the disabled status of the element. I originally thought we could simply change the selectors used to match elements to ignore disabled elements. However, UJS disables some elements as part of the event chain. So, an element might match early in the chain and then fail to match later. Instead of changing the selectors I added a callback to the chain that calls `stopEverything` if an element is disabled when the event chain begins. | ||||
* | Import rails-ujs v0.1.0 from rails/rails-ujs | Guillermo Iguaran | 2017-02-20 | 4 | -202/+21 |
| | |||||
* | s/an/a/ | Akira Matsuda | 2017-01-26 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | Add UJS tests | Guillermo Iguaran | 2016-11-26 | 12 | -0/+2445 |