aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Fix escape_once double-escaping hex-encoded entitiesJohn F. Douthat2014-07-022-0/+2
| | | | (This is a manual merge of #9102)
* Add String support for min/max attributes on DatetimeFieldTodd Bealmear2014-06-301-0/+64
|
* Deal with regex match groups in excerptGareth Rees2014-06-241-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original implementation has bugs if the regex contains a match group. Example: excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5) Expected: "...is a beautiful? mor..." Actual: "...is a beautifulbeaut..." The original phrase was being converted to a regex and returning the text either side of the phrase as expected: 'This is a beautiful? morning'.split(/beautiful/i, 2) # => ["This is a ", "? morning"] When we have a match with groups the match is returned in the array. Quoting the ruby docs: "If pattern is a Regexp, str is divided where the pattern matches. [...] If pattern contains groups, the respective matches will be returned in the array as well." 'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2) # => ["This is a ", "beautiful", "? morning"] If we assume we want to split on the first match – this fix makes that assumption – we can pass the already assigned `phrase` variable as the place to split (because we already know that a match exists from line 168). Originally spotted by Louise Crow (@crowbot) at https://github.com/mysociety/alaveteli/pull/1557
* Merge pull request #15450 from aditya-kapoor/remove-nbsp-debugRafael Mendonça França2014-06-191-1/+1
|\ | | | | remove unnecessary gsub for space in ActionView::Helpers#debug
| * remove unnecessary substitution for space in ActionView::Helpers#debugAditya Kapoor2014-06-141-1/+1
| |
* | 'TextHelper#highlight' now accepts a block to highlight the matched words.Lucas Mazza2014-06-191-0/+7
| | | | | | | | | | | | | | | | The helper will yield each matched word, and you can use this instead of the ':highlighter' option for more complex replacing logic: highlight('My email is me@work.com', EMAIL_REGEXP) { |m| mail_to(m) } # => 'My email is <a href="mailto:me@work.com">me@work.com</a>'
* | highlight() now accepts regular expressions as well.Jan Szumiec2014-06-191-1/+9
| |
* | excerpt() now accepts regular expression instances as phrases.Jan Szumiec2014-06-191-0/+2
| |
* | Merge pull request #15709 from zuhao/refactor_actionview_compiled_templates_testYves Senn2014-06-181-8/+1
|\ \ | | | | | | Move cleanup into teardown, delete obsolete code.
| * | Move cleanup into teardown, delete obsolete code.Zuhao Wan2014-06-141-8/+1
| | |
* | | reload I18n as we are defining `:ts` localeKuldeep Aggarwal2014-06-151-0/+2
| | | | | | | | | | | | fix build- see https://travis-ci.org/rails/rails/jobs/27578159#L2913.
* | | Merge pull request #15715 from ↵Yves Senn2014-06-143-4/+11
|\ \ \ | |_|/ |/| | | | | | | | | | | zuhao/refactor_actionview_cleanup_I18n_translations Clean up I18n stored translations after test.
| * | Clean up I18n stored translations after test.Zuhao Wan2014-06-143-4/+12
| | |
* | | Merge pull request #15712 from zuhao/refactor_actionview_javascript_helper_testYves Senn2014-06-141-3/+3
|\ \ \ | |/ / |/| | Avoid hard-coded value in test setup and teardown.
| * | Avoid hard-coded value in test setup and teardown.Zuhao Wan2014-06-141-3/+3
| |/
* / Make sure restoration always happen.Zuhao Wan2014-06-141-0/+1
|/
* Merge pull request #15654 from pdg137/masterMatthew Draper2014-06-132-1/+32
|\ | | | | | | In tag helper, honor html_safe on arrays; also make safe_join more similar to Array.join
| * In tag helper, honor html_safe on array parameters; also make safe_join more ↵Paul Grayson2014-06-122-1/+32
| | | | | | | | similar to Array.join by first calling flatten.
* | Add unregister_template_handler to prevent leaks.Zuhao Wan2014-06-122-4/+24
|/
* Removed CaptureHelper#flush_output_buffer as it is only used in tests.Ryan Davis2014-06-042-82/+0
| | | | reviewed: @tenderlove
* Fix AS::NumberHelper results with rationalsJuanjo Bazán2014-05-311-0/+1
| | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33"
* Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_urlRafael Mendonça França2014-05-161-0/+15
|\ | | | | | | Allow custom asset host to be passed in asset_url
| * Allow custom asset host to be passed in asset_urlHubert Łępicki2014-05-081-0/+15
| |
* | minor: point to the right test suite locationazul2014-05-141-1/+1
| |
* | Fix assertion order and :scissors: extra spacesCarlos Antonio da Silva2014-05-131-2/+2
| |
* | Merge pull request #15068 from josepjaume/patch-1Aaron Patterson2014-05-131-0/+6
|\ \ | | | | | | Dup options hash to prevent modifications
| * | Dup options hash to prevent modificationsJosep Jaume Rey2014-05-131-0/+6
| |/ | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object.
* / simplified route method name generationCoraline Ada Ehmke + Aaron Patterson2014-05-121-0/+2
|/
* Include label value in i18n attribute lookupJoshua Cody2014-05-061-0/+9
| | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post".
* always pass options to the _url methodAaron Patterson2014-05-011-3/+13
|
* always use File.joinphoet2014-05-011-0/+8
|
* Merge pull request #13335 from glorieux/favicon_link_tag_mimetypeRafael Mendonça França2014-04-221-3/+3
|\ | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
| * Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵glorieux2014-04-211-3/+3
| | | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
* | Add test for using ActionView::Helpers::FormHelper.label with block and htmlZachary Scott2014-04-221-0/+7
|/
* Remove wrapper div for inputs in button_toRafael Mendonça França2014-04-171-20/+20
| | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2
* Merge pull request #14738 from tilsammans/pull/11407Rafael Mendonça França2014-04-172-8/+12
|\ | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md
| * Remove wrapping div with inline styles for hidden form fields.Joost Baaij2014-04-142-8/+12
| | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.
* | Use the index on hidden fieldRafael Mendonça França2014-04-141-1/+1
| |
* | `collection_check_boxes` respects `:index` option for the hidden filed name.Vasiliy Ermolovich2014-04-141-0/+7
|/ | | | closes #14147
* CollectionHelpers now accepts a readonly optionMauro George2014-04-121-0/+44
|
* Add test for selected and disabled custom attributes in options_for_selectLaura Paredes2014-03-311-1/+21
|
* Fix date_select option overwriting html classesIzumi Wong-Horiuchi2014-03-241-0/+16
| | | | | with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting.
* Digestor should just rely on the finder to know about the format and the ↵David Heinemeier Hansson2014-03-211-10/+7
| | | | variant -- trying to pass it back in makes a mess of things (oh, and doesnt work)
* fix `number_to_percentage` with `Float::NAN`, `Float::INFINITY`.Yves Senn2014-03-171-0/+3
| | | | | | | Closes #14405. This is a follow-up to 9e997e9039435617b6a844158f5437e97f6bc107 to restore the documented behavior.
* Merge pull request #12662 from nashby/include-hidden-collectionRafael Mendonça França2014-03-151-0/+7
|\ | | | | | | | | | | | | | | add include_hidden option to collection_check_boxes helper Conflicts: actionview/CHANGELOG.md actionview/test/template/form_collections_helper_test.rb
| * add include_hidden option to collection_check_boxes helperVasiliy Ermolovich2013-10-271-0/+7
| |
* | Clarify AV::Digestor.digest method signature docs and deprecation warningJeremy Kemper2014-03-151-2/+2
| |
* | Fix the resolver cache and stop mutating the lookup_contextRafael Mendonça França2014-03-142-21/+0
| | | | | | | | | | Before we had a bug in the resolver cache so the disable_cache were not working when passing options to find
* | Introduce #with_formats_and_variants to prevent problems with mutating ↵Łukasz Strzałkowski2014-03-142-0/+21
| | | | | | | | finder object
* | Add mocked disable_cache for FixtureFinderŁukasz Strzałkowski2014-03-141-0/+4
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 06:30:07 +0000