| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
| |
https://travis-ci.org/rails/rails/jobs/279300966#L2600
The result of `Loofah::HTML5::Scrub.scrub_css` was changed since
v2.1.0.rc1.
https://github.com/flavorjones/loofah/commit/ca56295ff9e802018ea18d23ed49be235a95ccad
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
|
|
|
|
| |
And enable `context_dependent` of Style/BracesAroundHashParameters cop.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Extend image_tag to accept ActiveStorage's Attachments and Variants
* Flip resolve_image_source around
* Add tests for the new use-cases of image_tag
* Remove the higher-level test
* Update image_tag documentation
* Add error states into the test suite
* Re-raise polymorhic_url's NoMethodError as ArgumentError
* delegate_missing_to will raise DelegationError instead of NoMethodError
|
|\
| |
| | |
Add Active Storage to Rails
|
| |
| |
| |
| | |
Also make sure file_field doesn't mutate the original options passed in.
|
| |
| |
| |
| |
| | |
When Active Storage is not loaded and direct_upload is used on
file_field_tag we should not raise an exception.
|
|/ |
|
| |
|
|\
| |
| | |
Use frozen string literal in actionview/
|
| | |
|
|/
|
|
|
|
| |
Since methods defined in the controller helper are mostly delegated to
the controller, delegate respond_to? as well, so that for example
`respond_to?(:params)` behaves as expected.
|
|
|
|
|
|
|
| |
We have some indentation cops. But now there is a little inconsistent
params indentations. Enable `Layout/FirstParameterIndentation` cop to
prevent newly inconsistent indentation added and auto-correct to
existing violations.
|
| |
|
| |
|
|
|
|
|
| |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
|\
| |
| |
| | |
Enforce frozen string in Rubocop
|
| | |
|
|\ \
| | |
| | |
| | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | |
| | |
| | |
| | | |
Plus a couple of related ActionPack patches.
|
|\ \ \
| | | |
| | | |
| | | | |
Add srcset option to image_tag helper
|
| | |/
| |/| |
|
|/ /
| |
| | |
Fixes https://github.com/rails/rails/issues/29617
|
|/ |
|
|
|
|
|
| |
This makes sure that the labels are linked up with the fields.
Fixes #29014
|
|
|
|
| |
st0012/fix-partial-cache-logging
|
|
|
|
| |
boolean.
|
|
|
|
|
| |
form_with requires people to pass an id manually, so users can just
prefix their namespace right there.
|
| |
|
|\
| |
| | |
Remove requirement on mathn
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The test using mathn was first introduced in f1d9179 to check that the
`distance_of_time_in_words` properly doesn't use the `Fixnum#/` method
by explicitly requiring this library as it redefines this method.
Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since
version 2.2, we can certainly safely assume that people will most-likely
not require this library in their application.
However, to make sure that we don't regress, let's add a test similar to
the one before f1d9179.
|
|\ \
| | |
| | | |
Define path with __dir__
|
| |/
| |
| |
| |
| |
| | |
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
|
|\ \
| |/
|/| |
Fix select tag helper used with Enumerable choices
|
| |
| |
| |
| |
| |
| | |
Allows a custom object implementing Enumerable to be used as the choices
parameter for a select tag, which previously wasn't possible due to the
call to `empty?` on the choices (which isn't implemented on Enumerable).
|
| |
| |
| |
| |
| | |
This allows auto_discovery_link_tag to support the JSON Feed standard.
See https://jsonfeed.org/version/1 for more information.
|
| |
| |
| |
| | |
see: https://bugs.ruby-lang.org/issues/6696
|
|/ |
|
| |
|
|\
| |
| | |
Add tests for rendering with variants
|
| | |
|
|\ \
| | |
| | | |
Ensure input to distance_of_time_in_words is not nil
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Internally all input is converted to time so that it can be treated
uniformly.
Remove now-unneeded condition
* Now that all input is treated is converted to time, we no longer need
to type check it.
Rename variables to clarify their purpose
Extract private method to normalize distance_of_time args to time
Update actionview changelog
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kyuden/remove_unnecessary_attributes_of_select_in_form_with
Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with`
|
| |/ /
| | |
| | |
| | | |
`allow_method_names_outside_object` attributes of select tag in `form_with`
|
|\ \ \
| | | |
| | | | |
`sort_query_string_params` method is no more used
|
| |/ /
| | |
| | |
| | |
| | | |
- This method was added in this commit https://github.com/rails/rails/commit/33258d713a4bc20b71e92fd656c923a7b189cd33
- The last caller got removed there https://github.com/rails/rails/commit/0b6ce3422370647cad3e91263a291f69b313d65b
|
|/ /
| |
| |
| |
| |
| | |
- `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object
- ref https://github.com/rails/rails/pull/27549
- Fixes #28846
|