Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 2 | -1/+351 | |
| | | | ||||||
| * | | Added test case for non-comment. Removed pending assertion that passed. | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | ||||||
| * | | Fixed Nokogiri::CSS::SyntaxErrors. | Timm | 2014-06-15 | 1 | -32/+32 | |
| | | | | | | | | | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters. | |||||
| * | | Replaced html-scanner with Loofah. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Fixed Nokogiri::CSS::SyntaxErrors in test file. | Timm | 2014-06-15 | 1 | -3/+3 | |
| | | | ||||||
| * | | Added ability to pass a custom scrubber to sanitize. Includes test coverage. | Timm | 2014-06-15 | 1 | -0/+36 | |
| | | | ||||||
| * | | Marked tests in sanitize_helper_test.rb as pending. | Timm | 2014-06-15 | 1 | -8/+29 | |
| | | | ||||||
| * | | Marked a test in form_helper_test.rb as pending because of unknown encoding ↵ | Timm | 2014-06-15 | 1 | -0/+2 | |
| | | | | | | | | | | | | ASCII-8BIT output error. | |||||
| * | | Marked some tests as pending in date_helper_test.rb. | Timm | 2014-06-15 | 1 | -0/+4 | |
| | | | ||||||
| * | | Added some tests for ActionView::Sanitizer. | Timm | 2014-06-15 | 1 | -0/+32 | |
| | | | ||||||
| * | | Changed the description of some pending tests. Changed the expected output ↵ | Timm | 2014-06-15 | 1 | -3/+4 | |
| | | | | | | | | | | | | of a script test. | |||||
| * | | Extracted one highlight test method and marked it as pending. | Timm | 2014-06-15 | 1 | -0/+3 | |
| | | | ||||||
| * | | Renamed the SanitizerTest class to SanitersTest, to remove the conflict with ↵ | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | the old SanitizerTest for html-scanner. | |||||
| * | | Added video poster sanitization testing (from @vipulnsward). | Timm | 2014-06-15 | 1 | -0/+5 | |
| | | | ||||||
| * | | Extracted failing tests in santiizers_test.rb into their own methods and ↵ | Timm | 2014-06-15 | 1 | -7/+71 | |
| | | | | | | | | | | | | marked them as pending. | |||||
| * | | Changed expected value from '<b>' to empty string. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Removed the contains_bad_protocols? method as well as the tests for it. ↵ | Timm | 2014-06-15 | 1 | -33/+0 | |
| | | | | | | | | | | | | Loofah already deals with this. | |||||
| * | | Reordered form removal with stripping. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Added Loofah as a dependency in actionview.gemspec. | Timm | 2014-06-11 | 1 | -0/+330 | |
| | | | | | | | | | | | | | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah. | |||||
* | | | Fix escape_once double-escaping hex-encoded entities | John F. Douthat | 2014-07-02 | 2 | -0/+2 | |
| | | | | | | | | | | | | (This is a manual merge of #9102) | |||||
* | | | Add String support for min/max attributes on DatetimeField | Todd Bealmear | 2014-06-30 | 1 | -0/+64 | |
| | | | ||||||
* | | | Deal with regex match groups in excerpt | Gareth Rees | 2014-06-24 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original implementation has bugs if the regex contains a match group. Example: excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5) Expected: "...is a beautiful? mor..." Actual: "...is a beautifulbeaut..." The original phrase was being converted to a regex and returning the text either side of the phrase as expected: 'This is a beautiful? morning'.split(/beautiful/i, 2) # => ["This is a ", "? morning"] When we have a match with groups the match is returned in the array. Quoting the ruby docs: "If pattern is a Regexp, str is divided where the pattern matches. [...] If pattern contains groups, the respective matches will be returned in the array as well." 'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2) # => ["This is a ", "beautiful", "? morning"] If we assume we want to split on the first match – this fix makes that assumption – we can pass the already assigned `phrase` variable as the place to split (because we already know that a match exists from line 168). Originally spotted by Louise Crow (@crowbot) at https://github.com/mysociety/alaveteli/pull/1557 | |||||
* | | | Merge pull request #15450 from aditya-kapoor/remove-nbsp-debug | Rafael Mendonça França | 2014-06-19 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | remove unnecessary gsub for space in ActionView::Helpers#debug | |||||
| * | | | remove unnecessary substitution for space in ActionView::Helpers#debug | Aditya Kapoor | 2014-06-14 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | 'TextHelper#highlight' now accepts a block to highlight the matched words. | Lucas Mazza | 2014-06-19 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The helper will yield each matched word, and you can use this instead of the ':highlighter' option for more complex replacing logic: highlight('My email is me@work.com', EMAIL_REGEXP) { |m| mail_to(m) } # => 'My email is <a href="mailto:me@work.com">me@work.com</a>' | |||||
* | | | | highlight() now accepts regular expressions as well. | Jan Szumiec | 2014-06-19 | 1 | -1/+9 | |
| | | | | ||||||
* | | | | excerpt() now accepts regular expression instances as phrases. | Jan Szumiec | 2014-06-19 | 1 | -0/+2 | |
| | | | | ||||||
* | | | | Merge pull request #15709 from zuhao/refactor_actionview_compiled_templates_test | Yves Senn | 2014-06-18 | 1 | -8/+1 | |
|\ \ \ \ | | | | | | | | | | | Move cleanup into teardown, delete obsolete code. | |||||
| * | | | | Move cleanup into teardown, delete obsolete code. | Zuhao Wan | 2014-06-14 | 1 | -8/+1 | |
| | | | | | ||||||
* | | | | | reload I18n as we are defining `:ts` locale | Kuldeep Aggarwal | 2014-06-15 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | fix build- see https://travis-ci.org/rails/rails/jobs/27578159#L2913. | |||||
* | | | | | Merge pull request #15715 from ↵ | Yves Senn | 2014-06-14 | 3 | -4/+11 | |
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionview_cleanup_I18n_translations Clean up I18n stored translations after test. | |||||
| * | | | | Clean up I18n stored translations after test. | Zuhao Wan | 2014-06-14 | 3 | -4/+12 | |
| | | | | | ||||||
* | | | | | Merge pull request #15712 from zuhao/refactor_actionview_javascript_helper_test | Yves Senn | 2014-06-14 | 1 | -3/+3 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Avoid hard-coded value in test setup and teardown. | |||||
| * | | | | Avoid hard-coded value in test setup and teardown. | Zuhao Wan | 2014-06-14 | 1 | -3/+3 | |
| |/ / / | ||||||
* / / / | Make sure restoration always happen. | Zuhao Wan | 2014-06-14 | 1 | -0/+1 | |
|/ / / | ||||||
* | | | Merge pull request #15654 from pdg137/master | Matthew Draper | 2014-06-13 | 2 | -1/+32 | |
|\ \ \ | | | | | | | | | | | | | In tag helper, honor html_safe on arrays; also make safe_join more similar to Array.join | |||||
| * | | | In tag helper, honor html_safe on array parameters; also make safe_join more ↵ | Paul Grayson | 2014-06-12 | 2 | -1/+32 | |
| |/ / | | | | | | | | | | similar to Array.join by first calling flatten. | |||||
* / / | Add unregister_template_handler to prevent leaks. | Zuhao Wan | 2014-06-12 | 2 | -4/+24 | |
|/ / | ||||||
* | | Removed CaptureHelper#flush_output_buffer as it is only used in tests. | Ryan Davis | 2014-06-04 | 2 | -82/+0 | |
| | | | | | | | | reviewed: @tenderlove | |||||
* | | Fix AS::NumberHelper results with rationals | Juanjo Bazán | 2014-05-31 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | :precision was incorrectly being applied to Rationals before: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.3" after: ActiveSupport::NumberHelper.number_to_rounded Rational(10, 3), precision: 2 => "3.33" | |||||
* | | Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_url | Rafael Mendonça França | 2014-05-16 | 1 | -0/+15 | |
|\ \ | | | | | | | | | | Allow custom asset host to be passed in asset_url | |||||
| * | | Allow custom asset host to be passed in asset_url | Hubert Łępicki | 2014-05-08 | 1 | -0/+15 | |
| | | | ||||||
* | | | minor: point to the right test suite location | azul | 2014-05-14 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix assertion order and :scissors: extra spaces | Carlos Antonio da Silva | 2014-05-13 | 1 | -2/+2 | |
| | | | ||||||
* | | | Merge pull request #15068 from josepjaume/patch-1 | Aaron Patterson | 2014-05-13 | 1 | -0/+6 | |
|\ \ \ | | | | | | | | | Dup options hash to prevent modifications | |||||
| * | | | Dup options hash to prevent modifications | Josep Jaume Rey | 2014-05-13 | 1 | -0/+6 | |
| |/ / | | | | | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object. | |||||
* / / | simplified route method name generation | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -0/+2 | |
|/ / | ||||||
* | | Include label value in i18n attribute lookup | Joshua Cody | 2014-05-06 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post". | |||||
* | | always pass options to the _url method | Aaron Patterson | 2014-05-01 | 1 | -3/+13 | |
| | | ||||||
* | | always use File.join | phoet | 2014-05-01 | 1 | -0/+8 | |
| | |