aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Suppress `warning: BigDecimal.new is deprecated`Yasuo Honda2017-12-152-7/+7
| | | | | | | | | | | | | | | | | | | | `BigDecimal.new` has been deprecated in BigDecimal 1.3.3 which will be a default for Ruby 2.5. Refer https://github.com/ruby/bigdecimal/commit/533737338db915b00dc7168c3602e4b462b23503 * This commit has been made as follows: ``` cd rails git grep -l BigDecimal.new | grep -v guides/source/5_0_release_notes.md | grep -v activesupport/test/xml_mini_test.rb | xargs sed -i -e "s/BigDecimal.new/BigDecimal/g" ``` - `activesupport/test/xml_mini_test.rb` Editmanually to remove `.new` and `::` - guides/source/5_0_release_notes.md This is a Rails 5.0 release notes.
* Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the futureRyuta Kamizono2017-12-141-1/+1
| | | | Follow up of #31432.
* Enable `Layout/SpaceBeforeComma` rubocop rule, and fixed moreRyuta Kamizono2017-12-123-5/+5
| | | | Follow up of #31390.
* Merge pull request #30361 from mfo/masterEileen M. Uchitelle2017-12-111-1/+20
|\ | | | | StreamingTemplateRenderer fails to forward I18n.locale in layouts
| * fix(streaming_template_renderer): I18n.locale broken in layout. I18n gem ↵mfo2017-11-251-1/+20
| | | | | | | | stores the current locale in Thread.current[:local] (see: https://github.com/svenfuchs/i18n/blob/master/lib/i18n.rb#L23). StreamingTemplateRenderer is implemented with Fiber which have its own stack of locals and can not access Thread.current.locals(keys, see: https://ruby-doc.org/core-2.2.0/Thread.html#class-Thread-label-Fiber-local+vs.+Thread-local).
* | Add preload_link_tag helper.Guillermo Iguaran2017-11-281-0/+15
| | | | | | | | | | | | | | | | | | | | | | This helper creates a link tag with preload keyword that allows to browser to initiate early fetch of resources. Additionally this send Early Hints if supported. See https://github.com/rails/rails/pull/30744/commits/59a02fb7bcbe68f26e1e7fdcec45c00c66e4a065 for more details about Early Hints. Preload spec: https://w3c.github.io/preload/
* | Make sure the request exist befoe trying to send early hintsRafael Mendonça França2017-11-281-0/+30
| | | | | | | | | | | | | | Action Mailer context for example responds to request but don't have a a request object. Fixes #31265
* | Make form_with_generates_ids default value to be falseRafael Mendonça França2017-11-271-0/+9
| | | | | | | | | | This will keep the behavior of an application with the defaults of a 4.2 or 5.0 application behaving the same when upgrading to 5.2.
* | Enable `Style/DefWithParentheses` rubocop ruleRyuta Kamizono2017-11-272-2/+2
|/ | | | | | | The def with blank `()` was newly added in #31176, but we have not used the blank `()` style in most part of our code base. So I've enabled `Style/DefWithParentheses` to prevent to newly added the code.
* Add test to make sure form_for is not affected byRafael Mendonça França2017-11-251-0/+32
| | | | form_with_generates_ids
* Change `form_with` to generates ids by defaultnpezza932017-11-251-190/+218
| | | | | | | | | | When `form_with` was introduced we disabled the automatic generation of ids that was enabled in `form_for`. This usually is not an good idea since labels don't work when the input doesn't have an id and it made harder to test with Capybara. You can still disable the automatic generation of ids setting `config.action_view.form_with_generates_ids` to `false.`
* Fix field_error_proc wrap form select optgroup and divider option tagneumayr2017-11-092-1/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | ### Summary The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`. * Fix for `field_error_proc` wraps form select `optgroup` * Fix for `field_error_proc` wraps form select divider `option` * Add tests for uncovered elements with errors [Fixes #31088] #### Test coverage * `test_select_grouped_options_with_errors` * `test_time_zone_select_with_priority_zones_and_errors` #### Extend test coverage * `test_collection_select_with_errors` * `test_label_with_errors` * `test_check_box_with_errors` * `test_check_boxes_with_errors` * `test_radio_button_with_errors` * `test_radio_buttons_with_errors` * `test_collection_check_boxes_with_errors` * `test_collection_radio_buttons_with_errors`
* Fix "warning: instance variable @defined_root not initialized"yuuji.yaginuma2017-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | Currently, the following error is shows only when run the test using `bin/test`. ``` ./bin/test -w test/template/log_subscriber_test.rb Run options: --seed 17167 # Running: /rails/actionview/test/template/log_subscriber_test.rb:34: warning: instance variable @defined_root not initialized ``` In `AVLogSubscriberTest`, if the `Rails.root` is not defined, define the method and undef it in teardown. https://github.com/rails/rails/blob/master/actionview/test/template/log_subscriber_test.rb#L21..L33 However, in `bin/test`, `Rails.root` is defined, which results in referring to uninitialized variables and warnings.
* Remove deprecated Erubis ERB handlerRafael Mendonça França2017-10-231-15/+0
|
* Remove unused `FixtureTemplate` classyuuji.yaginuma2017-10-191-11/+0
| | | | `FixtureTemplate` is no longer used since 3d7892d.
* Implement H2 Early Hints for Railseileencodes2017-10-042-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When puma/puma#1403 is merged Puma will support the Early Hints status code for sending assets before a request has finished. While the Early Hints spec is still in draft, this PR prepares Rails to allowing this status code. If the proxy server supports Early Hints, it will send H2 pushes to the client. This PR adds a method for setting Early Hints Link headers via Rails, and also automatically sends Early Hints if supported from the `stylesheet_link_tag` and the `javascript_include_tag`. Once puma supports Early Hints the `--early-hints` argument can be passed to the server to enable this or set in the puma config with `early_hints(true)`. Note that for Early Hints to work in the browser the requirements are 1) a proxy that can handle H2, and 2) HTTPS. To start the server with Early Hints enabled pass `--early-hints` to `rails s`. This has been verified to work with h2o, Puma, and Rails with Chrome. The commit adds a new option to the rails server to enable early hints for Puma. Early Hints spec: https://tools.ietf.org/html/draft-ietf-httpbis-early-hints-04 [Eileen M. Uchitelle, Aaron Patterson]
* Add test case for `font_url`yuuji.yaginuma2017-10-031-0/+26
| | | | Since test of `font_url` was not in Action View's test suite, so it added.
* Fix `test_should_sanitize_illegal_style_properties` failureRyuta Kamizono2017-09-251-2/+2
| | | | | | | | | https://travis-ci.org/rails/rails/jobs/279300966#L2600 The result of `Loofah::HTML5::Scrub.scrub_css` was changed since v2.1.0.rc1. https://github.com/flavorjones/loofah/commit/ca56295ff9e802018ea18d23ed49be235a95ccad
* Make sure image_alt is deprecatedRafael Mendonça França2017-08-231-5/+15
|
* Remove alt generation from image_submit_tagRafael Mendonça França2017-08-231-1/+1
|
* Do not generate default alt text in image tagsCameron Cundiff2017-08-171-16/+16
| | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* Fix RuboCop offensesKoichi ITO2017-08-166-67/+67
| | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-071-3/+0
| | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-042-0/+68
|\ | | | | Add Active Storage to Rails
| * Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-031-0/+31
| | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| * Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-031-0/+37
| | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
* | Allow non-English values for collection_radio_buttons/check_boxescolorfulfool2017-08-021-0/+14
|/
* Fix testing helpers that use Action View's capturing helpers (e.g. content_for)George Claghorn2017-07-251-0/+8
|
* Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-2446-0/+91
|\ | | | | Use frozen string literal in actionview/
| * Use frozen string literal in actionview/Kir Shatrov2017-07-2446-0/+91
| |
* | Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-191-0/+11
|/ | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-172-24/+24
| | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
* [Action View] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-111-0/+1
|
* Expectation firstAkira Matsuda2017-07-022-8/+8
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0246-46/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0246-0/+46
|\ | | | | | | Enforce frozen string in Rubocop
| * Enforce frozen string in RubocopKir Shatrov2017-07-0146-0/+46
| |
* | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-0211-209/+209
|\ \ | | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| * | Make ActionView frozen string literal friendly.Pat Allan2017-06-2011-209/+209
| | | | | | | | | | | | Plus a couple of related ActionPack patches.
* | | Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-021-1/+4
|\ \ \ | | | | | | | | | | | | Add srcset option to image_tag helper
| * | | Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-291-1/+4
| | |/ | |/|
* / | Fallback Parameters#to_s to Hash#to_sKir Shatrov2017-06-301-0/+6
|/ / | | | | Fixes https://github.com/rails/rails/issues/29617
* / Fix current_page? helper issue with engine root pathsavroff2017-06-191-3/+13
|/
* Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-111-18/+18
| | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* Merge pull request https://github.com/rails/rails/pull/28637 from ↵Kasper Timm Hansen2017-06-081-21/+26
| | | | st0012/fix-partial-cache-logging
* Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-081-0/+40
| | | | boolean.
* Don't support namespace in form_with.Kasper Timm Hansen2017-06-071-18/+0
| | | | | form_with requires people to pass an id manually, so users can just prefix their namespace right there.
* Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-031-2/+1
|
* Merge pull request #29187 from robin850/remove-mathnRafael França2017-05-301-3/+11
|\ | | | | Remove requirement on mathn
| * Remove requirement on mathnRobin Dupret2017-05-301-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | The test using mathn was first introduced in f1d9179 to check that the `distance_of_time_in_words` properly doesn't use the `Fixnum#/` method by explicitly requiring this library as it redefines this method. Given that `mathn` has been gemified in Ruby 2.5 and is deprecated since version 2.2, we can certainly safely assume that people will most-likely not require this library in their application. However, to make sure that we don't regress, let's add a test similar to the one before f1d9179.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 02:18:01 +0000