Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Fixed deprecated selector in form_collections_helper_test.rb with from ↵ | Timm | 2014-06-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | catch_invalid_selector. Sweet. | |||||
| * | | Removed sanitizers- and scrubbers_test.rb. They are in rails-html-sanitizer. | Timm | 2014-06-16 | 2 | -645/+0 | |
| | | | ||||||
| * | | Included DomAssertions in url_helper- and atom_feed_helper_test.rb. | Timm | 2014-06-16 | 2 | -1/+3 | |
| | | | ||||||
| * | | Removed assert_select test file, since it has been moved to rails-dom-testing. | Timm | 2014-06-16 | 1 | -365/+0 | |
| | | | ||||||
| * | | Changed ActiveSupport::Derprecation.silence to assert_deprecated. | Timm | 2014-06-16 | 1 | -2/+2 | |
| | | | ||||||
| * | | Silenced deprecation warnings in the tests. Documentation uses present ↵ | Timm | 2014-06-16 | 1 | -2/+6 | |
| | | | | | | | | | | | | tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception. | |||||
| * | | Added deprecation warning for invalid selectors and skipping assertions. | Timm | 2014-06-16 | 1 | -0/+11 | |
| | | | ||||||
| * | | Added tests for TargetScrubber. | Timm | 2014-06-16 | 1 | -0/+31 | |
| | | | ||||||
| * | | Rounded out PermitScrubber tests. Extracted helper methods to a ScrubberTest ↵ | Timm | 2014-06-16 | 1 | -8/+80 | |
| | | | | | | | | | | | | class. | |||||
| * | | Moved some tests to scrubbers_test.rb. Added better testing of accessor ↵ | Timm | 2014-06-16 | 2 | -6/+21 | |
| | | | | | | | | | | | | validation. | |||||
| * | | Added some test coverage for PermitScrubber. | Timm | 2014-06-16 | 1 | -0/+80 | |
| | | | ||||||
| * | | Now returning html if html is blank? in FullSanitizer and ↵ | Timm | 2014-06-16 | 1 | -4/+4 | |
| | | | | | | | | | | | | WhiteListSanitizer. This means it'll return false if called with false, however that is not a valid use case. | |||||
| * | | Changed test expectation from '<<' to '' with string to sanitize '<<<bad ↵ | Timm | 2014-06-16 | 1 | -4/+2 | |
| | | | | | | | | | | | | html>' in sanitizers_test. | |||||
| * | | Removed a bunch of duplicated tests in SanitizeHelperTest. | Timm | 2014-06-16 | 1 | -37/+0 | |
| | | | ||||||
| * | | Simplified the removal of xpaths in remove_xpaths. Added more tests for ↵ | Timm | 2014-06-16 | 1 | -8/+11 | |
| | | | | | | | | | | | | remove_xpaths. | |||||
| * | | Renamed: remove_xpaths tests no longer prefixed with sanitizer. | Timm | 2014-06-16 | 1 | -6/+6 | |
| | | | ||||||
| * | | Changed: remove_xpaths called with String returns String, while called with ↵ | Timm | 2014-06-16 | 1 | -0/+11 | |
| | | | | | | | | | | | | Loofah fragment returns Loofah fragment. Added tests for this. | |||||
| * | | Fixed: spelling mistake in SanitizeHelperTest. | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | ||||||
| * | | Added related Nokogiri issue link to tests that fail with unknown encoding ↵ | Timm | 2014-06-16 | 2 | -6/+6 | |
| | | | | | | | | | | | | ASCII-8BIT. | |||||
| * | | Added correct requires in html-scanner tests. Sanitizers are not based on ↵ | Timm | 2014-06-16 | 7 | -330/+6 | |
| | | | | | | | | | | | | html-scanner anymore, so sanitizer_test.rb is removed. | |||||
| * | | Marked test_feed_xhtml as pending. See description in the test. | Timm | 2014-06-16 | 1 | -0/+1 | |
| | | | ||||||
| * | | Moved Dom and Selector assertions from ActionDispatch to ActionView. | Timm | 2014-06-16 | 2 | -1/+351 | |
| | | | ||||||
| * | | Added test case for non-comment. Removed pending assertion that passed. | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | ||||||
| * | | Fixed Nokogiri::CSS::SyntaxErrors. | Timm | 2014-06-15 | 1 | -32/+32 | |
| | | | | | | | | | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters. | |||||
| * | | Replaced html-scanner with Loofah. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Fixed Nokogiri::CSS::SyntaxErrors in test file. | Timm | 2014-06-15 | 1 | -3/+3 | |
| | | | ||||||
| * | | Added ability to pass a custom scrubber to sanitize. Includes test coverage. | Timm | 2014-06-15 | 1 | -0/+36 | |
| | | | ||||||
| * | | Marked tests in sanitize_helper_test.rb as pending. | Timm | 2014-06-15 | 1 | -8/+29 | |
| | | | ||||||
| * | | Marked a test in form_helper_test.rb as pending because of unknown encoding ↵ | Timm | 2014-06-15 | 1 | -0/+2 | |
| | | | | | | | | | | | | ASCII-8BIT output error. | |||||
| * | | Marked some tests as pending in date_helper_test.rb. | Timm | 2014-06-15 | 1 | -0/+4 | |
| | | | ||||||
| * | | Added some tests for ActionView::Sanitizer. | Timm | 2014-06-15 | 1 | -0/+32 | |
| | | | ||||||
| * | | Changed the description of some pending tests. Changed the expected output ↵ | Timm | 2014-06-15 | 1 | -3/+4 | |
| | | | | | | | | | | | | of a script test. | |||||
| * | | Extracted one highlight test method and marked it as pending. | Timm | 2014-06-15 | 1 | -0/+3 | |
| | | | ||||||
| * | | Renamed the SanitizerTest class to SanitersTest, to remove the conflict with ↵ | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | the old SanitizerTest for html-scanner. | |||||
| * | | Added video poster sanitization testing (from @vipulnsward). | Timm | 2014-06-15 | 1 | -0/+5 | |
| | | | ||||||
| * | | Extracted failing tests in santiizers_test.rb into their own methods and ↵ | Timm | 2014-06-15 | 1 | -7/+71 | |
| | | | | | | | | | | | | marked them as pending. | |||||
| * | | Changed expected value from '<b>' to empty string. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Removed the contains_bad_protocols? method as well as the tests for it. ↵ | Timm | 2014-06-15 | 1 | -33/+0 | |
| | | | | | | | | | | | | Loofah already deals with this. | |||||
| * | | Reordered form removal with stripping. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | ||||||
| * | | Added Loofah as a dependency in actionview.gemspec. | Timm | 2014-06-11 | 1 | -0/+330 | |
| | | | | | | | | | | | | | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah. | |||||
* | | | Fix escape_once double-escaping hex-encoded entities | John F. Douthat | 2014-07-02 | 2 | -0/+2 | |
| | | | | | | | | | | | | (This is a manual merge of #9102) | |||||
* | | | Add String support for min/max attributes on DatetimeField | Todd Bealmear | 2014-06-30 | 1 | -0/+64 | |
| | | | ||||||
* | | | Deal with regex match groups in excerpt | Gareth Rees | 2014-06-24 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original implementation has bugs if the regex contains a match group. Example: excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5) Expected: "...is a beautiful? mor..." Actual: "...is a beautifulbeaut..." The original phrase was being converted to a regex and returning the text either side of the phrase as expected: 'This is a beautiful? morning'.split(/beautiful/i, 2) # => ["This is a ", "? morning"] When we have a match with groups the match is returned in the array. Quoting the ruby docs: "If pattern is a Regexp, str is divided where the pattern matches. [...] If pattern contains groups, the respective matches will be returned in the array as well." 'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2) # => ["This is a ", "beautiful", "? morning"] If we assume we want to split on the first match – this fix makes that assumption – we can pass the already assigned `phrase` variable as the place to split (because we already know that a match exists from line 168). Originally spotted by Louise Crow (@crowbot) at https://github.com/mysociety/alaveteli/pull/1557 | |||||
* | | | Merge pull request #15450 from aditya-kapoor/remove-nbsp-debug | Rafael Mendonça França | 2014-06-19 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | remove unnecessary gsub for space in ActionView::Helpers#debug | |||||
| * | | | remove unnecessary substitution for space in ActionView::Helpers#debug | Aditya Kapoor | 2014-06-14 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | 'TextHelper#highlight' now accepts a block to highlight the matched words. | Lucas Mazza | 2014-06-19 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The helper will yield each matched word, and you can use this instead of the ':highlighter' option for more complex replacing logic: highlight('My email is me@work.com', EMAIL_REGEXP) { |m| mail_to(m) } # => 'My email is <a href="mailto:me@work.com">me@work.com</a>' | |||||
* | | | | highlight() now accepts regular expressions as well. | Jan Szumiec | 2014-06-19 | 1 | -1/+9 | |
| | | | | ||||||
* | | | | excerpt() now accepts regular expression instances as phrases. | Jan Szumiec | 2014-06-19 | 1 | -0/+2 | |
| | | | | ||||||
* | | | | Merge pull request #15709 from zuhao/refactor_actionview_compiled_templates_test | Yves Senn | 2014-06-18 | 1 | -8/+1 | |
|\ \ \ \ | | | | | | | | | | | Move cleanup into teardown, delete obsolete code. | |||||
| * | | | | Move cleanup into teardown, delete obsolete code. | Zuhao Wan | 2014-06-14 | 1 | -8/+1 | |
| | | | | |