aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-292-2/+2
|
* Move test that depends on ActiveRecordclaudiob2014-11-211-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | This commit moves a test from `test/template` to `test/activerecord` since the test depends on ActiveRecord. This matches the documentation from [RUNNING_UNIT_TESTS](https://github.com/rails/rails/blob/f28d1ddd507174ac233b773cc4f35c3c05ad32e7/actionview/RUNNING_UNIT_TESTS.rdoc): > Test cases in the test/activerecord/ directory depend on having activerecord and sqlite3 installed. > If Active Record is not in actionview/../activerecord directory, or the sqlite3 rubygem is not installed, these tests are skipped. > Other tests are runnable from a fresh copy of actionview without any configuration. --- More details about this commit. All the tests starting with `require 'active_record_unit'` are already inside `test/activerecord`, except for the one test this commit moves. If you don't have `active_record` on your machine, the following command currently fails on master: ```bash ```
* Fix select_tag generating tag when set to false.Guo Xiang Tan2014-11-211-0/+6
| | | | Fixes https://github.com/rails/rails/issues/17701.
* Add `:enforce_utf8` option to form_forclaudiob2014-11-201-3/+33
| | | | | | | | | Since 06388b0 `form_tag` accepts the option `enforce_utf8` which, when set to false, prevents the hidden "UTF8 enforcer" field from appearing in the output. This commit implements the same behavior for `form_for`. Stems from https://github.com/rails/rails/pull/17685#issuecomment-63871395
* Duplicated Hash key :promptAkira Matsuda2014-11-191-1/+1
|
* Improve test of private properties of objects in form tagsRafael Mendonça França2014-10-311-28/+9
|
* Use public_send for form tagsagius2014-10-311-0/+27
|
* Honor public/private in ActionView::Helpers::Tags::Base#valueTobias Pfeiffer2014-10-311-0/+6
| | | | | * use public_send instead of send to avoid calling private methods in form helpers
* Use new hash syntaxRafael Mendonça França2014-10-251-1/+1
|
* :scissors:Rafael Mendonça França2014-10-251-1/+1
|
* Merge pull request #17064 from frenkel/fix_select_tag_include_blankRafael Mendonça França2014-10-251-0/+6
|\ | | | | Use include_blank value as option label
| * Use include_blank value as option labelFrank Groeneveld2014-10-171-0/+6
| | | | | | | | Update select_tag to reflect documentation and behave the same as form builder select. If the value of include_blank is not boolean true, use that value as the option label.
* | Fix how file_ and password_field_tag edit optionsclaudiob2014-10-151-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the behavior of `file_field_tag` and `password_field_tag` when invoked with a hash of options. These two helpers are different from all the other ones in that they modify the options hash passed as a parameter, whereas all the other helpers duplicate it before updating it. The result is that *bad things* can happen if the user re-uses the same hash. For instance, users who write the following code to display a file field followed by a text field (both with the same class): ```rhtml <% options = {class: 'important'} %> <%= file_field_tag 'Upload', options %> <%= text_field_tag 'Name', options %> ``` would instead see **two file fields!** ```html <input class="important" id="Upload" name="Upload" type="file"> <input class="important" id="Name" name="Name" type="file" value="value"> ``` This PR replaces `update` with `merge` in the code of the two helpers, fixing the issue above. The included test verifies the change, since it passes after this PR, but fails before with the following error: ``` Expected: <input type="text" name="title" id="title" value="Hello!" class="important" /> Actual: <input type="password" name="title" id="title" value="Hello!" class="important" /> ```
* | remove un-needed sortschneems2014-10-072-9/+8
| | | | | | | | | | | | HTML doesn't care what order the elements are rendered in, so why should we? Updates tests to use proper `assert_dom_equal` instead of `assert_equal` /cc @jeremy
* | Change `gsub` to `tr` where possibleAlexander Balashov2014-10-061-1/+1
| |
* | Added processing of `nil` to `highlight` helper methodigor042014-09-301-0/+4
|/
* handle <%== nil %> casesAaron Patterson2014-09-141-0/+4
| | | | | This is much less common than string literal appends, so add a special case method for it. Maybe fixes bug reported by @jeremy on 97ef636191933f1d4abc92fc10871e6d1195285c
* Revert "Merge pull request #15312 from JuanitoFatas/action_view/asset_path"Matthew Draper2014-09-141-0/+11
| | | | | | | This reverts commit 21ec7fefea5a1b823cb88733b019b3d52240801d. Per #16911, there's actually a good reason for a "blank" value to have a useful `to_s` here. So let's also add some tests to prove that.
* Do not memoize document_root_element in view testsRafael Mendonça França2014-09-081-0/+11
| | | | | | | Memoizing will not make possible to assert the output of the view if it is changed after the first assert_select call Related with plataformatec/simple_form#1130 and rails/rails-dom-testing#15
* fix the undefined method content_tag #15245Rajarshi Das2014-09-061-1/+0
| | | | not required include ActionView::Helpers::TagHelper in test as well
* Add support for ARIA attributes in tagsPaoMar2014-09-031-0/+7
|
* Ship with rails-html-sanitizer instead.Kasper Timm Hansen2014-09-031-1/+1
|
* Merge pull request #16488 from agrobbin/form-label-builderJeremy Kemper2014-08-251-0/+9
|\ | | | | Provide a builder for form labels to customize wrapping around I18n content
| * provide a builder for form labels to customize wrapping around I18n contentAlex Robbin2014-08-201-0/+9
| |
* | just use the placeholder tag value if it is passed as a StringAlex Robbin2014-08-221-4/+19
| |
* | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-221-0/+168
| |
* | Revert "Add I18n support for `:placeholder` HTML option is passed to form ↵Jeremy Kemper2014-08-211-168/+0
|/ | | | fields"
* Fix assertion to map the behaviour of the old sanitizerRafael Mendonça França2014-08-181-1/+1
|
* Merge branch 'master' into loofahRafael Mendonça França2014-08-171-0/+168
|\ | | | | | | | | Conflicts: actionpack/CHANGELOG.md
| * add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-121-0/+168
| |
* | Merge branch 'master' into loofahRafael Mendonça França2014-08-127-3/+93
|\| | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md
| * Fixed #select form builder helper to support block with html outputBogdan Gusiev2014-08-051-0/+13
| |
| * Fix that render layout should also be picked up by the template dependency ↵David Heinemeier Hansson2014-07-251-0/+15
| | | | | | | | tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
| * adding missing test for text area value before type castEugene Gilburg2014-07-191-0/+7
| |
| * adding missing test coverageEugene Gilburg2014-07-181-0/+12
| |
| * subclass Rails::EngineAaron Patterson2014-07-161-1/+2
| |
| * Build only one PartialIteration object for loopRafael Mendonça França2014-07-161-5/+8
| |
| * No need to have a file to PartialIteration classRafael Mendonça França2014-07-161-3/+2
| | | | | | | | This class is only used on the PartialRenderer.
| * Added PartialIteration class used when rendering collectionsJoel Junström2014-07-162-1/+32
| | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
| * Return an absolute instead of relative path from an asset url in the case of ↵Jolyon Pawlyn2014-07-151-0/+8
| | | | | | | | the `asset_host` proc returning nil
| * Assert the nature of the original exceptionMatthew Draper2014-07-121-0/+1
| | | | | | | | | | | | Just so it's clearer what's going on in the following assertion. /cc #11993 @robin850
| * Merge pull request #11993 from razielgn/actionview-use-name-to-inspect-errorGuillermo Iguaran2014-07-111-1/+1
| |\ | | | | | | Use NameError#name to assert raised error.
| | * Use NameError#name to assert raised error.Federico Ravasio2013-11-241-1/+1
| | | | | | | | | | | | | | | This makes the test compatible with other Ruby implementations, which may implement error messages differently.
* | | Use regexp instead exact match for atom testRafael Mendonça França2014-07-151-3/+2
| | | | | | | | | | | | | | | | | | There are two xml namespaces in the response body and the xhtml namespace is not registered in the root node. This create an invalid XML and nokogiri can't navigate using xpath on that node.
* | | All these tests are passing nowRafael Mendonça França2014-07-153-7/+0
| | |
* | | We don't need loofah for the assertionsRafael Mendonça França2014-07-151-1/+1
| | | | | | | | | | | | We can just use nokogiri
* | | Include the selector assertions on the test caseRafael Mendonça França2014-07-151-2/+0
| | | | | | | | | | | | | | | We don't need to require users to include this module on ActionMailer::TestCase
* | | Merge pull request #11218 from kaspth/loofah-integrationRafael Mendonça França2014-07-1015-1088/+79
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md
| * | Change date helper tests to expect attributes with double quoted strings.Timm2014-06-161-14/+15
| | |
| * | Fix invalid css selectors in form_collections_helper_test.rb.Timm2014-06-161-11/+11
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 19:02:46 +0000