aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
* Escalate missing error when :raise is trueShota Fukumori (sora_h)2013-12-051-0/+6
| | | | | | | | | | | | | | Before ec16ba75a5493b9da972eea08bae630eba35b62f, ActionView::Helpers::TranslationHelper#translate has raised errors with specifying options[:raise] to true. This should work by this fix: begin t(:"translations.missing", raise: true) rescue I18n::MissingTranslationData p :hello! end
* Added \u2028 \u2029 to json_escapeGodfrey Chan2013-12-041-1/+2
|
* Use lower case letters in unicodes sequences to match the new encoder's outputGodfrey Chan2013-12-041-3/+3
|
* Added failing test for json_escape striping quotation marksGodfrey Chan2013-12-041-0/+45
| | | | Expanded test coverage for html_escape and json_escape
* Fix issue where TextHelper#simple_format was calling missing 'raw' methodMario Visic2013-12-051-0/+5
|
* Action Pack VariantsŁukasz Strzałkowski2013-12-042-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, variants in the templates will be picked up if a variant is set and there's a match. The format will be: app/views/projects/show.html.erb app/views/projects/show.html+tablet.erb app/views/projects/show.html+phone.erb If request.variant = :tablet is set, we'll automatically be rendering the html+tablet template. In the controller, we can also tailer to the variants with this syntax: class ProjectsController < ActionController::Base def show respond_to do |format| format.html do |html| @stars = @project.stars html.tablet { @notifications = @project.notifications } html.phone { @chat_heads = @project.chat_heads } end format.js format.atom end end end The variant itself is nil by default, but can be set in before filters, like so: class ApplicationController < ActionController::Base before_action do if request.user_agent =~ /iPad/ request.variant = :tablet end end end This is modeled loosely on custom mime types, but it's specifically not intended to be used together. If you're going to make a custom mime type, you don't need a variant. Variants are for variations on a single mime types.
* Stop using i18n's built in HTML error handling.Michael Koziarski2013-12-021-1/+1
| | | | | | | | | i18n doesn't depend on active support which means it can't use our html_safe code to do its escaping when generating the spans. Rather than try to sanitize the output from i18n, just revert to our old behaviour of rescuing the error and constructing the tag ourselves. Fixes: CVE-2013-4491
* Escape the unit value provided to number_to_currencyMichael Koziarski2013-12-021-1/+2
| | | | | | Previously the unit values were trusted leading to potential XSS vulnerabilities. Fixes: CVE-2013-6415
* `ActionView::MissingTemplate` for partials includes underscore.Yves Senn2013-12-022-4/+4
| | | | | | Missing partial folder/_partial instead of folder/partial. Closes #13002.
* More typo fixesAkira Matsuda2013-11-271-1/+1
|
* Minor typo fixesAkira Matsuda2013-11-271-1/+1
|
* Use `set_backtrace` instead of `@backtrace` in ActionView errorShimpei Makimoto2013-11-161-0/+7
|
* fix simple_format escapes own output when sanitize is set to truepseidemann2013-11-081-0/+5
|
* Warnings removed for ruby trunkArun Agrawal2013-11-011-1/+1
| | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* Convert CDATA input to string before gsub'ingCarsten Zimmermann2013-10-291-0/+4
| | | | | Rails 3.2 API allowed arbitrary input for cdata_section; this change re-introduces the old behaviour.
* Merge pull request #10471 from andyw8/button_to_paramsRafael Mendonça França2013-10-241-0/+7
|\ | | | | | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md
| * Add params option for button_toAndy Waite2013-09-181-0/+7
| | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes.
* | Ensure the state is clean after one failureRafael Mendonça França2013-10-161-5/+4
| |
* | Add 2 tests, 1 of which fails, to isolate the digest_caching behaviour ↵Brad Murray2013-10-151-0/+26
| | | | | | | | | | | | | | | | | | | | causing #12521 If config.action_view.cache_template_loading = false, most likely in a development configuration if config.cache_classes = false & config.action_controller.perform_caching = true. config.action_view.cache_template_loading defaults to the value of config.cache_classes
* | Use the given name in html_options for the hidden field in ↵Angel N. Sciortino2013-09-241-0/+7
| | | | | | | | collection_check_boxes
* | Fix some edge cases for AV `select` helper with `:selected` optionBogdan Gusiev2013-09-231-0/+16
| |
* | Ability to pass block to AV#select helperBogdan Gusiev2013-09-231-0/+15
| | | | | | | | | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
* | handle `:namespace` form option in collection labelsVasiliy Ermolovich2013-09-221-0/+36
| |
* | Bust the template digest cache key when details are changedDaniel Schierbeck2013-09-191-1/+29
| | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value.
* | There's no need to do thisSantiago Pastorino2013-09-171-4/+1
| | | | | | | | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code.
* | "generates" applies to "collection radio" so it should be singularWaynn Lue2013-09-121-2/+2
| | | | | | I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails).
* | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-asRafael Mendonça França2013-09-121-0/+12
|\ \ | | | | | | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md
| * | form_for - fix :namespace and :as options clashAdam Niedzielski2013-09-091-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it
* | | Cleanup of excerpt helperPaul Nikitochkin2013-09-061-0/+3
|/ / | | | | | | | | * replaced String concatenation by joining * separator has default value to '', even it is nil
* | Fix failure with minitest 5.0.7Carlos Antonio da Silva2013-09-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Require minitest/mock in test where stub method is needed. Apparently this was being "imported" by minitest pride plugin, which previously required "minitest/autorun", that required "minitest/mock", making the method available by chance. It has been changed in minitest: https://github.com/seattlerb/minitest/commit/595ce955c0d89575726d10fc18d2afd8f334bcbe So we need to make sure we require what we really need where necessary.
* | Merge pull request #12143 from rajcybage/fixing_typosCarlos Antonio da Silva2013-09-051-1/+1
|\ \ | | | | | | fix actionview and activemodel test cases typos
| * | fix actionview and activemodel test cases typosRajarshi Das2013-09-051-1/+1
| | |
* | | Fix method name typosVipul A M2013-09-052-2/+2
|/ /
* | Merge pull request #11768 from cloudspace/cache_template_loadingRafael Mendonça França2013-08-271-2/+11
|\ \ | | | | | | Only cache template digests if !config.cache_template_loading
| * | Only cache template digests if config.cache_template_loadingJosh Lauer2013-08-061-2/+11
| | | | | | | | | | | | | | | | | | since ActionView::Resolver.caching is set to the same value as config.cache_template_loading only cache template digests if config.cache_template_loading is not falsy fixes issues #10752 and #10791
* | | Fix AV tests, I18nProxy was moved to AVŁukasz Strzałkowski2013-08-251-1/+1
| |/ |/|
* | Remove privatizing of Fixnum#/ from assert_distance_of_time_in_wordsAlex Tambellini2013-08-051-5/+7
|/ | | | | | | | MRI reimplemented Date in C so it doesn't hit this division anymore while JRuby still uses the old stdlib implementation of Date so it will always hit this. With this change the actionview date_helper_test.rb tests should pass on JRuby.
* Add "extname" option to javascript_include_tagNathan Stitt2013-08-031-0/+7
| | | | | | | | | | | | ActionView::Helpers.asset_path is where the logic for javascript_include_tag resides. It takes an extname option for specifying the extension or false to not append it. This exposes that option to javascript_include_tag. Without the option files that didn't end with ".js" would get the extension appended to them. This broke JST templates and other file types that should be interpreted as JavaScript but who's file extension isn't ".js"
* Make current_page? compare binary stringsRafael Mendonça França2013-08-011-0/+8
|
* Fix `current_page?` when the URL contains escaped charactersRafael Mendonça França2013-08-011-0/+13
| | | | | | | In some cases webservers like nginx send the escaped characters lowercased to the Rails application. The current_page? helper was comparing the escaped strings that are different since Ruby escapes the URL using uppercased characters.
* text_area should handle nil value option like text_fieldJoel Cogen2013-07-241-0/+7
|
* add support for html attributes to grouped_options_for_selectVasiliy Ermolovich2013-07-201-0/+10
|
* Fix test name typosVipul A M2013-07-191-2/+2
|
* Fix default rendered format problem when calling render method without ↵kennyj2013-07-151-0/+5
| | | | :content_type option. Closes #11393.
* Merge pull request #11348 from sanemat/fix/link-to-blockRafael Mendonça França2013-07-071-0/+7
|\ | | | | Fix actionview link_to with block and url_hash
| * Fix link_to with block and url_hashsanemat2013-07-071-0/+7
| | | | | | | | | | | | Use link_to with block and url_hash, expect block as name. But ignore block and use url_hash as name. 3-2-stable passes this test. 4-0-stable and master fail this.
* | Fix "Stack Level Too Deep" error when rendering recursive partialsRafael Mendonça França2013-07-071-0/+25
| | | | | | | | | | | | | | When rendering recursive partial Action View is trying to generate the view digest infinitly causing a stack level error. Fixes #11340
* | Added an `enforce_utf8` hash option for `form_tag` methodTakayuki Matsubara2013-07-071-1/+16
|/ | | | | | | | | | | | | | | | | | Control to output a hidden input tag with name `utf8` without monkey patching Before: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' After: form_tag # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>' form_tag({}, { :enforce_utf8 => false }) # => '<form>....</form>'
* Remove action view test duplicationsanemat2013-07-071-3/+0
| | | | Same test exists above 2 or 3 lines.
* Remove `FormBuilder` deprecation warning about block argument and associated ↵Vipul A M2013-07-021-12/+0
| | | | tests
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 04:14:34 +0000