aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
* use the right assertions.Yves Senn2015-05-051-2/+2
| | | | | | | Prompted by: https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496 /cc @kuldeepaggarwal
* Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-041-14/+2
| | | | supported by I18n.
* Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-051-0/+13
|\ | | | | Handle raise flag in translate when both main and default translation is missing.
| * Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-041-0/+13
| | | | | | | | missing. Fixes #19967
* | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-031-0/+8
|\ \ | |/ |/| Actionview image tag size option override
| * image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-241-0/+8
| |
* | add test-case for `link_to_if` behavior with a block.Yves Senn2015-05-011-0/+10
| | | | | | | | | | | | | | This illustrates the purpose of the block for `link_to_if` and `link_to_unless` helper methods. It should help to prevent further mistakes like #19844.
* | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-011-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-011-0/+5
|\ \ | | | | | | | | | Update url_helper.rb
* | | :put_litter_in_its_place: Unused methodsAkira Matsuda2015-04-251-8/+0
| | |
* | | :put_litter_in_its_place: Unused methodAkira Matsuda2015-04-251-6/+0
| |/ |/| | | | | This method is not in use since 479c7cacd5db58ab7200bc1de58c829a1a643278
* | Silence warning from requiring mathnPrem Sichanugrist2015-04-221-1/+1
|/ | | | | | | | | Running Action View test case currently printing out this warning: lib/mathn.rb is deprecated This should silence the warning since we really want to require this file in this test.
* Override default form builder for a controllerKevin McPhillips2015-04-132-0/+45
|
* Accept lambda as child_index option in #fields_for methodKarol Galanciak2015-04-051-0/+17
|
* Allow an array to be a default translation value.Adam Prescott2015-04-041-0/+5
| | | | | | | | | | | 4.2.1 introduced a change to the way `translate`/`t` works with an option of `default: [[]]`. In 4.2.0, this would give a default value of `[]`, but in 4.2.1, it leads to a missing translation. `default: [[]]` is again allowed for cases where a default of `[]` is needed. This addresses GitHub issue 19640.
* Merge pull request #19421 from jcoyne/translate_defaults_with_nilRafael Mendonça França2015-03-201-0/+5
| | | | Strip nils out of default translations. Fixes #19419
* [Fix Select tag Tests] Test correct use of multiple option for selectAkshay Vishnoi2015-03-201-4/+4
|
* Cleaning JavaScriptHelperTestThiago Pradi2015-03-141-8/+1
|
* Zlib isn't required for AssetTagHelperTest anymoreThiago Pradi2015-03-141-1/+0
|
* Let strip_tags leave HTML escaping to Rails.Kasper Timm Hansen2015-03-101-0/+4
| | | | Prevents double escaping errors, such as "&amp;" becoming "&amp;amp;".
* `number_to_percentage` and `precision: 0` work with `NAN` and `INFINITY`.Yves Senn2015-03-061-0/+4
| | | | Closes #19227.
* fix ActionView::Template::Error when using Streaming with capture.yuuji.yaginuma2015-03-011-0/+4
| | | | can't acquire a encoding from StreamingBuffer. fixes #12001
* Fix regression when passing a value different of String.Ulisses Almeida2015-02-261-0/+5
| | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.
* Merge pull request #19074 from ↵Rafael Mendonça França2015-02-251-1/+0
|\ | | | | | | | | Mession/fix_test_dependency_of_erb_template_partial_with_layout Fix dependency tracker bug
| * Fix dependency tracker bugJuho Leinonen2015-02-251-1/+0
| |
* | Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-251-0/+38
|\ \ | |/ |/| Merge multi_fetch_fragments.
| * Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-211-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-201-0/+14
| | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | Error message testing fixFranky W2015-02-203-3/+6
| | | | | | | | | | | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* | Merge pull request #17143 from kuldeepaggarwal/fix-mailToRafael Mendonça França2015-02-201-0/+5
|\ \ | | | | | | | | | mail_to helper method fix
| * | do not generate blank options in mailToKuldeep Aggarwal2014-10-021-0/+5
| | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* | | Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-161-87/+3
| | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* | | Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-161-0/+2
| |/ |/| | | | | This makes the behavior more consistent with `width` or `height` options
* | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-061-0/+12
| | | | | | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* | Add tests to make sure label and placeholder respect to_modelRafael Mendonça França2015-02-051-0/+42
| |
* | Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-061-13/+8
| | | | | | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-035-5/+0
| | | | | | | | onwards.
* | Fixed test for deprecation warning in actionview, renaming from ↵Vipul A M2015-01-312-26/+26
| | | | | | | | https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a
* | Eliminate a ruby warning in a test in Action ViewYuki Nishijima2015-01-171-1/+5
| | | | | | | | | | | | | | This eliminates the warning below: actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user? actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
* | Use option url: false to allow entries without a link tagDaniel Gomez de Souza2015-01-161-0/+24
| |
* | Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-141-0/+17
| | | | | | | | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* | Add tests with an explanation of why we're using `_before_type_cast`Sean Griffin2015-01-141-3/+4
| | | | | | | | | | | | | | If you entered incorrect input into a form (particularly with a numericality validation), we should not replace what you typed in with `0`, since clicking submit a second time would essentially be the same as erroneously accepting the junk input as 0.
* | Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-141-1/+1
| | | | | | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* | Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* | Avoid changing the global state on the testsRafael Mendonça França2015-01-051-1/+6
| |
* | Merge pull request #17676 from ↵Rafael Mendonça França2015-01-051-0/+19
|\ \ | | | | | | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832
| * | Fix I18n regression introduced by #13832Christopher Dell2014-11-191-0/+19
| | | | | | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
* | | Use directly TZInfo::Timezone without proxybrainopia2015-01-041-1/+1
| | | | | | | | | | | | | | | Since real timezone is loaded anyway in `#utc_offset` which is called during `#create`
* | | Unsafe default translations should not be marked html_safeJustin Coyne2015-01-021-0/+6
| | | | | | | | | | | | | | | | | | Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257
* | | Merge pull request #17974 from killthekitten/fix-render-blockRafael Mendonça França2015-01-021-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 03:56:38 +0000