aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Fix - Prevent adding of `data-disable-with` option twice in html.Akshay Vishnoi2015-09-181-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Earlier when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." data-disable-with="Processing..." /> ``` Now when `data-disable-with` option is added direclty as in options then ```ruby submit_tag("Save", { "data-disable-with" => "Processing..." }) # => <input type="submit" name="commit" value="Save" data-disable-with="Processing..." /> ```
* | | | | Fix names of test casesAkshay Vishnoi2015-09-291-3/+3
| | | | |
* | | | | Merge pull request #21781 from ronakjangir47/partial_caching_testKasper Timm Hansen2015-09-261-0/+10
|\ \ \ \ \ | | | | | | | | | | | | Added test cases where collection partial cached & rendered with different keys
| * | | | | Added test cases where collection partial cached for different key and ↵Ronak Jangir2015-09-261-0/+10
| | |_|/ / | |/| | | | | | | | | | | | | rendered for different key
* | | | | Merge pull request #21431 from ojab/masterRafael Mendonça França2015-09-261-0/+21
|\ \ \ \ \ | | | | | | | | | | | | Handle nested fields_for by adding indexes to record_name
| * | | | | Handle nested fields_for by adding indexes to record_nameojab2015-08-301-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case of the form with nested fields_for, i. e. <%= form_for :foos, url: root_path do |f| %> <% @foos.each do |foo| %> <%= f.fields_for 'foo[]', foo do |f2| %> <%= f2.text_field :id %> <% foo.bars.each do |bar| %> <%= f2.fields_for 'bar[]', bar do |b| %> <%= b.text_field :id %> <% end %> <% end %> <% end %> <% end %> <%= f.submit %> <% end %> rails doesn't add index for 'foo' in the inner fields_for block, so field names in the outer fields_for looks like "foos[foo][#{foo_index}][id]" and in the inner "foos[foo[]][bar][#{bar_index}][id]". Submitting of such form leads to an error like: >ActionController::BadRequest (Invalid request parameters: expected Array >(got Rack::QueryParser::Params) for param `foo'): This commit adds indexes for the foos in the inner blocks, so field names become "foos[foo][#{foo_index}][bar][#{bar_index}][id]" and submitting of such form works fine as expected. Fixes #15332
* | | | | | Regression test on CollectionCheckBoxes to accept `include_hidden`Mauro George2015-09-241-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | as string
* | | | | | Add a hidden field on the collection_radio_buttonsMauro George2015-09-242-4/+44
| |/ / / / |/| | | | | | | | | | | | | | | | | | | This will avoid a error be raised when the only input on the form is the `collection_radio_buttons`.
* | | | | compare arrays not set objects.Aaron Patterson2015-09-211-3/+3
| |_|/ / |/| | |
* | | | :hocho: TyposAkira Matsuda2015-09-211-1/+1
| | | |
* | | | :scissors: empty line at the top of filesAkira Matsuda2015-09-211-1/+0
| | | |
* | | | Merge pull request #21632 from ↵Kasper Timm Hansen2015-09-181-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kirs/feature/translation-helper-include-interpolation Include interpolation values to translation_missing helper
| * | | | Include interpolation values to translation_missing helperKir Shatrov2015-09-181-0/+6
| | | | |
| * | | | use path escaping for email addressesAaron Patterson2015-09-041-3/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | Due to e25fdad2f147e6f368958f9a06a5ac9d10288408, we are correctly using path escaping for email addresses. This commit fixes the tests to expect path escaping.
* | / / File encoding is defaulted to utf-8 in Ruby >= 2.1Akira Matsuda2015-09-181-1/+0
| |/ / |/| |
* | | `url_for` does not modify polymorphic optionsBernerd Schaefer2015-09-041-0/+14
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `url_for` methods in `actionpack` and `actionview` now make a copy of the provided options before generating polymorphic paths or URLs. The bug in the previous behavior is most noticeable in a case like: url_options = [:new, :post, param: 'value'] if current_page?(url_options) css_class = "active" end link_to "New Post", url_options, class: css_class
* | - Extracted `DELIMITED_REGEX` to `delimited_regex` method and made use of ↵Vipul A M2015-08-281-0/+2
| | | | | | | | | | | | | | | | | | | | user passed `options[:delimited_regex]` if available. Changed `DELIMITED_REGEX` to `DEFAULT)DELIMITED_REGEX` to signify what it means. - Added tests for number to delimited and number to currency in both actionview and activesupport. Changes Changes
* | no more require minitest mockGaurav Sharma2015-08-271-1/+0
| |
* | Removed Mocha from ActionView part 1Ronak Jangir2015-08-247-81/+101
| |
* | Merge pull request #21135 from DropsOfSerenity/masterSean Griffin2015-08-172-10/+48
|\ \ | | | | | | make disable_with default in submit_tag
| * | Make disable_with default in submit_tagJustin Schiff2015-08-112-10/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents double submission by making disable_with the default. Default disable_with option will only be applied if user has not specified her/his own disable_with option, whether that is in the `data-disable-with` string form or the `:data => { :disable_with => "Saving..." }` hash form. disable_with will default to the value attribute. A configuration option was added to opt out of this functionality if the user so desires. `config.action_view.automatically_disable_submit_tag = false`
* | | Fix test assign_parameter method signatureeileencodes2015-08-151-1/+1
|/ / | | | | | | | | | | | | | | Oops, I broke the build :( Fixes the method signature of `assign_parameters` which now takes 6 arguments instead of 4. We likely will end up chaning the method signature further so good to know this test is here.
* | Sometimes you need a specific break sequence while using word wrap and as ↵Mauricio Gomez Aguinaga2015-08-111-0/+4
| | | | | | | | | | | | | | | | | | | | today the only option we have is "\n" and is hardcoded. With this change you will be able to specify any break sequence ("\r\n" for example) as an option. adding proper documentation for break_sequence in ActionView::Helpers::TextHelper.word_wrap adding some more documentation for word_wrap custom break sequence and making sure we use new hash syntax
* | Merge pull request #20904 from kaspth/wildcard-template-dependenciesKasper Timm Hansen2015-07-271-1/+36
|\ \ | | | | | | Add wildcard template dependencies.
| * | Add wildcard template dependencies.Kasper Timm Hansen2015-07-261-1/+36
| | |
* | | Encode the email address as prescribed in RFC 6068 section 2.Clayton Smith2015-07-231-0/+7
|/ /
* | Remove unused persistent option.Kasper Timm Hansen2015-07-181-3/+3
| |
* | Make digest cache work in development.Kasper Timm Hansen2015-07-181-10/+0
| | | | | | | | | | | | Avoid computing the same fragment digest many times when looping over templates. The cache is cleared on every request so template changes are still picked up.
* | Merge pull request #20813 from noniq/locale-argument-for-pluralize-helperKasper Timm Hansen2015-07-091-0/+12
|\ \ | | | | | | Allow `pluralize` helper to take a locale.
| * | Allow `pluralize` helper to take a locale.Stefan Daschek2015-07-091-0/+12
| | | | | | | | | | | | This is already supported in `ActiveSupport::Inflector#pluralize` and `String#pluralize`, so we just forward the locale.
* | | Support explicit defintion of resouce name for collection caching.Dov Murik2015-07-071-3/+5
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too).
* | Merge pull request #20669 from akolomiychuk/image-pathYves Senn2015-06-291-0/+5
|\ \ | | | | | | | | | Passing nil to image_tag
| * | Add nil check in asset_pathAnton Kolomiychuk2015-06-291-0/+5
| | |
* | | Fix cache issue when different partials use the same collectionRoque Pinel2015-06-281-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
* | | Improve detection of partial templates eligible for collection caching.Dov Murik2015-06-221-0/+30
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | The regular expression which was used to detect partial templates that begin with a `<% cache ... do %>` call missed some cases. This commits attempts to improve the detection for some cases such as multi-line comments at the beginning of the template. The different templates are listed in two new unit test methods. Note that specially crafted Ruby code can still evade such `cache`-call detection: for example, a user might have its own method which itself calls the Rails `cache` helper. In such a case, the template's code doesn't start with a literal `cache` string and therefore will not be eligible for collection caching.
* | Merge pull request #20108 from akshay-vishnoi/button-tagArthur Nogueira Neves2015-06-151-0/+7
|\ \ | | | | | | Add missing spec and documentation for button_tag helper
| * | Add missing spec and documentation for button_tag helperAkshay Vishnoi2015-05-241-0/+7
| | |
* | | Merge pull request #20107 from ankit8898/av_refac_record_tag_helperArthur Nogueira Neves2015-06-151-2/+1
|\ \ \ | | | | | | | | Removed not needed includes, As record_tag_helper is moved to a gem we..
| * | | Removed not needed includes, As record_tag_helper is moved to a gem we are notAnkit Gupta2015-05-101-2/+1
| |/ / | | | | | | | | | testing is completely here now. RenderErbUtils and AM::Conversion are not used
* | | Merge pull request #20058 from farukaydin/cache-digests-dependency-rakeRafael Mendonça França2015-06-111-0/+20
|\ \ \ | | | | | | | | add error log that notify 'file not found' when using cache_digest dependency rake
| * | | add error log that notify 'file not found' when using ↵Faruk AYDIN2015-05-071-0/+20
| |/ / | | | | | | | | | cache_digests:dependency and cache_digests:nested_dependency tasks
* | | Raise an ArgumentError when `include_blank` is false for a required field inGrey Baker2015-06-081-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
* | | Remove `assigns` and `assert_template`.Guo Xiang Tan2015-05-301-58/+0
| |/ |/|
* | Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-141-0/+8
| | | | | | | | | | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* | Merge pull request #20149 from karanarora/Typo-fixRafael Mendonça França2015-05-131-11/+11
|\ \ | |/ |/| remove redundant parenthesis.
| * remove redundant parenthesis. karanarora2015-05-141-11/+11
| |
* | use the right assertions.Yves Senn2015-05-051-2/+2
| | | | | | | | | | | | | | Prompted by: https://github.com/rails/rails/commit/e38dd7bfa4360e241eadf0cf44abdf86ea33a393#commitcomment-11011496 /cc @kuldeepaggarwal
* | Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-041-14/+2
| | | | | | | | supported by I18n.
* | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-051-0/+13
|\ \ | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-041-0/+13
| | | | | | | | | | | | missing. Fixes #19967
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 21:58:47 +0000