aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/test/template/render_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Make collection caching explicit.Kasper Timm Hansen2016-02-201-26/+29
| | | | | | | | | | | | Having collection caching that wraps templates and automatically tries to infer if they are cachable proved to be too much of a hassle. We'd rather have it be something you explicitly turn on. This removes much of the code and docs to explain the previous automatic behavior. This change also removes scoped cache keys and passing cache_options.
* WIP: Errors in logs should show log tags as well.Vipul A M2016-02-121-3/+3
| | | | | | | - Changed formatted_code_for to return array of logs to be tagged for each line - Changed some render tests to match new behaviour of return Fixes #22979
* Merge branch '5-0-beta-sec'Aaron Patterson2016-01-251-0/+7
|\ | | | | | | | | | | | | | | | | | | | | * 5-0-beta-sec: bumping version fix version update task to deal with .beta1.1 Eliminate instance level writers for class accessors allow :file to be outside rails root, but anything else must be inside the rails view directory Don't short-circuit reject_if proc stop caching mime types globally use secure string comparisons for basic auth username / password
| * allow :file to be outside rails root, but anything else must be inside the ↵Aaron Patterson2016-01-221-0/+7
| | | | | | | | | | | | rails view directory CVE-2016-0752
* | Add Html template handler that wraps Raw output in an OutputBufferSantiago Pastorino2016-01-051-1/+6
|/ | | | | | | This fixes the case when you try to render an html you know safe and the file is named something.html. With this commit the content of the html won't be escaped anymore because AV won't use Raw handler and choose Html handler instead.
* Remove ActionView::Helpers::CacheHelper#fragment_cache_keySam Stephenson2015-12-141-0/+4
| | | | | | Introduced in e56c63542780fe2fb804636a875f95cae08ab3f4, `CacheHelper#fragment_cache_key` is a duplicate of `ActionController::Caching::Fragments#fragment_cache_key`. We now require the view to provide this method on its own (as with `view_cache_dependencies`); `ActionController::Caching::Fragments` exports its version as a `helper_method`.
* Respect value of `:object` if `:object` is false when renderingyui-knk2015-11-131-0/+2
| | | | | This commit fixes the bug convering `false` to `locals[as]` when `options[:object]` is `false` (close #22260).
* Deprecate exception#original_exception in favor of exception#causeYuki Nishijima2015-11-031-4/+4
|
* Added test cases where collection partial cached for different key and ↵Ronak Jangir2015-09-261-0/+10
| | | | rendered for different key
* Fix cache issue when different partials use the same collectionRoque Pinel2015-06-281-4/+13
| | | | | | | | | Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
* Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-141-0/+8
| | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-251-0/+38
|\ | | | | Merge multi_fetch_fragments.
| * Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-211-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-201-0/+14
| | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | Error message testing fixFranky W2015-02-201-1/+2
|/ | | | | | | | | The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
* Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-061-13/+8
| | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-031-1/+0
| | | | onwards.
* Merge pull request #17974 from killthekitten/fix-render-blockRafael Mendonça França2015-01-021-0/+5
|\ | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md
| * Make possible to use blocks with short version of render partialNikolay Shebanov2014-12-191-0/+5
| |
* | fix error message of option as with invalid charters in partial renderingAngelo capilleri2014-12-291-3/+17
|/ | | | | before this PR IDENTIFIER_ERROR_MESSAGE could lead to misunderstand the convention of partial name. Added OPTION_AS_ERROR_MESSAGE for unvalid charter in as option.
* Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-291-1/+1
|
* adding missing test coverageEugene Gilburg2014-07-181-0/+12
|
* Added PartialIteration class used when rendering collectionsJoel Junström2014-07-161-1/+1
| | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
* Assert the nature of the original exceptionMatthew Draper2014-07-121-0/+1
| | | | | | Just so it's clearer what's going on in the following assertion. /cc #11993 @robin850
* Merge pull request #11993 from razielgn/actionview-use-name-to-inspect-errorGuillermo Iguaran2014-07-111-1/+1
|\ | | | | Use NameError#name to assert raised error.
| * Use NameError#name to assert raised error.Federico Ravasio2013-11-241-1/+1
| | | | | | | | | | This makes the test compatible with other Ruby implementations, which may implement error messages differently.
* | Clean up I18n stored translations after test.Zuhao Wan2014-06-141-1/+2
| |
* | Add unregister_template_handler to prevent leaks.Zuhao Wan2014-06-121-4/+23
| |
* | Fix a fragile test on `action_view/render`Prem Sichanugrist2014-02-181-1/+1
| | | | | | | | | | | | This test were assuming that the list of render options will always be the same. Fixing that so this doesn't break when we add/remove render option in the future.
* | Added tests to render helper that expect `render partial: @foo` toIain Beeston2014-02-121-0/+10
| | | | | | | | | | | | | | | | | | | | automatically call @foo.to_partial_path Calling `render @foo` allows local variables but not options to be passed to the partial renderer. The correct way to render an object AND pass options to the partial renderer is to pass the object in the `:partial` parameter. However, there were previously no tests for this behaviour (in `render_helper_test.rb` at least).
* | `ActionView::MissingTemplate` for partials includes underscore.Yves Senn2013-12-021-2/+2
|/ | | | | | Missing partial folder/_partial instead of folder/partial. Closes #13002.
* Warnings removed for ruby trunkArun Agrawal2013-11-011-1/+1
| | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* Fix default rendered format problem when calling render method without ↵kennyj2013-07-151-0/+5
| | | | :content_type option. Closes #11393.
* Check if malformed fixture exists firstŁukasz Strzałkowski2013-06-201-0/+1
| | | | Now if somebody by mistake will remove malformed files test will raise error.
* Move template tests from actionpack to actionviewPiotr Sarnacki2013-06-201-0/+537
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 12:14:51 +0000