Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Reduce string objects by using \ instead of + or << for concatenating strings | Akira Matsuda | 2017-01-12 | 1 | -118/+118 |
| | | | | (I personally prefer writing one string in one line no matter how long it is, though) | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -35/+35 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -7/+7 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 1 | -1/+0 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -6/+6 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -40/+40 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -4/+4 |
| | |||||
* | modernizes hash syntax in actionview | Xavier Noria | 2016-08-06 | 1 | -69/+69 |
| | |||||
* | applies new string literal convention in actionview/test | Xavier Noria | 2016-08-06 | 1 | -61/+61 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | - Added select tag test for verifying passing html options to f.select helper | Vipul A M | 2016-06-28 | 1 | -1/+10 |
| | | | | - Renamed test to be more descriptive | ||||
* | Support for unified Integer class in Ruby 2.4+ | Jeremy Daer | 2016-05-18 | 1 | -1/+1 |
| | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer. | ||||
* | html_safe is not supposed to be public API for AV. This change removes usage ↵ | Vipul A M | 2016-01-20 | 1 | -1/+1 |
| | | | | | | of html_safe in favour of raw() in AV helpers. Also changed usage of html_safe to make use of raw() instead so that the intended behaviour is verified with raw() | ||||
* | Bring back `===` stubbing in `time_zone_select` test. | Kasper Timm Hansen | 2015-11-22 | 1 | -1/+7 |
| | | | | | | | Erroneously removed in 58910dc7. The stubbing was a regression test to ensure `time_zone_select` wasn't implemented with `grep`. Rename the test and add a comment to make the intent clearer. | ||||
* | Ditch `each_with_index` for `each`. | Kasper Timm Hansen | 2015-11-22 | 1 | -1/+1 |
| | | | | We never touch the index, so don't bother. | ||||
* | Don't cache fake time zones. | Kasper Timm Hansen | 2015-11-22 | 1 | -8/+9 |
| | | | | | | | | | When calling `test_time_zone_select_with_priority_zones_as_regexp` it would define `=~` on the fake zones, but it would never be cleaned up because of the zone cache. Nuke it so `test_time_zone_select_with_priority_zones_as_regexp_using_grep_finds_no_zones` accidentally find any zones because of `=~` being implemented. | ||||
* | Removed Mocha from Action View | Ronak Jangir | 2015-09-23 | 1 | -13/+31 |
| | |||||
* | Raise an ArgumentError when `include_blank` is false for a required field in | Grey Baker | 2015-06-08 | 1 | -0/+7 |
| | | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')` | ||||
* | Fixed #select form builder helper to support block with html output | Bogdan Gusiev | 2014-08-05 | 1 | -0/+13 |
| | |||||
* | Add test for selected and disabled custom attributes in options_for_select | Laura Paredes | 2014-03-31 | 1 | -1/+21 |
| | |||||
* | Fix some edge cases for AV `select` helper with `:selected` option | Bogdan Gusiev | 2013-09-23 | 1 | -0/+16 |
| | |||||
* | Ability to pass block to AV#select helper | Bogdan Gusiev | 2013-09-23 | 1 | -0/+15 |
| | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name | ||||
* | There's no need to do this | Santiago Pastorino | 2013-09-17 | 1 | -4/+1 |
| | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code. | ||||
* | add support for html attributes to grouped_options_for_select | Vasiliy Ermolovich | 2013-07-20 | 1 | -0/+10 |
| | |||||
* | Remove passing the prompt to grouped_options_for_select as an argument, ↵ | kennyj | 2013-06-28 | 1 | -17/+0 |
| | | | | because it was deprecated. | ||||
* | Move template tests from actionpack to actionview | Piotr Sarnacki | 2013-06-20 | 1 | -0/+1304 |