Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #17973 from maurogeorge/file_field_hidden_field | Rafael Mendonça França | 2015-01-02 | 1 | -5/+20 |
|\ | | | | | | | Generate a hidden_tag when using a file_field | ||||
| * | Add a hidden_field on the file_field | Mauro George | 2015-01-02 | 1 | -5/+20 |
|/ | | | | | This will avoid a error be raised when the only input on the form is the `file_field`. | ||||
* | Fix options overwritten by super | Jose Añasco | 2014-12-09 | 1 | -0/+5 |
| | |||||
* | Add `:enforce_utf8` option to form_for | claudiob | 2014-11-20 | 1 | -3/+33 |
| | | | | | | | | | Since 06388b0 `form_tag` accepts the option `enforce_utf8` which, when set to false, prevents the hidden "UTF8 enforcer" field from appearing in the output. This commit implements the same behavior for `form_for`. Stems from https://github.com/rails/rails/pull/17685#issuecomment-63871395 | ||||
* | Improve test of private properties of objects in form tags | Rafael Mendonça França | 2014-10-31 | 1 | -28/+9 |
| | |||||
* | Use public_send for form tags | agius | 2014-10-31 | 1 | -0/+27 |
| | |||||
* | Honor public/private in ActionView::Helpers::Tags::Base#value | Tobias Pfeiffer | 2014-10-31 | 1 | -0/+6 |
| | | | | | * use public_send instead of send to avoid calling private methods in form helpers | ||||
* | remove un-needed sort | schneems | 2014-10-07 | 1 | -8/+7 |
| | | | | | | HTML doesn't care what order the elements are rendered in, so why should we? Updates tests to use proper `assert_dom_equal` instead of `assert_equal` /cc @jeremy | ||||
* | Merge pull request #16488 from agrobbin/form-label-builder | Jeremy Kemper | 2014-08-25 | 1 | -0/+9 |
|\ | | | | | Provide a builder for form labels to customize wrapping around I18n content | ||||
| * | provide a builder for form labels to customize wrapping around I18n content | Alex Robbin | 2014-08-20 | 1 | -0/+9 |
| | | |||||
* | | just use the placeholder tag value if it is passed as a String | Alex Robbin | 2014-08-22 | 1 | -4/+19 |
| | | |||||
* | | add I18n support for `:placeholder` HTML option is passed to form fields | Alex Robbin | 2014-08-22 | 1 | -0/+168 |
| | | |||||
* | | Revert "Add I18n support for `:placeholder` HTML option is passed to form ↵ | Jeremy Kemper | 2014-08-21 | 1 | -168/+0 |
|/ | | | | fields" | ||||
* | add I18n support for `:placeholder` HTML option is passed to form fields | Alex Robbin | 2014-08-12 | 1 | -0/+168 |
| | |||||
* | adding missing test for text area value before type cast | Eugene Gilburg | 2014-07-19 | 1 | -0/+7 |
| | |||||
* | Add String support for min/max attributes on DatetimeField | Todd Bealmear | 2014-06-30 | 1 | -0/+64 |
| | |||||
* | Merge pull request #15715 from ↵ | Yves Senn | 2014-06-14 | 1 | -2/+4 |
|\ | | | | | | | | | | | zuhao/refactor_actionview_cleanup_I18n_translations Clean up I18n stored translations after test. | ||||
| * | Clean up I18n stored translations after test. | Zuhao Wan | 2014-06-14 | 1 | -2/+5 |
|/ | |||||
* | Include label value in i18n attribute lookup | Joshua Cody | 2014-05-06 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post". | ||||
* | Add test for using ActionView::Helpers::FormHelper.label with block and html | Zachary Scott | 2014-04-22 | 1 | -0/+7 |
| | |||||
* | Merge pull request #14738 from tilsammans/pull/11407 | Rafael Mendonça França | 2014-04-17 | 1 | -3/+4 |
|\ | | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md | ||||
| * | Remove wrapping div with inline styles for hidden form fields. | Joost Baaij | 2014-04-14 | 1 | -3/+4 |
| | | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy. | ||||
* | | Use the index on hidden field | Rafael Mendonça França | 2014-04-14 | 1 | -1/+1 |
|/ | |||||
* | refactor, with_locale is not needed because I18n is mocked. | Yves Senn | 2014-02-24 | 1 | -7/+5 |
| | | | | | This is a follow up to #14170. While backporting I recognized that this call is not needed at all. | ||||
* | Fix ActionView label translation for more than 10 nested elements | Vladimir Krylov | 2014-02-24 | 1 | -0/+14 |
| | |||||
* | refactor, extract `with_locale` helper. | Yves Senn | 2014-02-24 | 1 | -87/+79 |
| | |||||
* | Switched to use `display:none` in extra_tags_for_form method. | Gaelian Ditchburn | 2014-01-05 | 1 | -1/+1 |
| | | | | | | | | | | | | | The use of `display:inline` with the content_tag call in the extra_tags_for_form method potentially causes display issues with some browsers, namely Internet Explorer. IE's behaviour of not collapsing the line height on divs with ostensibly no content means that the automatically added div containing the hidden authenticity_token, utf8 and _method form input tags may interfere with other visible form elements in certain circumstances. The use of `display:none` rather than `display:inline` fixes this problem. Fixes #6403 | ||||
* | Label only accepts `:index` and `:namespace` attributes from the input | Andriel Nuernberg | 2013-12-05 | 1 | -0/+36 |
| | |||||
* | handle `:namespace` form option in collection labels | Vasiliy Ermolovich | 2013-09-22 | 1 | -0/+36 |
| | |||||
* | form_for - fix :namespace and :as options clash | Adam Niedzielski | 2013-09-09 | 1 | -0/+12 |
| | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it | ||||
* | text_area should handle nil value option like text_field | Joel Cogen | 2013-07-24 | 1 | -0/+7 |
| | |||||
* | Remove `FormBuilder` deprecation warning about block argument and associated ↵ | Vipul A M | 2013-07-02 | 1 | -12/+0 |
| | | | | tests | ||||
* | fetch value(s) from stringified options | Jon Rowe | 2013-06-29 | 1 | -0/+17 |
| | |||||
* | Move template tests from actionpack to actionview | Piotr Sarnacki | 2013-06-20 | 1 | -0/+2959 |