| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Remove unused AV/test/fixtures/scope
|
| |
| |
| |
| |
| | |
The file `modgreet.erb` was added 8 years ago in 21187c0
and is not used anymore by any test.
|
|/
|
|
|
|
|
|
|
|
| |
The `test/fixtures/happy_path/render_action/hello_world.erb` file was
introduced in 8ab37c7 for the `TestRenderAction` test.
That test was subsequently removed in 34f058e, so the fixture is not
used anymore.
If Travis CI is happy, then you can be sure the fixture can be removed.
|
|\
| |
| | |
Remove unused AV/test/fixtures/blog_public
|
| |
| |
| |
| |
| |
| |
| |
| | |
The fixtures were added to support StaticTests in 401cd97 but
those tests were then removed in d5ad92ce.
If Travis CI is happy with this PR, then you can be sure that
those fixtures are not needed anymore.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Both ActionPack and ActionView include `test/fixtures/functional_caching/fragment_cached_without_digest.html.erb`.
The [ActionPack file](https://github.com/rails/rails/blob/master/actionpack/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is used by the tests.
The [ActionView file](https://github.com/rails/rails/blob/master/actionview/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is not: it was introduced in eb23754e when some tests and
fixtures were moved from AP to AV, but no tests in AV uses the fixture.
Long story short: if Travis CI is happy with removing the fixture, you can
be sure that is not needed anymore!
|
|
|
|
| |
Now ActionView accepts <%= foo(){ %> and <%= foo()do %> :golf:
|
|
|
|
|
| |
This is much less common than string literal appends, so add a special
case method for it. Maybe fixes bug reported by @jeremy on 97ef636191933f1d4abc92fc10871e6d1195285c
|
|
|
|
|
|
|
|
|
|
|
|
| |
The iteration object is available as the local variable
"template_name_iteration" when rendering partials with collections.
It gives access to the +size+ of the collection beeing iterated over,
the current +index+ and two convinicence methods +first?+ and +last?+
"template_name_counter" variable is kept but is deprecated.
[Joel Junström + Lucas Uyezu]
|
|
|
|
|
|
|
|
|
|
| |
Related to: #14242 #14243 14293
Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.
I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
|
|
|
|
|
|
|
|
|
|
|
| |
Take variants into account when calculating template digests in
ActionView::Digest.
Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.
Fixes #14242
|
|
|
|
|
|
|
|
|
|
| |
automatically call @foo.to_partial_path
Calling `render @foo` allows local variables but not options to be
passed to the partial renderer. The correct way to render an object AND
pass options to the partial renderer is to pass the object in the
`:partial` parameter. However, there were previously no tests for this
behaviour (in `render_helper_test.rb` at least).
|
| |
|
|
|
|
|
| |
Several fixtures for helpers are removed. They were introduced in
ActionView by @strzalek but never referenced in any test.
|
|
|
|
|
|
| |
The fixture for module AbcHelper defines three functions bare_a,
bare_b and bare_c, but only bare_a is used in the code that tests
helper functions.
|
|
|
|
| |
The ones that were actually testing AV functionality and should belong in there
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.
Fixes #11340
|
| |
|
| |
|
| |
|
| |
|
|
|