Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Define path with __dir__ | bogdanvlviv | 2017-05-23 | 1 | -7/+7 |
| | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f | ||||
* | Don't pollute Object with rubinius_skip and jruby_skip | Akira Matsuda | 2017-01-17 | 1 | -9/+9 |
| | | | | we call them only in the tests | ||||
* | Use Encoding::UTF_8 constant for default_{internal,external} in the tests | Akira Matsuda | 2017-01-11 | 1 | -2/+2 |
| | |||||
* | Privatize unneededly protected methods in Action View tests | Akira Matsuda | 2016-12-23 | 1 | -1/+1 |
| | |||||
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 1 | -1/+1 |
| | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -2/+2 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -10/+10 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | modernizes hash syntax in actionview | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in actionview/test | Xavier Noria | 2016-08-06 | 1 | -23/+23 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Silence deprecation message for dynamic controller and actions on ↵ | Mehmet Emin İNAÇ | 2016-03-07 | 1 | -6/+8 |
| | | | | action_view test cases | ||||
* | Remove load_paths file | Arthur Neves | 2016-02-27 | 1 | -2/+0 |
| | |||||
* | Removed Mocha from Action View | Ronak Jangir | 2015-09-23 | 1 | -1/+0 |
| | |||||
* | mostly remove the ParamsParser middleware | Aaron Patterson | 2015-09-18 | 1 | -1/+0 |
| | | | | | This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant | ||||
* | Removed Mocha from ActionView part 1 | Ronak Jangir | 2015-08-24 | 1 | -0/+4 |
| | |||||
* | Fix deprecation warning in tests | eileencodes | 2015-08-08 | 1 | -7/+7 |
| | | | | | | | | | | | | | Using the string version of the class reference is now deprecated when referencing middleware. This should be written as a class not as a string. Deprecation warning that this change fixes: ``` DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change them to actual class references. For example: "ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions ``` | ||||
* | Revert "Merge pull request #19404 from dmathieu/remove_rack_env" | Jeremy Kemper | 2015-03-20 | 1 | -1/+1 |
| | | | | | | | Preserving RACK_ENV behavior. This reverts commit 7bdc7635b885e473f6a577264fd8efad1c02174f, reversing changes made to 45786be516e13d55a1fca9a4abaddd5781209103. | ||||
* | don't fallback to RACK_ENV when RAILS_ENV is not present | Damien Mathieu | 2015-03-19 | 1 | -1/+1 |
| | |||||
* | Cleaning unused methods from abstract_unit | Thiago Pradi | 2015-03-14 | 1 | -57/+0 |
| | |||||
* | Revert "Leave all our tests as order_dependent! for now" | Matthew Draper | 2015-03-06 | 1 | -5/+0 |
| | | | | | | | | | | | | This reverts commit 2f52f969885b2834198de0045748436a4651a94e. Conflicts: actionmailer/test/abstract_unit.rb actionview/test/abstract_unit.rb activemodel/test/cases/helper.rb activerecord/test/cases/helper.rb activesupport/test/abstract_unit.rb railties/test/abstract_unit.rb | ||||
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 1 | -1/+1 |
| | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -1/+1 |
| | |||||
* | Don’t require already required modules | claudiofullscreen | 2014-09-26 | 1 | -2/+0 |
| | | | | | | | | | abstract_unit.rb requires `action_controller` which [already includes the following lines of code](https://github.com/rails/rails/blob/64fcdce1d3a6a8768ab17f3be144270456814f82/actionpack/lib/action_controller.rb#L2L3): ```ruby require 'abstract_controller' require 'action_dispatch' ``` | ||||
* | Default to sorting user's test cases for now | Godfrey Chan | 2014-09-08 | 1 | -1/+1 |
| | | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769 | ||||
* | Leave all our tests as order_dependent! for now | Matthew Draper | 2014-09-02 | 1 | -0/+5 |
| | | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa. | ||||
* | AM, AP, AV, and AMo tests are already order_independent! | Akira Matsuda | 2014-08-13 | 1 | -5/+0 |
| | |||||
* | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 1 | -1/+1 |
| | |||||
* | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 1 | -0/+5 |
| | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | ||||
* | Stop requiring mocha automatically | Rafael Mendonça França | 2014-07-19 | 1 | -0/+2 |
| | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal | ||||
* | Remove unnecessary include for integration tests. | Guo Xiang Tan | 2014-05-11 | 1 | -1/+0 |
| | |||||
* | standardize on jruby_skip & rbx_skip | Gaurish Sharma | 2014-01-13 | 1 | -0/+8 |
| | | | | | | This Adds helpers(jruby_skip & rbx_skip). In Future, Plan is to use these helpers instead of calls directly to RUBY_ENGINE/RbConfig/JRUBY_VERSION | ||||
* | Disable available locales checks to avoid warnings running the tests | Carlos Antonio da Silva | 2013-12-17 | 1 | -0/+3 |
| | |||||
* | Retain ActionPack dependency on ActionView | Łukasz Strzałkowski | 2013-12-05 | 1 | -2/+0 |
| | |||||
* | Do not load AV inside AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 |
| | | | | Move that part to AV railtie | ||||
* | Don not require AC::Caching | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+0 |
| | |||||
* | Remove ApplicationController & RoutingTestHelpers | Łukasz Strzałkowski | 2013-08-25 | 1 | -9/+0 |
| | |||||
* | Remove unused ActionDispatch::RoutingVerbs | Łukasz Strzałkowski | 2013-08-25 | 1 | -15/+1 |
| | |||||
* | Remove unused in AV fixture-controllers | Łukasz Strzałkowski | 2013-08-25 | 1 | -29/+0 |
| | |||||
* | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+2 |
| | |||||
* | Move template tests from actionpack to actionview | Piotr Sarnacki | 2013-06-20 | 1 | -0/+382 |