Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Bust the template digest cache key when details are changed | Daniel Schierbeck | 2013-09-19 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value. | |||||
* | | | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-as | Rafael Mendonça França | 2013-09-12 | 1 | -1/+2 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md | |||||
| * | | | form_for - fix :namespace and :as options clash | Adam Niedzielski | 2013-09-09 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it | |||||
* | | | | Merge pull request #11603 from ↵ | Rafael Mendonça França | 2013-09-12 | 1 | -2/+3 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper | |||||
| * | | | | Cleanup of excerpt helper | Paul Nikitochkin | 2013-09-06 | 1 | -2/+3 | |
| |/ / / | | | | | | | | | | | | | | | | | * replaced String concatenation by joining * separator has default value to '', even it is nil | |||||
* | | | | Remove remaining coupling with AV in MimeResponds | José Valim | 2013-09-09 | 1 | -0/+7 | |
| | | | | ||||||
* | | | | Remove BasicRendering and remove template functionality from AbsC::Rendering | José Valim | 2013-09-09 | 1 | -7/+5 | |
|/ / / | ||||||
* | | | Fix a few typos. [ci skip] | namusyaka | 2013-09-04 | 1 | -2/+2 | |
| | | | ||||||
* | | | Move skeleton methods from AV to AbsC | Łukasz Strzałkowski | 2013-09-03 | 1 | -22/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The methods: * #render_to_body * #render_to_string * #_normalize_render Haven't had anything specyfic to ActionView. This was common code which should belong to AbstractController | |||||
* | | | Return to using protected_instance_variables in AV | Łukasz Strzałkowski | 2013-09-02 | 1 | -4/+0 | |
| | | | ||||||
* | | | fix the typo [ci skip] | Rajarshi Das | 2013-09-02 | 1 | -1/+1 | |
| | | | | | | | | | fix the typo newstopics => new topics in action view cache helper | |||||
* | | | Merge pull request #11768 from cloudspace/cache_template_loading | Rafael Mendonça França | 2013-08-27 | 1 | -3/+7 | |
|\ \ \ | | | | | | | | | Only cache template digests if !config.cache_template_loading | |||||
| * | | | Only cache template digests if config.cache_template_loading | Josh Lauer | 2013-08-06 | 1 | -3/+7 | |
| | |/ | |/| | | | | | | | | | | | | | since ActionView::Resolver.caching is set to the same value as config.cache_template_loading only cache template digests if config.cache_template_loading is not falsy fixes issues #10752 and #10791 | |||||
* | | | Load HTML in ActionView not ActionPack | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 | |
| | | | | | | | | | | | | HTML Scanner is part of ActionView and it should be loaded along with it | |||||
* | | | Fist stab on basic rendering | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+0 | |
| | | | ||||||
* | | | Add #rendered_format method to controllers | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+4 | |
| | | | ||||||
* | | | Add missing requires inside AV | Łukasz Strzałkowski | 2013-08-25 | 4 | -1/+8 | |
| | | | ||||||
* | | | Do not load AV inside AP | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+1 | |
| | | | | | | | | | | | | Move that part to AV railtie | |||||
* | | | Add missing require | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+2 | |
| | | | ||||||
* | | | Revert "Move setting content_type to AV" | Łukasz Strzałkowski | 2013-08-25 | 2 | -3/+1 | |
| | | | | | | | | | | | | This reverts commit f4d602aff6cec80304b131ecfcc2676d0304f0cc. | |||||
* | | | Move setting content_type to AV | Łukasz Strzałkowski | 2013-08-25 | 2 | -1/+3 | |
| | | | ||||||
* | | | Use concat to avoid allocating additional array | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 | |
| | | | ||||||
* | | | Pass args to render's super method | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+2 | |
| | | | ||||||
* | | | Improve AV::Rendering docs | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+8 | |
| | | | ||||||
* | | | Include AV::Layouts before setting view_paths | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+2 | |
| | | | ||||||
* | | | Load AV::Layout to AM::Base in railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -0/+6 | |
| | | | ||||||
* | | | Remove view_assigns from AV | Łukasz Strzałkowski | 2013-08-25 | 1 | -7/+0 | |
| | | | | | | | | | | | | It wasn't adding anything, just invoking super | |||||
* | | | Load AV::Layouts dynamicly via railties | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 | |
| | | | ||||||
* | | | Code formatting & typo fixes | Łukasz Strzałkowski | 2013-08-25 | 1 | -35/+35 | |
| | | | ||||||
* | | | Remove abstract_controller load hooks | Łukasz Strzałkowski | 2013-08-25 | 1 | -4/+0 | |
| | | | ||||||
* | | | Move protected_instance_variables & view_assigns to AbstractController | Łukasz Strzałkowski | 2013-08-25 | 1 | -15/+4 | |
| | | | ||||||
* | | | Remove 'api plugin' from docs | Łukasz Strzałkowski | 2013-08-25 | 1 | -3/+0 | |
| | | | | | | | | | | | | AbstractController::Rendering is module which defines thie api | |||||
* | | | Create AbstractController::Rendering interface | Łukasz Strzałkowski | 2013-08-25 | 1 | -17/+4 | |
| | | | | | | | | | | | | This interface should be use when implementing renderers. | |||||
* | | | Fix eager_autoload for layouts | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | Name was singular, should be plural | |||||
* | | | Revert "Require only path_set && lookup_context instead of whole base" | Łukasz Strzałkowski | 2013-08-25 | 1 | -2/+1 | |
| | | | | | | | | | | | | This reverts commit 77bb03df2ca3687b290e9fe77d21007642f0329c. | |||||
* | | | Hook up AV::Rendering on AV intialization | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+5 | |
| | | | ||||||
* | | | Move layouts to AV | Łukasz Strzałkowski | 2013-08-25 | 3 | -0/+431 | |
| | | | ||||||
* | | | Move rendering from AP to AV | Łukasz Strzałkowski | 2013-08-25 | 2 | -0/+187 | |
| | | | ||||||
* | | | Require only path_set && lookup_context instead of whole base | Łukasz Strzałkowski | 2013-08-25 | 1 | -1/+2 | |
| | | | ||||||
* | | | Move view_paths from AP to AV | Łukasz Strzałkowski | 2013-08-25 | 2 | -0/+97 | |
| |/ |/| | ||||||
* | | RDoc tweaks | Xavier Noria | 2013-08-07 | 1 | -5/+10 | |
|/ | ||||||
* | Removed an unnecessary loop - it kills performance on large texts. | Jan Szumiec | 2013-08-03 | 1 | -4/+6 | |
| | ||||||
* | Add "extname" option to javascript_include_tag | Nathan Stitt | 2013-08-03 | 1 | -3/+6 | |
| | | | | | | | | | | | | ActionView::Helpers.asset_path is where the logic for javascript_include_tag resides. It takes an extname option for specifying the extension or false to not append it. This exposes that option to javascript_include_tag. Without the option files that didn't end with ".js" would get the extension appended to them. This broke JST templates and other file types that should be interpreted as JavaScript but who's file extension isn't ".js" | |||||
* | Using URI.parser.unescape | Arun Agrawal | 2013-08-03 | 1 | -2/+2 | |
| | | | | | | Fixes warning warning: URI.unescape is obsolete | |||||
* | Make current_page? compare binary strings | Rafael Mendonça França | 2013-08-01 | 1 | -3/+4 | |
| | ||||||
* | Fix `current_page?` when the URL contains escaped characters | Rafael Mendonça França | 2013-08-01 | 1 | -2/+2 | |
| | | | | | | | In some cases webservers like nginx send the escaped characters lowercased to the Rails application. The current_page? helper was comparing the escaped strings that are different since Ruby escapes the URL using uppercased characters. | |||||
* | Change from `map` => `map!` and `collect!` to save creation of extra array. | Vipul A M | 2013-07-31 | 1 | -2/+2 | |
| | ||||||
* | AV::Digestor thread safety fixes. | thedarkone | 2013-07-30 | 1 | -9/+29 | |
| | | | | | This fixes potential thread safety issues introduced in 09f6fe1. The problem with the original code was that the "recursion-stopping" `nil` values could be seen by other threads. | |||||
* | text_area should handle nil value option like text_field | Joel Cogen | 2013-07-24 | 2 | -3/+3 | |
| | ||||||
* | Leave the knowledge of boolean tag values to content tag | Carlos Antonio da Silva | 2013-07-22 | 1 | -3/+3 | |
| | | | | | | content tag already knows which tags are boolean and the values that should generate them when a truthy value is passed, so leave this logic for it instead of duplicating when generating options tags. |