aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Support explicit defintion of resouce name for collection caching.Dov Murik2015-07-073-6/+37
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | If a template includes `# Template Collection: ...` anywhere in its source, that name will be used as the cache name for the partial that is rendered for the collection. This allows users to enable collection caching even if the template doesn't start with `<% cache ... do %>`. Moreover, the `# Template Collection: ...` notation is recognized in all template types (and template types other than ERB can define a resource_cache_call_pattern method to allow the `cache ... do` pattern to be recognized too).
* | changes names in guides to better reflect diversity [ci-skip]Thomas Osborn2015-07-021-6/+6
| |
* | Merge pull request #20669 from akolomiychuk/image-pathYves Senn2015-06-291-0/+2
|\ \ | | | | | | | | | Passing nil to image_tag
| * | Add nil check in asset_pathAnton Kolomiychuk2015-06-291-0/+2
| | |
* | | Fix cache issue when different partials use the same collectionRoque Pinel2015-06-282-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the `virtual_path` option to `cache_fragment_name` so it can be provided when needed. That allows `cache_collection_render` to get the appropriate cache key with the digest generated based on the template and prevent collision with other templates that cache the same collection.
* | | Merge pull request #20417 from dubek/fix-template-cache-call-patternKasper Timm Hansen2015-06-261-1/+1
|\ \ \ | | | | | | | | Improve detection of partial templates eligible for collection caching.
| * | | Improve detection of partial templates eligible for collection caching.Dov Murik2015-06-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The regular expression which was used to detect partial templates that begin with a `<% cache ... do %>` call missed some cases. This commits attempts to improve the detection for some cases such as multi-line comments at the beginning of the template. The different templates are listed in two new unit test methods. Note that specially crafted Ruby code can still evade such `cache`-call detection: for example, a user might have its own method which itself calls the Rails `cache` helper. In such a case, the template's code doesn't start with a literal `cache` string and therefore will not be eligible for collection caching.
* | | | A few documentation fixes [ci skip]Robin Dupret2015-06-231-6/+6
|/ / /
* | | Merge pull request #20654 from repinel/remove-duplicate-privateRichard Schneeman2015-06-211-2/+0
|\ \ \ | | | | | | | | Remove duplicate private statement
| * | | Remove duplicate private statementRoque Pinel2015-06-211-2/+0
| | | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-06-215-6/+6
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Conflicts: guides/source/configuring.md
| * | | [ci skip] Fix to Fixed-width Fontyui-knk2015-06-143-4/+4
| | | | | | | | | | | | | | | | LookupContext is class name
| * | | [ci skip] Add '.'yui-knk2015-06-141-1/+1
| | | |
| * | | [ci skip] Fix minutes to seconds in `select_second`yui-knk2015-06-091-1/+1
| | | | | | | | | | | | | | | | This is same type commit of https://github.com/rails/rails/pull/20463
* | | | applies project style guidelinesXavier Noria2015-06-201-7/+7
| | | | | | | | | | | | | | | | Just saw these in passing while reading this file.
* | | | removes unnecessary backslashes in regexpsXavier Noria2015-06-201-3/+3
| |/ / |/| | | | | | | | Colons are not metacharacters.
* | | Nitpick :nail_care: [ci skip]Zachary Scott2015-06-181-1/+2
| | |
* | | Merge pull request #20549 from maurogeorge/distance_of_time_in_words-rdocZachary Scott2015-06-181-0/+20
|\ \ \ | | | | | | | | Add RDoc about scope option on distance_of_time_in_words
| * | | Add RDoc about scope option on distance_of_time_in_wordsMauro George2015-06-181-0/+20
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #20108 from akshay-vishnoi/button-tagArthur Nogueira Neves2015-06-151-2/+15
|\ \ \ \ | | | | | | | | | | Add missing spec and documentation for button_tag helper
| * | | | Add missing spec and documentation for button_tag helperAkshay Vishnoi2015-05-241-2/+15
| | | | |
* | | | | Add gotcha to RDoc of collection_check_boxesMauro George2015-06-131-0/+21
| |/ / / |/| | | | | | | | | | | [ci skip]
* | | | Merge pull request #20058 from farukaydin/cache-digests-dependency-rakeRafael Mendonça França2015-06-111-1/+2
|\ \ \ \ | | | | | | | | | | add error log that notify 'file not found' when using cache_digest dependency rake
| * | | | add error log that notify 'file not found' when using ↵Faruk AYDIN2015-05-071-1/+2
| | | | | | | | | | | | | | | | | | | | cache_digests:dependency and cache_digests:nested_dependency tasks
* | | | | Exclude cache_digests:dependencies rake task in api appJorge Bejar2015-06-111-2/+4
| | | | |
* | | | | Tiny documentation edits [ci skip]Robin Dupret2015-06-091-7/+7
| | | | |
* | | | | Raise an ArgumentError when `include_blank` is false for a required field inGrey Baker2015-06-081-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Tags::Base#select_content_tag`. Previously, passing a falsey value to `include_blank` would be ignored if the field was required, and a blank line would still be inserted. The following will now raise instead of quietly failing: `select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
* | | | | [ci skip] Fix hours to minutes in `select_minute`yui-knk2015-06-071-1/+1
| |_|/ / |/| | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-06-051-1/+1
|\ \ \ \
| * | | | [ci skip] Fix typo you/yourclaudiob2015-05-231-1/+1
| | | | |
* | | | | Revert "Merge pull request #19685 from vngrs/actionview_parent_layout_bug"Rafael Mendonça França2015-06-021-17/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11. Reason: The old behavior is how it was working in previous version of Rails since 4.0.x so it is not safe to backport to a stable branch. See https://github.com/rails/rails/issues/19626#issuecomment-89862258 and https://github.com/rails/rails/pull/15050#issuecomment-45333449
* | | | | Fix docs markup for option_groups_from_collection_for_select [ci skip]Carlos Antonio da Silva2015-05-191-1/+1
| | | | |
* | | | | spelling fix [ci skip]karanarora2015-05-191-1/+1
| | | | |
* | | | | Do not put partial name to local_assigns when rendering without an objectHenrik Nygren2015-05-141-1/+1
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | When one rendered a partial template without specifying an object or a collection (e.g. <%= render partial: 'partial_name' %>), Rails would make an object called :partial_name available in local_assigns. I don't think this was the intended behavior, since no local variable called 'partial_name' gets defined in the view.
* | | | Better formatted documents [ci skip]Gourav Tiwari2015-05-081-8/+12
|/ / /
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-05-081-0/+1
|\ \ \
| * | | [ci skip] Add an example to ActionView::Helpers::FormBuilder#labelyui-knk2015-05-081-0/+1
| | | |
* | | | Updated dynamic value of id in comments [ci skip]Gourav Tiwari2015-05-071-1/+1
| | | | | | | | | | | | | | | | In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
* | | | Example updated [ci skip]Ankit Gupta2015-05-071-1/+1
| |/ / |/| | | | | | | | Should be ApplicationController not ApplicationController::Base
* | | Remove :rescue_format option for translate helper since it's no longer ↵Bernard Potocki2015-05-041-2/+2
| | | | | | | | | | | | supported by I18n.
* | | Merge pull request #19998 from imanel/fix-missing-translationMatthew Draper2015-05-051-4/+4
|\ \ \ | | | | | | | | Handle raise flag in translate when both main and default translation is missing.
| * | | Handle raise flag in translate when both main and default translation is ↵Bernard Potocki2015-05-041-4/+4
| | | | | | | | | | | | | | | | missing. Fixes #19967
* | | | Merge pull request #18783 from mikestone14/actionview-image-tag-overrideRafael Mendonça França2015-05-031-0/+7
|\ \ \ \ | | | | | | | | | | Actionview image tag size option override
| * | | | image_tag raises an error if size is passed with height and/or widthMike Stone2015-04-241-0/+7
| | | | |
* | | | | Use ruby 1.9 lambda syntax in documentations [ci skip]Mehmet Emin İNAÇ2015-05-031-1/+1
| |/ / / |/| | |
* | | | [ci skip] Fix example codes of form_for methodyui-knk2015-05-021-26/+36
| | | |
* | | | Revert "Merge pull request #19844 from ↵Yves Senn2015-05-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | stevenspiel/link_to_if_block_helper_addition" This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3. :sweat: The block is not supposed to be passed to `link_to`. It's used for a customized behavior of the `condtion = false` case. The docs illustrate that like so: ``` <%= link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user }) end %> ```
* | | | Merge pull request #19844 from stevenspiel/link_to_if_block_helper_additionYves Senn2015-05-011-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | Update url_helper.rb
| * | | | Update url_helper.rbSteven Spiel2015-04-211-1/+1
| |/ / / | | | | | | | | add block to link_to_if when condition is true
* | | | Make ActionMailer #cache helper a no-op, not an exceptionJavan Makhmali2015-04-281-1/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 01:18:10 +0000