aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
* [skip ci] Update information about #link_to attributesAnton Davydov2015-04-041-4/+3
|
* Freeze static arguments for gsubbrainopia2015-04-021-1/+1
|
* Prefer string patterns for gsubbrainopia2015-04-021-1/+1
| | | | | | | | | | | | | | | | | https://github.com/ruby/ruby/pull/579 - there is a new optimization since ruby 2.2 Previously regexp patterns were faster (since a string was converted to regexp underneath anyway). But now string patterns are faster and better reflect the purpose. Benchmark.ips do |bm| bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') } bm.report('string') { 'this is ::a random string'.gsub('::', '/') } bm.compare! end # string: 753724.4 i/s # regexp: 501443.1 i/s - 1.50x slower
* [skip ci] Add information about #link_to target optionAnton Davydov2015-04-011-0/+6
|
* Merge pull request #19535 from JuanitoFatas/doc/av-commentYves Senn2015-03-271-1/+1
|\ | | | | [ci skip] Unify the code comment in ActionView::Renderer#render_template...
| * [ci skip] Unify the code comment in ActionView::Renderer#render_template.Juanito Fatas2015-03-271-1/+1
| |
* | Add missing :html option in determine_template error message.Juanito Fatas2015-03-271-1/+1
|/
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-03-263-10/+11
|\ | | | | | | | | Conflicts: guides/source/4_0_release_notes.md
| * [ci skip] Fix `&>` with `%>`yui-knk2015-03-251-9/+9
| |
| * [ci skip] Add a line between code example and docsyui-knk2015-03-211-0/+1
| |
| * [ci skip] Add space after erb block.yui-knk2015-03-121-1/+1
| |
* | Simplify setting button form optionsCarlos Antonio da Silva2015-03-221-2/+3
| | | | | | | | No need to merge hashes when simply setting options does the job.
* | Rework form helper example to use Person.newCarlos Antonio da Silva2015-03-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | The previous change 92a3c8dcdf174dab5e8759031b6bbe6cd891fe3c improved this example, but calling .create + #valid? ends up running validations twice, and we don't want to showcase that. Lets use the normal use case of building a new object and calling #save on it, which is what a basic scaffold with Active Record does. [ci skip]
* | [ci skip] Check a result of `valid?` instead of `create`yui-knk2015-03-211-1/+2
| |
* | Merge pull request #19421 from jcoyne/translate_defaults_with_nilRafael Mendonça França2015-03-201-1/+1
| | | | | | | | Strip nils out of default translations. Fixes #19419
* | Remove additional handling of boolean attributes on button to helperCarlos Antonio da Silva2015-03-181-30/+0
| | | | | | | | | | | | | | | | This logic was just doing duplicated work, since the button_to helper relies on tag/content_tag to generate the button html, which already handles all boolean attributes it knows about. The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
* | [ci skip] correct output of selectKuldeep Aggarwal2015-03-131-15/+15
| |
* | [CI SKIP] Correct output of options_for_selectAkshay Vishnoi2015-03-131-5/+5
| |
* | Let strip_tags leave HTML escaping to Rails.Kasper Timm Hansen2015-03-101-1/+1
| | | | | | | | Prevents double escaping errors, such as "&" becoming "&".
* | don't need to rescue Exception in this caseAaron Patterson2015-03-051-1/+1
| |
* | [ci skip] Delete excess white in documentationAnton Davydov2015-03-051-1/+1
| |
* | [ci skip] Add information about sanitize option in TextHelper#highlightAnton Davydov2015-03-051-1/+6
| |
* | Merge pull request #19144 from y-yagi/fix_streaming_bufferRafael Mendonça França2015-03-041-1/+3
|\ \ | | | | | | fix ActionView::Template::Error when using Streaming with capture.
| * | fix ActionView::Template::Error when using Streaming with capture.yuuji.yaginuma2015-03-011-1/+3
| |/ | | | | | | can't acquire a encoding from StreamingBuffer. fixes #12001
* | Fix spelling [ci skip]Yu Haidong2015-03-041-8/+8
| |
* | move _generate_paths_by_default to where it is usedAaron Patterson2015-03-011-0/+6
|/ | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing
* Fix regression when passing a value different of String.Ulisses Almeida2015-02-261-1/+5
| | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.
* Fix typos in ActionView::Helpers::FormBuilder comment [ci skip]Yu Haidong2015-02-261-1/+2
|
* Merge pull request #19074 from ↵Rafael Mendonça França2015-02-251-4/+15
|\ | | | | | | | | Mession/fix_test_dependency_of_erb_template_partial_with_layout Fix dependency tracker bug
| * Fix dependency tracker bugJuho Leinonen2015-02-251-4/+15
| |
* | Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-256-2/+145
|\ \ | |/ |/| Merge multi_fetch_fragments.
| * Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-214-2/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-204-2/+77
| | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | Merge pull request #17069 from modosc/masterRafael Mendonça França2015-02-201-7/+9
|\ \ | | | | | | move cache_digests rake methods into their own namespace
| * | move cache_digests rake methods into their own namespacejonathan schatz2014-09-261-7/+9
| | |
* | | Fix cache_helper comment ERBAnthony Dmitriyev2015-02-201-2/+2
| | |
* | | Merge pull request #17143 from kuldeepaggarwal/fix-mailToRafael Mendonça França2015-02-201-1/+1
|\ \ \ | | | | | | | | | | | | mail_to helper method fix
| * | | do not generate blank options in mailToKuldeep Aggarwal2014-10-021-2/+3
| | | | | | | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* | | | Use a name that better reflect the return valueRafael Mendonça França2015-02-201-2/+2
| | | |
* | | | Merge pull request #17138 from jpcody/rename_default_form_builderRafael Mendonça França2015-02-201-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | Rename default_form_builder to avoid collision
| * | | | Rename default_form_builder to avoid collisionJoshua Cody2014-10-011-2/+2
| |/ / /
* | | | Corrects the API to method select_tagLeandro Nunes2015-02-201-2/+1
| | | | | | | | | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
* | | | Merge pull request #18411 from todd/extract_record_tag_helperRafael Mendonça França2015-02-182-99/+14
|\ \ \ \ | | | | | | | | | | Remove RecordTagHelper
| * | | | Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-162-99/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* | | | | Add nodoc to private constant [ci skip]Rafael Mendonça França2015-02-181-1/+1
| | | | |
* | | | | Merge pull request #18970 from nithinbekal/local-assigns-docRafael Mendonça França2015-02-181-0/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Add documentation for local_assigns [ci skip]
| * | | | | Add documentation for local_assigns [ci skip]Nithin Bekal2015-02-171-0/+8
| |/ / / /
* | | | | Improve documentation of local_assignsRafael Mendonça França2015-02-181-7/+13
| | | | |
* | | | | Merge pull request #15700 from maurogeorge/guides-local_assignsRafael Mendonça França2015-02-181-0/+7
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | Add docs about local_assigns on guides
| * | | | Add RDoc about local_assignsMauro George2014-06-131-0/+7
| | | | | | | | | | | | | | | | | | | | [ci skip]