aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
* Use match? where we don't need MatchDataAkira Matsuda2019-07-272-2/+2
| | | | We're already running Performance/RegexpMatch cop, but it seems like the cop is not always =~ justice
* Merge pull request #36178 from sshaw/fix_time_zone_options_priorityRafael França2019-07-261-3/+4
|\ | | | | Update time_zone_options_for_select docs
| * Update time_zone_options_for_select docssshaw2019-05-041-3/+4
| |
* | Added a phone_to helper method, on the style of mail_to and sms_to. (#36775)Pietro Moro2019-07-261-0/+47
| | | | | | | | | | | | | | | | | | | | | | * Added a phone_to helper method, on the style of mail_to and sms_to. It creates an anchor tag with the href set to tel: *here your number* which, when clicked on a mobile phone, or on a desktop with a supported application, lets the phone app kick in, and it prepopulates it with the phone number specified. [Pietro Moro + Rafael Mendonça França]
* | Add a default value for arg `format` in `ActionView::Digestor.digest()`Sharang Dashputre2019-07-261-1/+1
| |
* | Merge pull request #35334 from sharang-d/digest-doc-updateRafael França2019-07-261-3/+4
|\ \ | | | | | | Update comment for ActionView::Digestor.digest [ci skip]
| * | Update comment for ActionView::Digestor.digest [ci skip]Sharang Dashputre2019-04-161-3/+4
| | |
* | | Merge pull request #36576 from mtsmfm/mtsmfm/fix-fixture-resolverRafael Mendonça França2019-07-251-13/+25
|\ \ \ | | | | | | | | | | | | Support :any variants for ActionView::FixtureResolver
| * | | Support :any variants for FixtureResolverFumiaki MATSUSHIMA2019-06-301-13/+25
| | | |
* | | | Merge pull request #36412 from robotdana/compact_blankRafael Mendonça França2019-07-251-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | Add compact_blank shortcut for reject(&:blank?)
| * | | | Use compact_blank throughout railsDana Sherson2019-06-051-1/+1
| | | | |
* | | | | Merge pull request #36467 from spk/add-doc-host-protocol-asset_pathRafael França2019-07-241-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Add documentation on actionview asset_path with host and protocol
| * | | | | Add documentation on actionview asset_path with host and protocolLaurent Arnoud2019-06-121-0/+2
| |/ / / /
* | | | | Fix broken rdoc for UrlHelper [ci skip]Ryuta Kamizono2019-07-241-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | * Fix unintentionally linked String, Symbol, Hash, and ERB. * Fix unintentionally code block.
* | | | | Fix argument in doc sample of new `sms_to` helper [ci skip]Carlos Antonio da Silva2019-07-191-1/+1
| | | | |
* | | | | Merge pull request #36511 from aantix/sms_link_helperGuillermo Iguaran2019-07-191-0/+48
|\ \ \ \ \ | | | | | | | | | | | | Helper method to create an sms link
| * | | | | Doc changes.Jim Jones2019-06-181-4/+4
| | | | | |
| * | | | | Helper method to create an sms link - when clicked it opens the ↵Jim Jones2019-06-181-0/+48
| |/ / / / | | | | | | | | | | | | | | | phone/desktop's messaging client with the phone number and optional body value prepopulated.
* | | | | Fix a minor typo in ActionView::UnboundTemplateJean Boussier2019-07-191-3/+3
| | | | |
* | | | | Empty array instead of nil for source_extractGuilherme Mansur2019-07-141-12/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The source_extract method will return nil when it can't find the file name in the backtrace, methods that consume this method expect an array and the nil ends up causing type errors down the road like it happened here: #36341. This patch refactors the source_extract method so that it returns an empty array instead of nil when it can't find the source code. Co-authored-by: Kasper Timm Hansen <kaspth@gmail.com>
* | | | | active_support/deprecation has to be already required via ↵Akira Matsuda2019-07-125-7/+0
| | | | | | | | | | | | | | | | | | | | active_support/rails.rb
* | | | | A type class or nil has to respond_to :to_sAkira Matsuda2019-07-121-2/+1
| | | | |
* | | | | No Woman, No tryAkira Matsuda2019-07-121-1/+0
| |/ / / |/| | |
* | | | Autoload SyntaxErrorInTemplateGuilherme Mansur2019-06-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a SyntaxError is detected in a template we raise this exception. On a first request to the server the exception we get a NameError since the exception is not required from `active_view/template/error.rb` yet. However later on it gets required and a second request will succeed. On the first request we see the rails "Something Wen Wrong" page and not the expected syntax error in template error page with the webconsole and stacktrace. By autoloading the constant we fix this issue. Co-authored-by: Gannon McGibbon <gannon.mcgibbon@gmail.com>
* | | | Merge pull request #36482 from Shopify/fix-translation-helper-default-hashRafael França2019-06-171-1/+1
|\ \ \ \ | | | | | | | | | | Fix TranslationHelper#translate handling of Hash defaults
| * | | | Fix TranslationHelper#translate handling of Hash defaultsJean Boussier2019-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is sometimes expected of the `translate` methods to return a Hash, for instance it's the case of the `number.format` key. As such users might need to specify a Hash default, e.g. `translate(:'some.format', default: { separator: '.', delimiter: ',' })`. This works as expected with the `I18n.translate` methods, however `TranslationHelper#translate` apply `Array()` on the default value. As a result the default value end up as `[:separator, '.', :delimiter, ',']`.
* | | | | :golf:Akira Matsuda2019-06-151-6/+2
|/ / / /
* | | | [ci skip] Use default path in button_to documentationAlberto Almagro2019-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is really a nit pick, but as this is the framework's documentation I think it should follow standards as many times as possible to avoid confusion in new users. If we were using `resources :articles` in routes. which is what scaffold adds, the generated helper would be `new_article_path` instead of `new_articles_path`.
* | | | Merge pull request #36388 from joelhawksley/actionview-componentAaron Patterson2019-06-131-1/+5
|\ \ \ \ | | | | | | | | | | Introduce ActionView::Component
| * | | | `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`Joel Hawksley2019-06-121-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Natasha Umer <natashau@github.com> Co-authored-by: Aaron Patterson <tenderlove@github.com> Co-authored-by: Shawn Allen <shawnbot@github.com> Co-authored-by: Emily Plummer <emplums@github.com> Co-authored-by: Diana Mounter <broccolini@github.com> Co-authored-by: John Hawthorn <jhawthorn@github.com> Co-authored-by: Nathan Herald <myobie@github.com> Co-authored-by: Zaid Zawaideh <zawaideh@github.com> Co-authored-by: Zach Ahn <engineering@zachahn.com>
* | | | | Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-1342-50/+0
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* | | | Only clear cache when view paths are specifiedyuuji.yaginuma2019-06-041-0/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `clear_cache_if_necessary` is executed even if view paths are not set like `rails console`. If the watcher class is `EventedFileUpdateChecker` and the watch directories are empty, the application root directory will watch. This is because listen uses the current directory as the default watch directory. https://github.com/guard/listen/blob/8d85b4cd5788592799adea61af14a29bf2895d87/lib/listen/adapter/config.rb#L13 As a result, `node_modules` also watch. This cause a warning of `listen`. Ref: https://github.com/rails/rails/pull/36377#issuecomment-498399576
* | | Merge pull request #36324 from yoones/fix-unexpected-select-tag-delete-behaviorEileen M. Uchitelle2019-05-281-1/+2
|\ \ \ | | | | | | | | Fix unexpected select_tag delete behavior when include_blank is present
| * | | Fix select_tag so that is doesn't change options when include_blank is setYounes SERRAJ2019-05-221-1/+2
| | | |
* | | | Wrap actionview cache expiry in a mutexJohn Hawthorn2019-05-211-8/+11
| | | |
* | | | Correct human file size examples [ci skip]Alexander Graul2019-05-201-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | The `number_to_human_size` helpers in Action View and Active Support calculate the "human size" with a base of 1024. The examples should reflect that so they don't confuse the reader. The updated documentations use the values from: helper.number_to_human_size(1500)
* | / Remove useless find_partial methodst00122019-05-071-5/+1
| |/ |/|
* | Merge pull request #35337 from ↵Rafael França2019-05-013-8/+7
|\ \ | | | | | | | | | | | | abhaynikam/35265-remove-unused-argument-layout-from-rendered-template Removed unused layout attribute from RenderedTemplate
| * | Removed unused layout attribute from RenderedTemplateAbhay Nikam2019-03-093-8/+7
| | |
* | | `@controller` may not be defined here, and if so, it causes a Ruby warningAkira Matsuda2019-05-011-1/+1
| | | | | | | | | | | | e.g. via test-unit-rails' `run_setup`
* | | Fixes grammar in comments on tag_name and tag_idMichael Bock2019-04-251-2/+2
| | |
* | | Start Rails 6.1 developmentRafael Mendonça França2019-04-241-2/+2
| |/ |/|
* | Merge pull request #35959 from jhawthorn/unbound_templatesRafael França2019-04-154-14/+67
|\ \ | | | | | | De-duplicate templates, introduce UnboundTemplate
| * | Avoid duplication using _find_allJohn Hawthorn2019-04-121-11/+7
| | |
| * | Support disabling cache for DigestorJohn Hawthorn2019-04-122-22/+37
| | | | | | | | | | | | | | | | | | This adds a bit of complexity, but is necessary for now to avoid holding extra copies of templates which are resolved from ActionView::Digestor after disabling cache on the lookup context.
| * | De-dup Templates, introduce UnboundTemplateJohn Hawthorn2019-04-123-10/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it's possible to have multiple copies of the "same" Template. For example, if index.html.erb is found both the :en and :fr locale, it will return a different Template object for each. The same can happen with formats, variants, and handlers. This commit de-duplicates templates, there will now only be one template per file/virtual_path/locals tuple. We need to consider virtual_path because both `render "index"`, and `render "index.html"` can both find the same file but will have different virtual_paths. IMO this is rare and should be deprecated/removed, but it exists now so we need to consider it in order to cache correctly. This commit introduces a new UnboundTemplate class, which represents a template with unknown locals. Template objects can be built from it by using `#with_locals`. Currently, this is just a convenience around caching templates, but I hope it's a helpful concept that could have more utility in the future.
* | | Squash `warning: instance variable @filename not initialized`utilum2019-04-121-1/+1
|/ /
* | Remove FileTemplateJohn Hawthorn2019-04-043-14/+3
| | | | | | | | This is unnecessary now that we can just provide a file source
* | Deprecate Template#refreshJohn Hawthorn2019-04-041-19/+1
| |
* | Add ActionView::Template::Sources::FileJohn Hawthorn2019-04-044-24/+38
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 21:53:49 +0000