aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #36482 from Shopify/fix-translation-helper-default-hashRafael França2019-06-171-1/+1
|\ | | | | Fix TranslationHelper#translate handling of Hash defaults
| * Fix TranslationHelper#translate handling of Hash defaultsJean Boussier2019-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It is sometimes expected of the `translate` methods to return a Hash, for instance it's the case of the `number.format` key. As such users might need to specify a Hash default, e.g. `translate(:'some.format', default: { separator: '.', delimiter: ',' })`. This works as expected with the `I18n.translate` methods, however `TranslationHelper#translate` apply `Array()` on the default value. As a result the default value end up as `[:separator, '.', :delimiter, ',']`.
* | :golf:Akira Matsuda2019-06-151-6/+2
|/
* [ci skip] Use default path in button_to documentationAlberto Almagro2019-06-131-1/+1
| | | | | | | | | | This is really a nit pick, but as this is the framework's documentation I think it should follow standards as many times as possible to avoid confusion in new users. If we were using `resources :articles` in routes. which is what scaffold adds, the generated helper would be `new_article_path` instead of `new_articles_path`.
* Merge pull request #36388 from joelhawksley/actionview-componentAaron Patterson2019-06-131-1/+5
|\ | | | | Introduce ActionView::Component
| * `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`Joel Hawksley2019-06-121-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Natasha Umer <natashau@github.com> Co-authored-by: Aaron Patterson <tenderlove@github.com> Co-authored-by: Shawn Allen <shawnbot@github.com> Co-authored-by: Emily Plummer <emplums@github.com> Co-authored-by: Diana Mounter <broccolini@github.com> Co-authored-by: John Hawthorn <jhawthorn@github.com> Co-authored-by: Nathan Herald <myobie@github.com> Co-authored-by: Zaid Zawaideh <zawaideh@github.com> Co-authored-by: Zach Ahn <engineering@zachahn.com>
* | Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-1342-50/+0
| | | | | | | | | | | | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* | Only clear cache when view paths are specifiedyuuji.yaginuma2019-06-041-0/+2
|/ | | | | | | | | | | | Currently, `clear_cache_if_necessary` is executed even if view paths are not set like `rails console`. If the watcher class is `EventedFileUpdateChecker` and the watch directories are empty, the application root directory will watch. This is because listen uses the current directory as the default watch directory. https://github.com/guard/listen/blob/8d85b4cd5788592799adea61af14a29bf2895d87/lib/listen/adapter/config.rb#L13 As a result, `node_modules` also watch. This cause a warning of `listen`. Ref: https://github.com/rails/rails/pull/36377#issuecomment-498399576
* Merge pull request #36324 from yoones/fix-unexpected-select-tag-delete-behaviorEileen M. Uchitelle2019-05-281-1/+2
|\ | | | | Fix unexpected select_tag delete behavior when include_blank is present
| * Fix select_tag so that is doesn't change options when include_blank is setYounes SERRAJ2019-05-221-1/+2
| |
* | Wrap actionview cache expiry in a mutexJohn Hawthorn2019-05-211-8/+11
| |
* | Correct human file size examples [ci skip]Alexander Graul2019-05-201-1/+1
|/ | | | | | | | | | The `number_to_human_size` helpers in Action View and Active Support calculate the "human size" with a base of 1024. The examples should reflect that so they don't confuse the reader. The updated documentations use the values from: helper.number_to_human_size(1500)
* Remove useless find_partial methodst00122019-05-071-5/+1
|
* Merge pull request #35337 from ↵Rafael França2019-05-013-8/+7
|\ | | | | | | | | abhaynikam/35265-remove-unused-argument-layout-from-rendered-template Removed unused layout attribute from RenderedTemplate
| * Removed unused layout attribute from RenderedTemplateAbhay Nikam2019-03-093-8/+7
| |
* | `@controller` may not be defined here, and if so, it causes a Ruby warningAkira Matsuda2019-05-011-1/+1
| | | | | | | | e.g. via test-unit-rails' `run_setup`
* | Fixes grammar in comments on tag_name and tag_idMichael Bock2019-04-251-2/+2
| |
* | Start Rails 6.1 developmentRafael Mendonça França2019-04-241-2/+2
| |
* | Merge pull request #35959 from jhawthorn/unbound_templatesRafael França2019-04-154-14/+67
|\ \ | | | | | | De-duplicate templates, introduce UnboundTemplate
| * | Avoid duplication using _find_allJohn Hawthorn2019-04-121-11/+7
| | |
| * | Support disabling cache for DigestorJohn Hawthorn2019-04-122-22/+37
| | | | | | | | | | | | | | | | | | This adds a bit of complexity, but is necessary for now to avoid holding extra copies of templates which are resolved from ActionView::Digestor after disabling cache on the lookup context.
| * | De-dup Templates, introduce UnboundTemplateJohn Hawthorn2019-04-123-10/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it's possible to have multiple copies of the "same" Template. For example, if index.html.erb is found both the :en and :fr locale, it will return a different Template object for each. The same can happen with formats, variants, and handlers. This commit de-duplicates templates, there will now only be one template per file/virtual_path/locals tuple. We need to consider virtual_path because both `render "index"`, and `render "index.html"` can both find the same file but will have different virtual_paths. IMO this is rare and should be deprecated/removed, but it exists now so we need to consider it in order to cache correctly. This commit introduces a new UnboundTemplate class, which represents a template with unknown locals. Template objects can be built from it by using `#with_locals`. Currently, this is just a convenience around caching templates, but I hope it's a helpful concept that could have more utility in the future.
* | | Squash `warning: instance variable @filename not initialized`utilum2019-04-121-1/+1
|/ /
* | Remove FileTemplateJohn Hawthorn2019-04-043-14/+3
| | | | | | | | This is unnecessary now that we can just provide a file source
* | Deprecate Template#refreshJohn Hawthorn2019-04-041-19/+1
| |
* | Add ActionView::Template::Sources::FileJohn Hawthorn2019-04-044-24/+38
| |
* | Don't call Template#refreshJohn Hawthorn2019-04-041-6/+1
| | | | | | | | | | Now that Template#source will always return a source, this is unnecessary.
* | Don't discard source after renderingJohn Hawthorn2019-04-041-3/+0
| | | | | | | | | | | | | | | | | | | | Previously, we would discard the template source after rendering, if we had a virtual path, in hopes that the virtual path would let us find our same template again going through the Resolver. Previously we discarded the source as an optimization, to avoid keeping it around in memory. By instead just reading the file every time source is called, as FileTemplate does, this is unnecessary.
* | Fix arity warning for template handlerslocalhostdotdev2019-04-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mainly to help with knowning which template is reponsible for the warning. handler.class # => Class handler.to_s # => Coffee::Rails::TemplateHandler Before: Change: >> Class#call(template) To: >> Class#call(template, source) After: Change: >> Coffee::Rails::TemplateHandler.call(template) To: >> Coffee::Rails::TemplateHandler.call(template, source)
* | Merge pull request #35145 from st0012/fix-35114Rafael França2019-04-031-13/+20
|\ \ | | | | | | Fix partial caching ignore repeated items issue
| * | Fix partial caching ignore repeated items issuest00122019-04-041-13/+20
| | | | | | | | | | | | | | | | | | This is because we only use hash to maintain the result. So when the key are the same, the result would be skipped. The solution is to maintain an array for tracking every item's position to restructure the result.
* | | Fix checking for template variants when using the ActionView::FixtureResolverEdward Rudd2019-04-031-2/+2
| | |
* | | Merge pull request #35825 from jhawthorn/always_filter_view_pathsEileen M. Uchitelle2019-04-035-30/+25
|\ \ \ | |/ / |/| | Make Resolver#find_all_anywhere equivalent to #find_all
| * | Always reject files external to appJohn Hawthorn2019-04-035-30/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when using `render file:`, it was possible to render files not only at an absolute path or relative to the current directory, but relative to ANY view paths. This was probably done for absolutely maximum compatibility when addressing CVE-2016-0752, but I think is unlikely to be used in practice. Tihs commit removes the ability to `render file:` with a path relative to a non-fallback view path. Make FallbackResolver.new private To ensure nobody is making FallbackResolvers other than "/" and "". Make reject_files_external_... no-op for fallbacks Because there are only two values used for path: "" and "/", and File.join("", "") == File.join("/", "") == "/", this method was only testing that the absolute paths started at "/" (which of course all do). This commit doesn't change any behaviour, but it makes it explicit that the FallbackFileSystemResolver works this way. Remove outside_app_allowed argument Deprecate find_all_anywhere This is now equivalent to find_all Remove outside_app argument Deprecate find_file for find Both LookupContext#find_file and PathSet#find_file are now equivalent to their respective #find methods.
* | | [ci skip] Updated the doc after renaming Template::File -> Template::RawFile ↵Abhay Nikam2019-04-021-1/+1
| | | | | | | | | | | | in #35826
* | | Rename File to RawFileCliff Pruitt2019-04-015-5/+5
|/ /
* | Only clear template caches in dev after changes (#35629)John Hawthorn2019-04-015-7/+53
| |
* | url -> URL where apt except inside actionpack/Sharang Dashputre2019-04-012-2/+2
| |
* | Merge pull request #35793 from jhawthorn/deprecate_layout_absolute_pathKasper Timm Hansen2019-03-311-0/+1
|\ \ | | | | | | Deprecate render layout with an absolute path
| * | Deprecate render layout with an absolute pathJohn Hawthorn2019-03-291-0/+1
| | | | | | | | | | | | | | | | | | | | | This has similar problems to render file:. I've never seen this used, and believe it's a relic from when all templates could be rendered from an absolute path.
* | | Merge pull request #35688 from jhawthorn/render_file_rfcAaron Patterson2019-03-305-4/+38
|\ \ \ | |/ / |/| | RFC: Introduce Template::File
| * | Introduce Template::File as new render file:John Hawthorn2019-03-275-4/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous behaviour of render file: was essentially the same as render template:, except that templates can be specified as an absolute path on the filesystem. This makes sense for historic reasons, but now render file: is almost exclusively used to render raw files (not .erb) like public/404.html. In addition to complicating the code in template/resolver.rb, I think the current behaviour is surprising to developers. This commit deprecates the existing "lookup a template from anywhere" behaviour and replaces it with "render this file exactly as it is on disk". Handlers will no longer be used (it will render the same as if the :raw handler was used), but formats (.html, .xml, etc) will still be detected (and will default to :plain). The existing render file: behaviour was the path through which Rails apps were vulnerable in the recent CVE-2019-5418. Although the vulnerability has been patched in a fully backwards-compatible way, I think it's a strong hint that we should drop the existing previously-vulnerable behaviour if it isn't a benefit to developers.
* | | Fix annotated typoPrathamesh Sonpatki2019-03-292-3/+3
| | |
* | | Merge pull request #35308 from ↵Rafael França2019-03-282-1/+29
|\ \ \ | |/ / |/| | | | | | | | erose/better-error-reporting-for-syntax-errors-in-templates Display a more helpful error message when an ERB template has a Ruby syntax error.
| * | Add handling and tests.Eli Rose2019-02-172-1/+29
| | |
* | | Merge pull request #35758 from Shigeyuki-fukuda/aligned_order_of_argumentRafael França2019-03-261-2/+2
|\ \ \ | | | | | | | | Aligned the order of the arguments of render_template and render_with_layout
| * | | Aligned the order of the arguments of render_template and render_with_layoutShigeyuki-fukuda2019-03-271-2/+2
| | | |
* | | | Deprecate custom patterns for PathResolverJohn Hawthorn2019-03-261-39/+11
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Custom glob patterns tie the implementation (Using Dir.glob) to the API we provide. It also doesn't really work. extract_handler_and_format_and_variant expects the handler, format, and variant to be at the end of the template path, and in the same order as they are in the default pattern. This deprecates specifying a custom path for FileSystemResolver and removes the pattern argument of OptimizedFileSystemResolver#initialize, which does not work with a custom pattern.
* | | Merge pull request #35661 from jhawthorn/lookup_context_validationEileen M. Uchitelle2019-03-202-1/+9
|\ \ \ | | | | | | | | Validate types assigned to LookupContext#formats=
| * | | Don't compact formatsJohn Hawthorn2019-03-191-1/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 20:48:20 +0000