Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | unnecessary checking of `size` with `second regex` if matched with first one | Kuldeep Aggarwal | 2013-11-27 | 1 | -2/+5 | |
|/ / / / | ||||||
* | | | | Minor typo fixes | Akira Matsuda | 2013-11-27 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Revert "Merge pull request #13027 from akshay-vishnoi/f-refactor" | Carlos Antonio da Silva | 2013-11-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f4a5a9ea4d183f4102796215d4502c46dbe3e52b, reversing changes made to 7ccb482181ee6c47c765406009018a15172812de. Reason: The logic is different, the first call to #option_value_selected? is for the :selected option (the argument is the "selected" variable), the second call is for the :disabled option (the argument is the "disabled" variable). | |||||
* | | | | avoiding calling of #option_value_selected? two times | Akshay Vishnoi | 2013-11-25 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | _implied_layout_name should be private | Rafael Mendonça França | 2013-11-19 | 1 | -9/+11 | |
| | | | ||||||
* | | | Use the right indentation | Rafael Mendonça França | 2013-11-19 | 1 | -1/+1 | |
| | | | ||||||
* | | | Renderer#_render_template should be private | Rafael Mendonça França | 2013-11-19 | 1 | -7/+7 | |
| | | | | | | | | | | | | Closes #12831 | |||||
* | | | Improve readability of sentence in partial-renderer docs [ci skip] | Mac Martine | 2013-11-19 | 1 | -1/+1 | |
| | | | ||||||
* | | | Use `set_backtrace` instead of `@backtrace` in ActionView error | Shimpei Makimoto | 2013-11-16 | 1 | -2/+2 | |
| | | | ||||||
* | | | Merge pull request #12853 from joshjordan/master | Rafael Mendonça França | 2013-11-15 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Allocate one less object using html_safe during content_tag construction | |||||
| * | | | Allocate one less object using html_safe during content_tag construction | Josh Jordan | 2013-11-14 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Take Hash with options inside Array in #url_for | Andrey Ognevsky | 2013-11-15 | 1 | -0/+2 | |
|/ / / | ||||||
* | | | Revert "Used Yield instead of block.call" -- this causes all of ↵ | David Heinemeier Hansson | 2013-11-14 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd. | |||||
* | | | Merge pull request #12889 from kuldeepaggarwal/speed_ups | Rafael Mendonça França | 2013-11-14 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | Used Yield instead of block.call | |||||
| * | | | Used Yield instead of block.call | Kuldeep Aggarwal | 2013-11-15 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Fix syntax error in atom_feed example [ci skip] | Saulius Grigaliunas | 2013-11-13 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | Builder's #tag! takes either String or Symbol as the first parameter | |||||
* | | | Make the method name the first argument | Rafael Mendonça França | 2013-11-09 | 1 | -7/+7 | |
| | | | | | | | | | | | | | | | This is the only argument that changes over the method calls so it is better to it be the first one | |||||
* | | | Drop one more string allocation | Rafael Mendonça França | 2013-11-09 | 1 | -1/+3 | |
| | | | ||||||
* | | | Merge pull request #12760 from pseidemann/master | Yves Senn | 2013-11-09 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | fix simple_format escapes own output when sanitize is set to true | |||||
| * | | | fix simple_format escapes own output when sanitize is set to true | pseidemann | 2013-11-08 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Extract common code from number helpers to new delegator method. | Vipul A M | 2013-11-09 | 1 | -30/+13 | |
| | | | | ||||||
* | | | | sub! can return nil | Arun Agrawal | 2013-11-07 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Revert "drop one more string allocation" This reverts commit 4d15661d6c46c86a62ee1fc358f4b3ef9dd9f2ea. | |||||
* | | | | drop one more string allocation | Aaron Patterson | 2013-11-06 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | drop string allocations in the log subscriber | Aaron Patterson | 2013-11-06 | 1 | -2/+12 | |
| | | | | ||||||
* | | | | Merge pull request #12788 from kylefritz/patch-1 | Rafael Mendonça França | 2013-11-06 | 1 | -2/+2 | |
|/ / / | | | | | | | | | | | | | | | | rdoc: favicon source shouldn't begin with a slash to reference asset pipeline resource [ci skip] Conflicts: actionview/lib/action_view/helpers/asset_tag_helper.rb | |||||
* | | | Line up the comments for aesthetics | David Heinemeier Hansson | 2013-11-03 | 1 | -5/+5 | |
| | | | ||||||
* | | | Convert CDATA input to string before gsub'ing | Carsten Zimmermann | 2013-10-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | Rails 3.2 API allowed arbitrary input for cdata_section; this change re-introduces the old behaviour. | |||||
* | | | Remove warning of shadowing outer local variable | Rafael Mendonça França | 2013-10-27 | 1 | -2/+2 | |
| |/ |/| | ||||||
* | | Merge pull request #12636 from kongregate/dont_rescue_Exceptions | Rafael Mendonça França | 2013-10-24 | 1 | -2/+2 | |
|\ \ | | | | | | | Avoid unnecessary catching of Exception instead of StandardError (conver... | |||||
| * | | Avoid unnecessary catching of Exception instead of StandardError (converting ↵ | stopdropandrew | 2013-10-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | Exceptions into StandardErrors) | |||||
* | | | Merge pull request #10471 from andyw8/button_to_params | Rafael Mendonça França | 2013-10-24 | 1 | -0/+7 | |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md | |||||
| * | | Add params option for button_to | Andy Waite | 2013-09-18 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes. | |||||
* | | | Merge pull request #12540 from wyaeld/bug/fix-recursive-digest | Rafael Mendonça França | 2013-10-16 | 1 | -6/+6 | |
|\ \ \ | | | | | | | | | | | | | Ensure ActionView::Digestor.cache is correctly cleaned up | |||||
| * | | | add a new local variable to track if digests are being stored, to ensure the ↵ | Brad Murray | 2013-10-17 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | cleanup works correctly | |||||
| * | | | update digestor code based on review | Brad Murray | 2013-10-15 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | Ensure ActionView::Digest.cache is correctly cleaned up when | Brad Murray | 2013-10-15 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | ActionView::Resolver.caching = false. | |||||
* | | | | Fix typo in form_helper.rb | Adam Jahnke | 2013-10-16 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #12491 from shamanime/patch-1 | Rafael Mendonça França | 2013-10-13 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | Fix wrong variable name used in the select_day method documentation | |||||
| * | | | Fix wrong variable name used in the select_day method documentation | Jefferson Queiroz Venerando | 2013-10-10 | 1 | -2/+2 | |
| | | | | | | | | | | | | The variable name created in the example is `my_date`, the methods were using `my_time` instead. | |||||
* | | | | Change `map` to `map!` to save extra array creation on new array | Vipul A M | 2013-10-13 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Fixed return strings in documentation | Joseph Zidell | 2013-10-03 | 1 | -3/+3 | |
| | | | ||||||
* | | | Fixed typo in documentation | Joseph Zidell | 2013-10-03 | 1 | -3/+3 | |
| | | | ||||||
* | | | Adds template dependencies rake task from cache_digests gem. | Thomas von Deyen | 2013-09-26 | 2 | -0/+21 | |
| | | | | | | | | | | | | This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem. | |||||
* | | | Use the given name in html_options for the hidden field in ↵ | Angel N. Sciortino | 2013-09-24 | 1 | -1/+2 | |
| | | | | | | | | | | | | collection_check_boxes | |||||
* | | | Merge pull request #10773 from wangjohn/link_and_routing_options | Rafael Mendonça França | 2013-09-23 | 1 | -2/+3 | |
| | | | | | | | | | | | | Adding documentation and tests to ``polymorphic_url`` and ``link_to`` | |||||
* | | | Fix some edge cases for AV `select` helper with `:selected` option | Bogdan Gusiev | 2013-09-23 | 1 | -1/+2 | |
| | | | ||||||
* | | | Expand select documentation to tell about the block | Rafael Mendonça França | 2013-09-23 | 1 | -0/+9 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Ability to pass block to AV#select helper | Bogdan Gusiev | 2013-09-23 | 2 | -5/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name | |||||
* | | | handle `:namespace` form option in collection labels | Vasiliy Ermolovich | 2013-09-22 | 2 | -1/+3 | |
| | | | ||||||
* | | | Bust the template digest cache key when details are changed | Daniel Schierbeck | 2013-09-19 | 1 | -1/+4 | |
| | | | | | | | | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value. |