| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | |
| | | | | |
mail_to helper method fix
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
when mail_to generate blank options for any passed options(cc, bcc, body, subject)
then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Rename default_form_builder to avoid collision
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
The 'selected' option is not doing what it should do.
The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove RecordTagHelper
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been
extracted to an external gem (source currently lives at
todd/record_tag_helper). Removal notices have also been added for anyone
upgrading that use the extracted methods.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Add documentation for local_assigns [ci skip]
|
| |/ / / / / |
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | | |
Add docs about local_assigns on guides
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
This makes the behavior more consistent with `width` or `height` options
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove some code duplication in ActionView tags code
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This removes the following warning:
/GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Refactoring at #18647 broke using non active record objects in form_for. This patch
restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated.
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
call is too generic
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Thse methods are used only inside this class
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
The `model_name` method should be called on `to_model`
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
onwards.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
A shortcut to setup controller environment
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Its only used by ActionView internals and not supposed to be used
through public API.
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
While we don't want to change the form input when validations fail,
blindly using `_before_type_cast` will cause the input to display the
wrong data for any type which does additional work on database values.
|
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should never be ignoring valuable information that the types may need
to give us. The reason that it originally used `_before_type_cast` is
unclear, but appears to date back long enough that the reasons may not
be relevant today. There is only one test that asserts that it uses the
before type cast version, but it gives no context as to why and uses a
mock which does not simulate the real world.
Fixes #18523.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tigrish/fix_custom_i18n_exception_handler_regression
Fix I18n regression introduced by #13832
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now that we only support Ruby 2.2+ we don't need this conditional
anymore
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Tests should still pass after removing `require 'active_support/deprecation'`
from these files since the related deprecations have been removed.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These requires were added only to change deprecation message
|