| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
Use frozen string literal in actionview/
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Delegate respond_to? in ActionView::Helpers::ControllerHelper
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since methods defined in the controller helper are mostly delegated to
the controller, delegate respond_to? as well, so that for example
`respond_to?(:params)` behaves as expected.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
|
| |/
| |
| |
| | |
removed already
|
|/ |
|
| |
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |\
| | |
| | |
| | | |
Enforce frozen string in Rubocop
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | | |
| | | |
| | | |
| | | | |
Plus a couple of related ActionPack patches.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Includes two external changes because they're referenced within the ActiveModel test suite.
|
| |\ \ \
| | |_|/
| |/| |
| | | | |
Add srcset option to image_tag helper
|
| |/ / |
|
|/ / |
|
|/ |
|
|
|
|
|
| |
This makes sure that the labels are linked up with the fields.
Fixes #29014
|
|
|
|
| |
That won't be true for Action Pack and Action Mailer.
|
|
|
|
| |
st0012/fix-partial-cache-logging
|
|
|
|
| |
boolean.
|
|
|
|
|
|
| |
Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934
cc @rafaelfranca
|
| |
|
|\
| |
| |
| |
| | |
bogdanvlviv/pass_params_filename_lineno_to_class_eval
Pass params __FILE__ and __LINE__ + 1 if class_eval with <<
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Allow a default value to be declared for class_attribute
* Convert to using class_attribute default rather than explicit setter
* Removed instance_accessor option by mistake
* False is a valid default value
* Documentation
|
|\ \
| | |
| | | |
Define path with __dir__
|
| |/
| |
| |
| |
| |
| | |
".. with __dir__ we can restore order in the Universe." - by @fxn
Related to 5b8738c2df003a96f0e490c43559747618d10f5f
|
|\ \
| |/
|/| |
Fix select tag helper used with Enumerable choices
|
| |
| |
| |
| |
| |
| | |
Allows a custom object implementing Enumerable to be used as the choices
parameter for a select tag, which previously wasn't possible due to the
call to `empty?` on the choices (which isn't implemented on Enumerable).
|
| |
| |
| |
| |
| | |
This allows auto_discovery_link_tag to support the JSON Feed standard.
See https://jsonfeed.org/version/1 for more information.
|
|/ |
|
|\
| |
| | |
Ensure input to distance_of_time_in_words is not nil
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Internally all input is converted to time so that it can be treated
uniformly.
Remove now-unneeded condition
* Now that all input is treated is converted to time, we no longer need
to type check it.
Rename variables to clarify their purpose
Extract private method to normalize distance_of_time args to time
Update actionview changelog
|
|\ \
| | |
| | |
| | |
| | | |
kyuden/remove_unnecessary_attributes_of_select_in_form_with
Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with`
|
| |/
| |
| |
| | |
`allow_method_names_outside_object` attributes of select tag in `form_with`
|
|/
|
|
|
|
| |
- `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object
- ref https://github.com/rails/rails/pull/27549
- Fixes #28846
|
|
|
|
|
|
|
|
|
| |
specified
Without this check, even if config is not specified, `ActionView::Helpers::FormHelper.form_with_generates_remote_forms`
always be set to nil and remote form not be generated.
Follow up to 128b804c6ce40fcbde744f294f8cb98654f6efec
|
|
|
|
|
|
|
|
|
| |
This configuration is not present in ActionView::Base so we can't let
the action_view.set_configs initializer set it.
Also add tests to make sure this config works.
Fixes #28824
|
|
|
|
|
| |
Since this protection is now in Parameters we can use it instead of
reimplementing again.
|
|
|
|
|
|
|
| |
Allows users to not have remote forms by default, since there's
more JS harness, e.g. bundling rails-ujs, otherwise.
Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
|
|
|
|
|
|
|
| |
Effectively treat nil values as "auto", e.g. whatever a form helper
chooses to interpret it as.
But treat an explicitly assigned false value as disabling.
|
|
|
|
| |
Replace `FormOptionHelper` to `FormOptionsHelper`.
|
| |
|