| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The Logger by default includes a guard which checks for the
logging level. By removing the custom logging guards, we can decouple
the logging guard from the logging action to be done.
This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
[Jonas Baumann & Yves Senn]
The submitted params from a select with `multiple: true` look as follows:
```
{post: {category: [""]}}
{post: {category: ["", "Category 1", "Category 2"]}}
```
This is a follow up to #1552.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The performance is almost the same with both implementations but this is
clear.
Before this patch:
Calculating -------------------------------------
small erb template 1452 i/100ms
-------------------------------------------------
small erb template 17462.1 (±13.3%) i/s - 85668 in 5.031395s
.Calculating -------------------------------------
small erb template with 1 partial
887 i/100ms
-------------------------------------------------
small erb template with 1 partial
8899.6 (±18.8%) i/s - 42576 in 5.009453s
.Calculating -------------------------------------
small erb template with 2 partials
666 i/100ms
-------------------------------------------------
small erb template with 2 partials
6821.5 (±8.8%) i/s - 33966 in 5.020791s
After the patch:
Calculating -------------------------------------
small erb template 1479 i/100ms
-------------------------------------------------
small erb template 15956.6 (±7.6%) i/s - 79866 in 5.036001s
.Calculating -------------------------------------
small erb template with 1 partial
841 i/100ms
-------------------------------------------------
small erb template with 1 partial
9242.2 (±6.9%) i/s - 46255 in 5.029497s
.Calculating -------------------------------------
small erb template with 2 partials
615 i/100ms
-------------------------------------------------
small erb template with 2 partials
6524.7 (±6.8%) i/s - 32595 in 5.020456s
You can find the benchmark code at
https://gist.github.com/rafaelfranca/dee31120cfdb1ddc3b56
|
| |\ \
| | | |
| | | |
| | | | |
remove Set.new from DetailsKey::get, impacts rendering overhead
|
| | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using ruby-prof, I noticed that Set#add had the largest 'self time'
percentage (5% of the overall time spent rendering) when
benchmarking the rendering of a small cached ERB template that was 3
lines long. It turns out it was from this line. I don't believe the
Set is necessary, either. Removing this line increases the rendering
ips using Benchmark::ips accordingly.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
This class is only used on the PartialRenderer.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The iteration object is available as the local variable
"template_name_iteration" when rendering partials with collections.
It gives access to the +size+ of the collection beeing iterated over,
the current +index+ and two convinicence methods +first?+ and +last?+
"template_name_counter" variable is kept but is deprecated.
[Joel Junström + Lucas Uyezu]
|
| |\ \
| | | |
| | | | |
Log digest as :debug instead of :info
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| | |
Fix empty host for an asset url when asset_host proc returns nil
|
| | | |
| | | |
| | | |
| | | | |
the `asset_host` proc returning nil
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | | |
To avoid having to redefine these methods on the deprecated plugin we
should be using the sanitizer_vendor API.
|
| | |
| | |
| | |
| | | |
We can just use nokogiri
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | | |
Loofah-integration
Conflicts:
actionpack/CHANGELOG.md
actionview/CHANGELOG.md
|
| | |
| | |
| | |
| | | |
ASCII-8BIT test errors.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
WhiteListSanitizer.
|
| | | |
|
| | |
| | |
| | |
| | | |
protocol_separator accessors and bad_tags=.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Rails::Dom::Testing::Assertions.
|
| | |
| | |
| | |
| | | |
tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception.
|
| | | |
|
| | |
| | |
| | |
| | | |
Loofah's strip scrubber.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
WhiteListSanitizer. This means it'll return false if called with false, however that is not a valid use case.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
rebase.
|
| | | |
|
| | | |
|