aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
* remove un-needed sortschneems2014-10-071-1/+1
| | | | | | HTML doesn't care what order the elements are rendered in, so why should we? Updates tests to use proper `assert_dom_equal` instead of `assert_equal` /cc @jeremy
* Use #tr instead of #gsub where possibleAlex Weidmann2014-10-022-2/+2
|
* use tr instead of gsub when possibleAdrian Rangel2014-10-011-1/+1
|
* Added processing of `nil` to `highlight` helper methodigor042014-09-301-1/+1
|
* Parse HTML as document fragment.Kasper Timm Hansen2014-09-291-1/+1
| | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.
* Preparing for 4.2.0.beta2 releaseRafael Mendonça França2014-09-261-1/+1
|
* Add +variants to ActionView::FileSystemResolver documentation.Felipe Oliveira2014-09-261-3/+4
|
* Revert "Revert "Merge pull request #16888 from jejacks0n/render_template""Godfrey Chan2014-09-261-2/+2
| | | | This reverts commit 585e75696b31395aee895e5366e331c07c3f5ee1.
* Revert "Merge pull request #16888 from jejacks0n/render_template"Godfrey Chan2014-09-231-2/+2
| | | | | | | This reverts commit 07635a74b5ee08dcba3f6617def6230d8f114fe5, reversing changes made to 1b5f61a025b6ce1ee52b7148e3ed2a9acbde28b9. Reason: it's not ready :bomb:, see https://github.com/rails/rails/pull/16888#issuecomment-56400816
* Merge pull request #16888 from jejacks0n/render_templateGodfrey Chan2014-09-231-2/+2
|\ | | | | | | Changes default render behavior from file to template.
| * Changes default render behavior from file to template.jejacks0n2014-09-111-2/+2
| |
* | Remove wrapping <div> in form helpers from docclaudiob2014-09-222-35/+19
| | | | | | | | | | | | | | | | | | | | [ci skip] 89ff1f8 and 1de258e6 removed from the HTML generated by the form helpers the <div> that was wrapping the field elements inside the <form>. This commit updates the documentation of the methods to reflect the two commits above.
* | Merge pull request #16790 from cirosantilli/explain-erb-space-removalRafael Mendonça França2014-09-161-1/+3
|\ \ | | | | | | | | | | | | Explain ERB space removal. [ci skip]
| * | Explain ERB space removal. [ci skip]Ciro Santilli2014-09-111-1/+3
| | |
* | | handle <%== nil %> casesAaron Patterson2014-09-142-2/+7
| | | | | | | | | | | | | | | This is much less common than string literal appends, so add a special case method for it. Maybe fixes bug reported by @jeremy on 97ef636191933f1d4abc92fc10871e6d1195285c
* | | Stop nil checking on safe_append=Aaron Patterson2014-09-141-4/+0
| | | | | | | | | | | | | | | | | | ERB compiler guarantees safe_append= will be called with a string, so nil checks don't make sense. Anything else calling this method should check for nil themselves before calling
* | | Revert "Merge pull request #15312 from JuanitoFatas/action_view/asset_path"Matthew Draper2014-09-141-1/+1
| |/ |/| | | | | | | | | | | This reverts commit 21ec7fefea5a1b823cb88733b019b3d52240801d. Per #16911, there's actually a good reason for a "blank" value to have a useful `to_s` here. So let's also add some tests to prove that.
* | Do not memoize document_root_element in view testsRafael Mendonça França2014-09-081-2/+1
| | | | | | | | | | | | | | Memoizing will not make possible to assert the output of the view if it is changed after the first assert_select call Related with plataformatec/simple_form#1130 and rails/rails-dom-testing#15
* | fix the undefined method content_tag #15245Rajarshi Das2014-09-061-0/+1
| | | | | | | | not required include ActionView::Helpers::TagHelper in test as well
* | Extract data/aria attribute prefixes to a constantRafael Mendonça França2014-09-031-1/+3
| |
* | Add support for ARIA attributes in tagsPaoMar2014-09-031-4/+4
| |
* | Ship with rails-html-sanitizer instead.Kasper Timm Hansen2014-09-031-8/+3
|/
* Shorten ActionView::Base doc summary line. [ci skip]Ciro Santilli2014-09-021-3/+4
|
* Clarify Rails uses erubis not stdlin ERB. [ci skip]Ciro Santilli2014-09-021-1/+2
|
* Move implementation to the gemsRafael Mendonça França2014-09-011-22/+10
| | | | Now we keep only the common code and move the specific code to the gems
* Refer to the library name instead of the constantRobin Dupret2014-08-301-1/+1
| | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria]
* Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-294-38/+54
|\
| * remove useless parameterAaron Patterson2014-08-271-2/+2
| |
| * remove dead codeAaron Patterson2014-08-271-12/+2
| | | | | | | | | | | | the ERB has already been compiled to Ruby code by the time we're calling module_eval. Nothing that module eval raises will be caught by a blank `rescue`, so I think we can remove this
| * Merge pull request #16488 from agrobbin/form-label-builderJeremy Kemper2014-08-251-22/+46
| |\ | | | | | | Provide a builder for form labels to customize wrapping around I18n content
| | * provide a builder for form labels to customize wrapping around I18n contentAlex Robbin2014-08-201-22/+46
| | |
| * | Merge pull request #16639 from agrobbin/input-placeholder-i18nJeremy Kemper2014-08-243-0/+42
| |\ \ | | | | | | | | Add I18n support for `:placeholder` HTML option is passed to form fields
| | * | just use the placeholder tag value if it is passed as a StringAlex Robbin2014-08-221-1/+3
| | | |
| | * | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-223-0/+40
| | | |
| * | | Remove erroneous form_tag option docsT.J. Schuck2014-08-221-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is true of the first param (url_for_options), not of the second options param which is being documented here. [ci skip]
| * | | Clarify that unknown keys will become HTML attrsT.J. Schuck2014-08-221-0/+1
| |/ / | | | | | | | | | | | | | | | Docs for all the other form tag helpers in this file already clarify this. [ci skip]
| * / Revert "Add I18n support for `:placeholder` HTML option is passed to form ↵Jeremy Kemper2014-08-213-40/+0
| |/ | | | | | | fields"
* / Preparing for 4.2.0.beta1 releaseDavid Heinemeier Hansson2014-08-191-1/+1
|/
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-08-197-18/+18
|\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb actionview/lib/action_view/vendor/html-scanner/html/sanitizer.rb activerecord/lib/active_record/type/value.rb
| * Uppercase HTML in docs.Hendy Tanata2014-08-088-19/+19
| | | | | | | | [skip ci]
* | Merge pull request #15889 from carnesmedia/model-nameRafael Mendonça França2014-08-173-4/+4
|\ \ | | | | | | | | | Use #model_name on instances instead of classes
| * | Use #model_name on instances instead of classesAmiel Martin2014-06-243-4/+4
| | | | | | | | | | | | | | | | | | This allows rails code to be more confdent when asking for a model name, instead of having to ask for the class. Rails core discussion here: https://groups.google.com/forum/#!topic/rubyonrails-core/ThSaXw9y1F8
* | | Merge branch 'master' into loofahRafael Mendonça França2014-08-175-1/+44
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md
| * | | Perf optimization for `url_for` called w/ Hashschneems2014-08-141-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmarking the existing code: ```ruby { :only_path => options[:host].nil? }.merge!(options.symbolize_keys)) ``` Against optimized code, that does not require a new hash or a merge: ```ruby options = options.symbolize_keys options[:only_path] = options[:host].nil? unless options.key?(:only_path) options ``` We see a statistically significant performance gain: ![](https://www.dropbox.com/s/onocpc0zfw4kjxl/Screenshot%202014-08-14%2012.45.30.png?dl=1) Updated to not mutate incoming parameters
| * | | Merge pull request #16438 from agrobbin/input-placeholder-i18nJeremy Kemper2014-08-143-0/+40
| |\ \ \ | | | | | | | | | | Add I18n support for `:placeholder` HTML option is passed to form fields
| | * | | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-123-0/+40
| | | | |
| * | | | Missing ActiveSupport require for calling String#firstAkira Matsuda2014-08-141-0/+1
| |/ / /
* | | | Prepare for partial release.Kasper Timm Hansen2014-08-171-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Default to Rails::DeprecatedSanitizer in ActionView::Helpers::SanitizeHelper. - Add upgrade notes. - Add sanitizer to new applications Gemfiles. - Remove 'rails-dom-testing' as a dependency.
* | | | Merge branch 'master' into loofahRafael Mendonça França2014-08-1215-154/+194
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md
| * | | defined? should actually work in current implementationAkira Matsuda2014-08-071-9/+0
| | | | | | | | | | | | | | | | So this trick is not needed to be documented anymore.