| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
Improve detection of partial templates eligible for collection caching.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The regular expression which was used to detect partial templates that
begin with a `<% cache ... do %>` call missed some cases. This commits
attempts to improve the detection for some cases such as multi-line
comments at the beginning of the template. The different templates are
listed in two new unit test methods.
Note that specially crafted Ruby code can still evade such `cache`-call
detection: for example, a user might have its own method which itself
calls the Rails `cache` helper. In such a case, the template's code
doesn't start with a literal `cache` string and therefore will not be
eligible for collection caching.
|
|/ / |
|
|\ \
| | |
| | | |
Remove duplicate private statement
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
Conflicts:
guides/source/configuring.md
|
| | |
| | |
| | |
| | | |
LookupContext is class name
|
| | | |
|
| | |
| | |
| | |
| | | |
This is same type commit of https://github.com/rails/rails/pull/20463
|
| | |
| | |
| | |
| | | |
Just saw these in passing while reading this file.
|
| |/
|/|
| |
| | |
Colons are not metacharacters.
|
| | |
|
|\ \
| | |
| | | |
Add RDoc about scope option on distance_of_time_in_words
|
| | |
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Add missing spec and documentation for button_tag helper
|
| | | | |
|
| |/ /
|/| |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
add error log that notify 'file not found' when using cache_digest dependency rake
|
| | | |
| | | |
| | | |
| | | | |
cache_digests:dependency and cache_digests:nested_dependency tasks
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`Tags::Base#select_content_tag`.
Previously, passing a falsey value to `include_blank` would be ignored if the
field was required, and a blank line would still be inserted. The following will
now raise instead of quietly failing:
`select("post", "category", %w(a required field), { include_blank: false }, required: 'required')`
|
| |_|/
|/| | |
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit a9d58c77da800bb0052c9bfa432828b02526022c, reversing
changes made to 041c2c879a3c4086ad3aa6d30fed1eede1d53c11.
Reason: The old behavior is how it was working in previous version of
Rails since 4.0.x so it is not safe to backport to a stable branch.
See https://github.com/rails/rails/issues/19626#issuecomment-89862258
and https://github.com/rails/rails/pull/15050#issuecomment-45333449
|
| | | | |
|
| | | | |
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
When one rendered a partial template without specifying an object
or a collection (e.g. <%= render partial: 'partial_name' %>), Rails
would make an object called :partial_name available in local_assigns.
I don't think this was the intended behavior, since no local variable
called 'partial_name' gets defined in the view.
|
|/ / |
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | | |
In help text for method, dynamic value makes it hard to understand, so replaced with static value matching with example above
|
| |/
|/|
| |
| | |
Should be ApplicationController not ApplicationController::Base
|
| |
| |
| |
| | |
supported by I18n.
|
|\ \
| | |
| | | |
Handle raise flag in translate when both main and default translation is missing.
|
| | |
| | |
| | |
| | | |
missing. Fixes #19967
|
|\ \ \
| | | |
| | | | |
Actionview image tag size option override
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
stevenspiel/link_to_if_block_helper_addition"
This reverts commit d459b001b43d25053e7982e96eb8383538a6e358, reversing
changes made to 4d4950fae9e2a6970b5f1793aadc56a0b44e28a3.
:sweat:
The block is not supposed to be passed to `link_to`. It's used for a
customized behavior of the `condtion = false` case. The docs
illustrate that like so:
```
<%=
link_to_if(@current_user.nil?, "Login", { controller: "sessions", action: "new" }) do
link_to(@current_user.login, { controller: "accounts", action: "show", id: @current_user })
end
%>
```
|
|\ \ \
| | | |
| | | |
| | | | |
Update url_helper.rb
|
| |/ /
| | |
| | | |
add block to link_to_if when condition is true
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The documentation previously stated that calling `translate(".foo")` was
equivalent to calling `I18n.translate("people.index.foo")` which is
incorrect due to the various other functions of the `translate` view
helper. This has been fixed.
Additionally, a note about forcing the view helper to re-raise
exceptions was added to the section detailing the handling of missing
translations.
Other cleanup includes:
* Consistent formatting of code
* Stop indenting bulleted list as a code sample
* Tighten some of the language
* Wrap at 80 characters.
|
| | |
|
|\ \
| | |
| | | |
[Skip ci] Add information about :host options
|
| | |
| | |
| | |
| | |
| | |
| | | |
Added informations about :host options for each url helper
(#javascript_url, #video_url, #stylesheet_url, etc) based on #asser_url
method.
|
|\ \ \
| |_|/
|/| | |
Set default form builder for a controller
|