aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib
Commit message (Collapse)AuthorAgeFilesLines
* Feature detect based on Ruby version.Aaron Patterson2014-05-181-1/+1
| | | | | | | I didn't want to do this, FNM_EXTGLOB is defined on 2.1.x, but Dir.glob returns the wrong value on Ruby less than 2.2.0. Checking for a case-insensitive FS seems too hard, so just check Ruby version Checking for a case-insensitive FS seems too hard, so just check Ruby version.
* Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_urlRafael Mendonça França2014-05-161-2/+10
|\ | | | | | | Allow custom asset host to be passed in asset_url
| * Improve documentation for asset_urlHubert Łępicki2014-05-081-1/+8
| | | | | | | | Updated CHANGELOG.md with entry about :host in asset_url
| * Allow custom asset host to be passed in asset_urlHubert Łępicki2014-05-081-1/+2
| |
* | We need an explicit returnRafael Mendonça França2014-05-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | If we don't return early Ruby will memoize the value of the prefix of the parent class what will make the subsequent searchs to not work as expected. If the early return we are avoiding the memoization. But when using the deprecated path we need to memoize the value, so we are not using early return for the deprecated path.
* | Refactoring the code to make consitional return explicitRafael Mendonça França2014-05-141-4/+9
| |
* | Follow the documentation guidelineRafael Mendonça França2014-05-141-1/+1
| |
* | Mark _prefix as nodocRafael Mendonça França2014-05-141-3/+2
| | | | | | | | These methods are private API.
* | ._prefix is private API so we should not recommend to override itRafael Mendonça França2014-05-141-2/+2
| |
* | Merge remote-tracking branch 'apotonick/simplify-prefixes'Rafael Mendonça França2014-05-141-15/+22
|\ \ | | | | | | | | | | | | | | | This is the rebased version of #15026 Closes #15026
| * | deprecate AbC:Base::parent_prefixes.Nick Sutterer2014-05-131-4/+16
| | | | | | | | | | | | | | | | | | rename ::_local_prefixes to ::local_prefixes to state the public attribute. document the latter. make ::local_prefixes private, test overriding it and remove documentation for overriding ::_parent_prefixes.
| * | simplify AC:ViewPaths::_prefixes. by making it recursively traversing up the ↵Nick Sutterer2014-05-131-15/+10
| | | | | | | | | | | | inheritance chain, classes can override local prefixes.
* | | Fix assertion order and :scissors: extra spacesCarlos Antonio da Silva2014-05-131-2/+1
| | |
* | | Merge pull request #15068 from josepjaume/patch-1Aaron Patterson2014-05-131-0/+2
|\ \ \ | | | | | | | | Dup options hash to prevent modifications
| * | | Dup options hash to prevent modificationsJosep Jaume Rey2014-05-131-0/+2
| |/ / | | | | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object.
* | | :cry::gun: use an empty hash for magical speed.Aaron Patterson2014-05-121-1/+5
| | | | | | | | | | | | | | | | | | For some reason, if the hash is empty, we choose "optimized" routes. I am not sure how or why optimized routes differ from regular routes. But, if we make sure the hash is empty, we get a nice speed improvement.
* | | use the helper method builder to construct helper methodsAaron Patterson2014-05-121-2/+6
| | |
* | | probably should not check in a raiseAaron Patterson2014-05-121-1/+0
| | |
* | | undo optimized calls until the builder object is finishedAaron Patterson2014-05-121-4/+3
| | |
* | | fix url_for with classesAaron Patterson2014-05-121-1/+1
| | |
* | | break each polymorphic type to it's own methodAaron Patterson2014-05-121-1/+5
|/ /
* | feature detect for FNM_EXTGLOB for older Ruby. Fixes #15053Aaron Patterson2014-05-101-5/+21
| |
* | use fnmatch to test for case insensitive file systemsAaron Patterson2014-05-091-4/+2
|/ | | | | | this is due to: https://bugs.ruby-lang.org/issues/5994
* Include label value in i18n attribute lookupJoshua Cody2014-05-061-2/+2
| | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post".
* Typo, grammar and textual changes [ci skip]Akshay Vishnoi2014-05-031-4/+5
|
* Form_tag_helper grammar fix [skip ci]Jon Atack2014-05-021-1/+1
|
* always use File.joinphoet2014-05-011-2/+2
|
* Add documentation to select_tag for :selected optionRizwan Reza2014-04-301-1/+5
|
* split nil / Hash cases in url_forAaron Patterson2014-04-301-4/+4
| | | | | | | this reduces the number of comparisons and method calls `url_for` requires. The nil case no longer calls `symbolize_keys`, we already know options is nil, so no more ||=, and since it is nil we already know that options[:host] will be nil too.
* rewrites the API docs of favicon_link_tag [ci skip]Xavier Noria2014-04-291-9/+16
| | | | Motivated by #14907.
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-04-271-0/+54
|\
| * [ci skip] Added example for number_field_tag methodZENATI YASSINE2014-04-191-0/+28
| |
| * [ci skip] Added example for date_field_tag methodZENATI YASSINE2014-04-191-0/+13
| |
| * [ci skip] Added example for email_field_tag methodZENATI YASSINE2014-04-191-0/+13
| |
* | Fix documentation of extract_handler_and_format_and_variant [ci skip]Prathamesh Sonpatki2014-04-261-1/+1
| |
* | Merge pull request #13335 from glorieux/favicon_link_tag_mimetypeRafael Mendonça França2014-04-221-3/+3
|\ \ | | | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
| * | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵glorieux2014-04-211-3/+3
| |/ | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
* / Add test for using ActionView::Helpers::FormHelper.label with block and htmlZachary Scott2014-04-221-0/+1
|/
* Remove wrapper div for inputs in button_toRafael Mendonça França2014-04-171-1/+1
| | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2
* Merge pull request #14738 from tilsammans/pull/11407Rafael Mendonça França2014-04-171-3/+5
|\ | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md
| * Remove wrapping div with inline styles for hidden form fields.Joost Baaij2014-04-141-3/+5
| | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.
* | [ci skip] Added examples for url_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for telephone_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for search_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for color_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | Merge pull request #14642 from tgxworld/fix_notifications_not_unsubscribingYves Senn2014-04-151-1/+2
|\ \ | | | | | | Fix subscriptions not being unsubscribed.
| * | Fix subscriptions not being unsubscribed.Guo Xiang Tan2014-04-141-1/+2
| | |
* | | `collection_check_boxes` respects `:index` option for the hidden filed name.Vasiliy Ermolovich2014-04-141-4/+13
| |/ |/| | | | | closes #14147
* | Merge pull request #14722 from maurogeorge/mg-readonly-collectionSantiago Pastorino2014-04-131-1/+1
|\ \ | | | | | | CollectionHelpers now accepts a readonly option
| * | CollectionHelpers now accepts a readonly optionMauro George2014-04-121-1/+1
| |/