Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | documentation fix | Gaurav Sharma | 2014-05-24 | 1 | -2/+2 |
| | |||||
* | update docs to include html id for select_tag | Omar Ismail | 2014-05-23 | 1 | -2/+2 |
| | |||||
* | Feature detect based on Ruby version. | Aaron Patterson | 2014-05-18 | 1 | -1/+1 |
| | | | | | | | I didn't want to do this, FNM_EXTGLOB is defined on 2.1.x, but Dir.glob returns the wrong value on Ruby less than 2.2.0. Checking for a case-insensitive FS seems too hard, so just check Ruby version Checking for a case-insensitive FS seems too hard, so just check Ruby version. | ||||
* | Merge pull request #15021 from hubertlepicki/allow_custom_host_in_asset_url | Rafael Mendonça França | 2014-05-16 | 1 | -2/+10 |
|\ | | | | | | | Allow custom asset host to be passed in asset_url | ||||
| * | Improve documentation for asset_url | Hubert Łępicki | 2014-05-08 | 1 | -1/+8 |
| | | | | | | | | Updated CHANGELOG.md with entry about :host in asset_url | ||||
| * | Allow custom asset host to be passed in asset_url | Hubert Łępicki | 2014-05-08 | 1 | -1/+2 |
| | | |||||
* | | We need an explicit return | Rafael Mendonça França | 2014-05-14 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | If we don't return early Ruby will memoize the value of the prefix of the parent class what will make the subsequent searchs to not work as expected. If the early return we are avoiding the memoization. But when using the deprecated path we need to memoize the value, so we are not using early return for the deprecated path. | ||||
* | | Refactoring the code to make consitional return explicit | Rafael Mendonça França | 2014-05-14 | 1 | -4/+9 |
| | | |||||
* | | Follow the documentation guideline | Rafael Mendonça França | 2014-05-14 | 1 | -1/+1 |
| | | |||||
* | | Mark _prefix as nodoc | Rafael Mendonça França | 2014-05-14 | 1 | -3/+2 |
| | | | | | | | | These methods are private API. | ||||
* | | ._prefix is private API so we should not recommend to override it | Rafael Mendonça França | 2014-05-14 | 1 | -2/+2 |
| | | |||||
* | | Merge remote-tracking branch 'apotonick/simplify-prefixes' | Rafael Mendonça França | 2014-05-14 | 1 | -15/+22 |
|\ \ | | | | | | | | | | | | | | | | This is the rebased version of #15026 Closes #15026 | ||||
| * | | deprecate AbC:Base::parent_prefixes. | Nick Sutterer | 2014-05-13 | 1 | -4/+16 |
| | | | | | | | | | | | | | | | | | | rename ::_local_prefixes to ::local_prefixes to state the public attribute. document the latter. make ::local_prefixes private, test overriding it and remove documentation for overriding ::_parent_prefixes. | ||||
| * | | simplify AC:ViewPaths::_prefixes. by making it recursively traversing up the ↵ | Nick Sutterer | 2014-05-13 | 1 | -15/+10 |
| | | | | | | | | | | | | inheritance chain, classes can override local prefixes. | ||||
* | | | Fix assertion order and :scissors: extra spaces | Carlos Antonio da Silva | 2014-05-13 | 1 | -2/+1 |
| | | | |||||
* | | | Merge pull request #15068 from josepjaume/patch-1 | Aaron Patterson | 2014-05-13 | 1 | -0/+2 |
|\ \ \ | | | | | | | | | Dup options hash to prevent modifications | ||||
| * | | | Dup options hash to prevent modifications | Josep Jaume Rey | 2014-05-13 | 1 | -0/+2 |
| |/ / | | | | | | | | | | `options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object. | ||||
* | | | :cry::gun: use an empty hash for magical speed. | Aaron Patterson | 2014-05-12 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | | | For some reason, if the hash is empty, we choose "optimized" routes. I am not sure how or why optimized routes differ from regular routes. But, if we make sure the hash is empty, we get a nice speed improvement. | ||||
* | | | use the helper method builder to construct helper methods | Aaron Patterson | 2014-05-12 | 1 | -2/+6 |
| | | | |||||
* | | | probably should not check in a raise | Aaron Patterson | 2014-05-12 | 1 | -1/+0 |
| | | | |||||
* | | | undo optimized calls until the builder object is finished | Aaron Patterson | 2014-05-12 | 1 | -4/+3 |
| | | | |||||
* | | | fix url_for with classes | Aaron Patterson | 2014-05-12 | 1 | -1/+1 |
| | | | |||||
* | | | break each polymorphic type to it's own method | Aaron Patterson | 2014-05-12 | 1 | -1/+5 |
|/ / | |||||
* | | feature detect for FNM_EXTGLOB for older Ruby. Fixes #15053 | Aaron Patterson | 2014-05-10 | 1 | -5/+21 |
| | | |||||
* | | use fnmatch to test for case insensitive file systems | Aaron Patterson | 2014-05-09 | 1 | -4/+2 |
|/ | | | | | | this is due to: https://bugs.ruby-lang.org/issues/5994 | ||||
* | Include label value in i18n attribute lookup | Joshua Cody | 2014-05-06 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post". | ||||
* | Typo, grammar and textual changes [ci skip] | Akshay Vishnoi | 2014-05-03 | 1 | -4/+5 |
| | |||||
* | Form_tag_helper grammar fix [skip ci] | Jon Atack | 2014-05-02 | 1 | -1/+1 |
| | |||||
* | always use File.join | phoet | 2014-05-01 | 1 | -2/+2 |
| | |||||
* | Add documentation to select_tag for :selected option | Rizwan Reza | 2014-04-30 | 1 | -1/+5 |
| | |||||
* | split nil / Hash cases in url_for | Aaron Patterson | 2014-04-30 | 1 | -4/+4 |
| | | | | | | | this reduces the number of comparisons and method calls `url_for` requires. The nil case no longer calls `symbolize_keys`, we already know options is nil, so no more ||=, and since it is nil we already know that options[:host] will be nil too. | ||||
* | rewrites the API docs of favicon_link_tag [ci skip] | Xavier Noria | 2014-04-29 | 1 | -9/+16 |
| | | | | Motivated by #14907. | ||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-04-27 | 1 | -0/+54 |
|\ | |||||
| * | [ci skip] Added example for number_field_tag method | ZENATI YASSINE | 2014-04-19 | 1 | -0/+28 |
| | | |||||
| * | [ci skip] Added example for date_field_tag method | ZENATI YASSINE | 2014-04-19 | 1 | -0/+13 |
| | | |||||
| * | [ci skip] Added example for email_field_tag method | ZENATI YASSINE | 2014-04-19 | 1 | -0/+13 |
| | | |||||
* | | Fix documentation of extract_handler_and_format_and_variant [ci skip] | Prathamesh Sonpatki | 2014-04-26 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #13335 from glorieux/favicon_link_tag_mimetype | Rafael Mendonça França | 2014-04-22 | 1 | -3/+3 |
|\ \ | | | | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. | ||||
| * | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵ | glorieux | 2014-04-21 | 1 | -3/+3 |
| |/ | | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market. | ||||
* / | Add test for using ActionView::Helpers::FormHelper.label with block and html | Zachary Scott | 2014-04-22 | 1 | -0/+1 |
|/ | |||||
* | Remove wrapper div for inputs in button_to | Rafael Mendonça França | 2014-04-17 | 1 | -1/+1 |
| | | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2 | ||||
* | Merge pull request #14738 from tilsammans/pull/11407 | Rafael Mendonça França | 2014-04-17 | 1 | -3/+5 |
|\ | | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md | ||||
| * | Remove wrapping div with inline styles for hidden form fields. | Joost Baaij | 2014-04-14 | 1 | -3/+5 |
| | | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy. | ||||
* | | [ci skip] Added examples for url_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for telephone_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for search_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for color_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | Merge pull request #14642 from tgxworld/fix_notifications_not_unsubscribing | Yves Senn | 2014-04-15 | 1 | -1/+2 |
|\ \ | | | | | | | Fix subscriptions not being unsubscribed. | ||||
| * | | Fix subscriptions not being unsubscribed. | Guo Xiang Tan | 2014-04-14 | 1 | -1/+2 |
| | | | |||||
* | | | `collection_check_boxes` respects `:index` option for the hidden filed name. | Vasiliy Ermolovich | 2014-04-14 | 1 | -4/+13 |
| |/ |/| | | | | | closes #14147 |