Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix documentation of extract_handler_and_format_and_variant [ci skip] | Prathamesh Sonpatki | 2014-04-26 | 1 | -1/+1 |
| | |||||
* | Merge pull request #13335 from glorieux/favicon_link_tag_mimetype | Rafael Mendonça França | 2014-04-22 | 1 | -3/+3 |
|\ | | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. | ||||
| * | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵ | glorieux | 2014-04-21 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market. | ||||
* | | Add test for using ActionView::Helpers::FormHelper.label with block and html | Zachary Scott | 2014-04-22 | 1 | -0/+1 |
|/ | |||||
* | Remove wrapper div for inputs in button_to | Rafael Mendonça França | 2014-04-17 | 1 | -1/+1 |
| | | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2 | ||||
* | Merge pull request #14738 from tilsammans/pull/11407 | Rafael Mendonça França | 2014-04-17 | 1 | -3/+5 |
|\ | | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md | ||||
| * | Remove wrapping div with inline styles for hidden form fields. | Joost Baaij | 2014-04-14 | 1 | -3/+5 |
| | | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy. | ||||
* | | [ci skip] Added examples for url_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for telephone_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for search_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | [ci skip] Added examples for color_field_tag method | ZENATI YASSINE | 2014-04-16 | 1 | -0/+13 |
| | | |||||
* | | Merge pull request #14642 from tgxworld/fix_notifications_not_unsubscribing | Yves Senn | 2014-04-15 | 1 | -1/+2 |
|\ \ | | | | | | | Fix subscriptions not being unsubscribed. | ||||
| * | | Fix subscriptions not being unsubscribed. | Guo Xiang Tan | 2014-04-14 | 1 | -1/+2 |
| | | | |||||
* | | | `collection_check_boxes` respects `:index` option for the hidden filed name. | Vasiliy Ermolovich | 2014-04-14 | 1 | -4/+13 |
| |/ |/| | | | | | closes #14147 | ||||
* | | Merge pull request #14722 from maurogeorge/mg-readonly-collection | Santiago Pastorino | 2014-04-13 | 1 | -1/+1 |
|\ \ | | | | | | | CollectionHelpers now accepts a readonly option | ||||
| * | | CollectionHelpers now accepts a readonly option | Mauro George | 2014-04-12 | 1 | -1/+1 |
| |/ | |||||
* / | Update documentation to use Rails.application instead | Marcel Morgan | 2014-04-13 | 1 | -1/+1 |
|/ | | | | | | | References to ``AppName::Application` removed in favour of ``Rails.application`` as generated with a new rails 4.1 app. [ci skip] | ||||
* | Change links to 37signals and svn blog to point to new destinations. [ci skip] | Vipul A M | 2014-04-12 | 1 | -1/+1 |
| | |||||
* | Do not overwrite selected and disabled attributes | Laura Paredes | 2014-03-30 | 1 | -2/+2 |
| | |||||
* | Fix date_select option overwriting html classes | Izumi Wong-Horiuchi | 2014-03-24 | 1 | -1/+1 |
| | | | | | with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting. | ||||
* | Digestor should just rely on the finder to know about the format and the ↵ | David Heinemeier Hansson | 2014-03-21 | 2 | -73/+32 |
| | | | | variant -- trying to pass it back in makes a mess of things (oh, and doesnt work) | ||||
* | Log the full path, including variant, that the digestor is trying to find | David Heinemeier Hansson | 2014-03-21 | 1 | -3/+4 |
| | |||||
* | Fix for digestor to consider variants for partials -- this still needs more ↵ | David Heinemeier Hansson | 2014-03-21 | 1 | -2/+2 |
| | | | | testing!! | ||||
* | Warning removed (...) interpreted as grouped expression | Arun Agrawal | 2014-03-20 | 1 | -1/+1 |
| | |||||
* | Reorder conditional logic | David Pedersen | 2014-03-18 | 1 | -10/+10 |
| | | | | | | According to the best practice that "unless not" and "unless else" is hard to follow logically the link_to_unless and link_to_if were reversed. | ||||
* | Merge pull request #12662 from nashby/include-hidden-collection | Rafael Mendonça França | 2014-03-15 | 1 | -3/+7 |
|\ | | | | | | | | | | | | | | | add include_hidden option to collection_check_boxes helper Conflicts: actionview/CHANGELOG.md actionview/test/template/form_collections_helper_test.rb | ||||
| * | add include_hidden option to collection_check_boxes helper | Vasiliy Ermolovich | 2013-10-27 | 1 | -3/+7 |
| | | |||||
* | | Clarify AV::Digestor.digest method signature docs and deprecation warning | Jeremy Kemper | 2014-03-15 | 1 | -22/+21 |
| | | |||||
* | | Fix the resolver cache and stop mutating the lookup_context | Rafael Mendonça França | 2014-03-14 | 2 | -11/+10 |
| | | | | | | | | | | Before we had a bug in the resolver cache so the disable_cache were not working when passing options to find | ||||
* | | Merge pull request #14329 from pch/digestor-lookup-fix | Rafael Mendonça França | 2014-03-14 | 6 | -27/+52 |
|\ \ | | | | | | | | | | Ensure LookupContext in Digestor selects correct variant | ||||
| * | | Introduce #with_formats_and_variants to prevent problems with mutating ↵ | Łukasz Strzałkowski | 2014-03-14 | 2 | -5/+10 |
| | | | | | | | | | | | | finder object | ||||
| * | | Rename _setup_options to _options_for_digest | Łukasz Strzałkowski | 2014-03-14 | 1 | -3/+3 |
| | | | |||||
| * | | Disable LookupContext's cache when looking for template | Łukasz Strzałkowski | 2014-03-14 | 1 | -2/+6 |
| | | | |||||
| * | | Don't pass hash as keys to #find method | Łukasz Strzałkowski | 2014-03-14 | 1 | -1/+1 |
| | | | |||||
| * | | Add variants to Template class | Łukasz Strzałkowski | 2014-03-14 | 3 | -12/+20 |
| | | | |||||
| * | | Don't create addition vars, use options[] directly | Łukasz Strzałkowski | 2014-03-13 | 1 | -7/+2 |
| | | | |||||
| * | | Ensure LookupContext in Digestor selects correct variant | Piotr Chmolowski | 2014-03-09 | 2 | -5/+18 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works. | ||||
* | | | Fix 'fields_for' doc typo. | Cakey | Buddy Magsipoc | 2014-03-10 | 1 | -2/+2 |
| | | | |||||
* | | | Enhance readability of ActionView DateHelper#distance_of_time_in_words | Kenny Meyer | 2014-03-09 | 1 | -4/+8 |
|/ / | | | | | | | | | | | | | Refactor numerical constants to module constants which give the numbers a contextual meaning. This commit aims to provide quicker understanding for part of the implementation of the DateHelper#distance_of_time_in_words method. | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-03-07 | 1 | -2/+8 |
|\ \ | | | | | | | | | | | | | Conflicts: guides/source/4_1_release_notes.md | ||||
| * | | Update doc for TagHelper. | Hendy Tanata | 2014-03-05 | 1 | -2/+8 |
| | | | |||||
* | | | Merge pull request #14285 from ↵ | Aaron Patterson | 2014-03-06 | 2 | -7/+3 |
|\ \ \ | | | | | | | | | | | | | | | | | sikachu/master-revert-render-body-remove-content-type Do note remove `Content-Type` when `render :body` | ||||
| * | | | Do note remove `Content-Type` when `render :body` | Prem Sichanugrist | 2014-03-05 | 2 | -7/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da. | ||||
* | | | | Introduce `Rails.gem_version` | Prem Sichanugrist | 2014-03-05 | 2 | -7/+19 |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`. | ||||
* | | | Variants in ActionView::Digestor | Piotr Chmolowski | 2014-03-04 | 2 | -14/+52 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Take variants into account when calculating template digests in ActionView::Digest. Digestor#digest now takes a hash as an argument to support variants and allow more flexibility in the future. Old-style arguments have been deprecated. Fixes #14242 | ||||
* | | | Use 1.9 style hash on docs [ci skip] | Carlos Antonio da Silva | 2014-03-04 | 1 | -1/+1 |
| | | | |||||
* | | | Simplify handling of defaults/options in button_tag | Carlos Antonio da Silva | 2014-03-04 | 1 | -4/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There's no need to rely on Active Support's Hash#reverse_merge for simple cases with default values, since we can just merge from the default rather than reverse merge from the options. This also avoids the creation of one extra hash object by moving to a Hash#merge! call. | ||||
* | | | remove private method and rewrite into more precise notation | Sergey Prikhodko | 2014-03-04 | 1 | -12/+12 |
| | | | |||||
* | | | rollback to private method | Sergey Prikhodko | 2014-03-03 | 1 | -5/+9 |
| | | | |||||
* | | | cleanup and move extracted method right into the helper | Sergey Prikhodko | 2014-03-03 | 1 | -9/+5 |
| | | |