aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* avoiding calling of #option_value_selected? two timesAkshay Vishnoi2013-11-251-1/+1
|
* _implied_layout_name should be privateRafael Mendonça França2013-11-191-9/+11
|
* Use the right indentationRafael Mendonça França2013-11-191-1/+1
|
* Renderer#_render_template should be privateRafael Mendonça França2013-11-191-7/+7
| | | | Closes #12831
* Improve readability of sentence in partial-renderer docs [ci skip]Mac Martine2013-11-191-1/+1
|
* Use `set_backtrace` instead of `@backtrace` in ActionView errorShimpei Makimoto2013-11-161-2/+2
|
* Merge pull request #12853 from joshjordan/masterRafael Mendonça França2013-11-151-1/+1
|\ | | | | Allocate one less object using html_safe during content_tag construction
| * Allocate one less object using html_safe during content_tag constructionJosh Jordan2013-11-141-1/+1
| |
* | Take Hash with options inside Array in #url_forAndrey Ognevsky2013-11-151-0/+2
|/
* Revert "Used Yield instead of block.call" -- this causes all of ↵David Heinemeier Hansson2013-11-141-2/+2
| | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd.
* Merge pull request #12889 from kuldeepaggarwal/speed_upsRafael Mendonça França2013-11-141-2/+2
|\ | | | | Used Yield instead of block.call
| * Used Yield instead of block.callKuldeep Aggarwal2013-11-151-2/+2
| |
* | Fix syntax error in atom_feed example [ci skip]Saulius Grigaliunas2013-11-131-1/+1
|/ | | | Builder's #tag! takes either String or Symbol as the first parameter
* Make the method name the first argumentRafael Mendonça França2013-11-091-7/+7
| | | | | This is the only argument that changes over the method calls so it is better to it be the first one
* Drop one more string allocationRafael Mendonça França2013-11-091-1/+3
|
* Merge pull request #12760 from pseidemann/masterYves Senn2013-11-091-1/+1
|\ | | | | fix simple_format escapes own output when sanitize is set to true
| * fix simple_format escapes own output when sanitize is set to truepseidemann2013-11-081-1/+1
| |
* | Extract common code from number helpers to new delegator method.Vipul A M2013-11-091-30/+13
| |
* | sub! can return nilArun Agrawal2013-11-071-1/+1
| | | | | | | | | | | | Revert "drop one more string allocation" This reverts commit 4d15661d6c46c86a62ee1fc358f4b3ef9dd9f2ea.
* | drop one more string allocationAaron Patterson2013-11-061-1/+1
| |
* | drop string allocations in the log subscriberAaron Patterson2013-11-061-2/+12
| |
* | Merge pull request #12788 from kylefritz/patch-1Rafael Mendonça França2013-11-061-2/+2
|/ | | | | | rdoc: favicon source shouldn't begin with a slash to reference asset pipeline resource [ci skip] Conflicts: actionview/lib/action_view/helpers/asset_tag_helper.rb
* Line up the comments for aestheticsDavid Heinemeier Hansson2013-11-031-5/+5
|
* Convert CDATA input to string before gsub'ingCarsten Zimmermann2013-10-291-1/+1
| | | | | Rails 3.2 API allowed arbitrary input for cdata_section; this change re-introduces the old behaviour.
* Remove warning of shadowing outer local variableRafael Mendonça França2013-10-271-2/+2
|
* Merge pull request #12636 from kongregate/dont_rescue_ExceptionsRafael Mendonça França2013-10-241-2/+2
|\ | | | | Avoid unnecessary catching of Exception instead of StandardError (conver...
| * Avoid unnecessary catching of Exception instead of StandardError (converting ↵stopdropandrew2013-10-241-2/+2
| | | | | | | | Exceptions into StandardErrors)
* | Merge pull request #10471 from andyw8/button_to_paramsRafael Mendonça França2013-10-241-0/+7
|\ \ | |/ |/| | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md
| * Add params option for button_toAndy Waite2013-09-181-0/+7
| | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes.
* | Merge pull request #12540 from wyaeld/bug/fix-recursive-digestRafael Mendonça França2013-10-161-6/+6
|\ \ | | | | | | | | | Ensure ActionView::Digestor.cache is correctly cleaned up
| * | add a new local variable to track if digests are being stored, to ensure the ↵Brad Murray2013-10-171-2/+2
| | | | | | | | | | | | cleanup works correctly
| * | update digestor code based on reviewBrad Murray2013-10-151-2/+2
| | |
| * | Ensure ActionView::Digest.cache is correctly cleaned up whenBrad Murray2013-10-151-6/+6
| | | | | | | | | | | | ActionView::Resolver.caching = false.
* | | Fix typo in form_helper.rbAdam Jahnke2013-10-161-1/+1
|/ /
* | Merge pull request #12491 from shamanime/patch-1Rafael Mendonça França2013-10-131-2/+2
|\ \ | | | | | | Fix wrong variable name used in the select_day method documentation
| * | Fix wrong variable name used in the select_day method documentationJefferson Queiroz Venerando2013-10-101-2/+2
| | | | | | | | | The variable name created in the example is `my_date`, the methods were using `my_time` instead.
* | | Change `map` to `map!` to save extra array creation on new arrayVipul A M2013-10-131-1/+1
|/ /
* | Fixed return strings in documentationJoseph Zidell2013-10-031-3/+3
| |
* | Fixed typo in documentationJoseph Zidell2013-10-031-3/+3
| |
* | Adds template dependencies rake task from cache_digests gem.Thomas von Deyen2013-09-262-0/+21
| | | | | | | | This adds the rake tasks `cache_digests:dependencies` and `cache_digests:nested_dependencies` from `cache_digests` gem.
* | Use the given name in html_options for the hidden field in ↵Angel N. Sciortino2013-09-241-1/+2
| | | | | | | | collection_check_boxes
* | Merge pull request #10773 from wangjohn/link_and_routing_optionsRafael Mendonça França2013-09-231-2/+3
| | | | | | | | Adding documentation and tests to ``polymorphic_url`` and ``link_to``
* | Fix some edge cases for AV `select` helper with `:selected` optionBogdan Gusiev2013-09-231-1/+2
| |
* | Expand select documentation to tell about the blockRafael Mendonça França2013-09-231-0/+9
| | | | | | | | [ci skip]
* | Ability to pass block to AV#select helperBogdan Gusiev2013-09-232-5/+6
| | | | | | | | | | | | | | | | Example: = select(report, "campaign_ids") do - available_campaigns.each do |c| %option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
* | handle `:namespace` form option in collection labelsVasiliy Ermolovich2013-09-222-1/+3
| |
* | Bust the template digest cache key when details are changedDaniel Schierbeck2013-09-191-1/+4
| | | | | | | | | | | | Since the lookup details will influence which template is resolved, they need to be included in the cache key -- otherwise two different templates may erroneously share the same digest value.
* | Merge pull request #12112 from adamniedzielski/fix-form-for-namespace-and-asRafael Mendonça França2013-09-121-1/+2
|\ \ | | | | | | | | | | | | | | | | | | form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md
| * | form_for - fix :namespace and :as options clashAdam Niedzielski2013-09-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | :as option should not overwrite :namespace option when generating html id attribute of the form element. id should be prefixed by specified namespace even if :as option is present Add test case showing the issue and code fixing it
* | | Merge pull request #11603 from ↵Rafael Mendonça França2013-09-121-2/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | jetthoughts/join_strings_instead_of_contactination Cleanup: replace String concatenation by joining for excerpt helper