aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-161-0/+1
| | | | This makes the behavior more consistent with `width` or `height` options
* Merge pull request #18845 from bogdan/remove-code-dups-in-action-viewRafael Mendonça França2015-02-112-33/+25
|\ | | | | Remove some code duplication in ActionView tags code
| * Remove code duplication in ActionView::Helpers::Tags::BaseBogdan Gusiev2015-02-112-33/+25
| |
* | Remove warning from ActionView::Helpers::Tags::TranslatorYuki Nishijima2015-02-081-1/+3
|/ | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
* Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-061-1/+1
| | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* Indicate link_to creates an anchor elementColin Rymer2015-02-061-2/+2
| | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip]
* Rename method to make explicit its intentionRafael Mendonça França2015-02-053-3/+3
| | | | call is too generic
* Use kwags to make the argument meaning explicitRafael Mendonça França2015-02-053-6/+6
|
* Use new hash syntaxRafael Mendonça França2015-02-051-1/+1
|
* Change the method visibilityRafael Mendonça França2015-02-051-2/+4
| | | | Thse methods are used only inside this class
* Only check if object respond_to to_model onceRafael Mendonça França2015-02-051-6/+2
|
* placeholder doesn't exist inside this contextRafael Mendonça França2015-02-051-2/+2
|
* Merge pull request #18647 from mcls/placeholderable-to-modelRafael Mendonça França2015-02-054-28/+47
|\ | | | | | | The `model_name` method should be called on `to_model`
| * Reduce duplication when generating translationsMaarten Claes2015-01-224-34/+47
| |
| * Convert with `to_model` before calling ActiveModel methods on `object`Maarten Claes2015-01-222-8/+14
| |
* | Partial template name does no more have to be a valid Ruby identifierAkira Matsuda2015-02-061-3/+2
| | | | | | | | because the partial renderer would not create an lvar per each template since c67005f221f102fe2caca231027d9b11cf630484
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-031-1/+0
| | | | | | | | onwards.
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846robertomiranda2015-01-312-2/+2
| | | | | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769
* | Add missing options to `datetime_select` [ci skip]yachibit2015-01-251-0/+2
|/
* Merge pull request #18546 from brainopia/action_view_renderRafael Mendonça França2015-01-221-2/+5
|\ | | | | A shortcut to setup controller environment
| * Support `:assigns` option when rendering with controllers/mailers.brainopia2015-01-221-2/+5
| |
* | Single instead of double quotes T.J. Schuck2015-01-201-2/+2
| | | | | | [ci skip]
* | Rewrite SanitizeHelper docsT.J. Schuck2015-01-201-77/+50
| |
* | Fix code formatting in sanitize docsT.J. Schuck2015-01-201-9/+11
| |
* | fix typo in number_field_tag documentation [ci skip]yuuji.yaginuma2015-01-191-2/+2
| |
* | Use existing constant for joining instead of '_'Prathamesh Sonpatki2015-01-181-1/+1
| |
* | nodoc ActionView::ModelNaming modulePrathamesh Sonpatki2015-01-181-1/+1
| | | | | | | | | | - Its only used by ActionView internals and not supposed to be used through public API.
* | Use option url: false to allow entries without a link tagDaniel Gomez de Souza2015-01-161-2/+3
|/
* Only use the `_before_type_cast` in the form when from user inputSean Griffin2015-01-141-2/+9
| | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values.
* Revert "Don't use the `_before_type_cast` version of attributes in the form"Sean Griffin2015-01-143-2/+12
| | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
* Don't use the `_before_type_cast` version of attributes in the formSean Griffin2015-01-143-12/+2
| | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523.
* Merge pull request #17676 from ↵Rafael Mendonça França2015-01-051-6/+8
|\ | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832
| * Fix I18n regression introduced by #13832Christopher Dell2014-11-191-6/+8
| | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used.
* | Remove version conditional for find_template_pathsRafael Mendonça França2015-01-041-18/+6
| | | | | | | | | | Now that we only support Ruby 2.2+ we don't need this conditional anymore
* | Remove unneeded `require 'as/deprecation'`claudiob2015-01-041-1/+0
| | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed.
* | Remove unneeded requiresRafael Mendonça França2015-01-041-1/+0
| | | | | | | | These requires were added only to change deprecation message
* | Change the default template handler from `ERB` to `Raw`.Rafael Mendonça França2015-01-042-8/+2
| | | | | | | | | | Files without a template handler in their extension will be rended using the raw handler instead of ERB.
* | Remove deprecated `AbstractController::Base::parent_prefixes`Rafael Mendonça França2015-01-041-19/+3
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-01-031-5/+5
|\ \
| * | Fix "Rendering" not to link to AV::Renderingclaudiob2014-12-251-5/+5
| | | | | | | | | | | | | | | | | | | | | The "Rendering" word in the titles is not meant to be a link to the documentation for ActionView::Rendering. [ci skip]
* | | Unsafe default translations should not be marked html_safeJustin Coyne2015-01-021-19/+9
| | | | | | | | | | | | | | | | | | Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257
* | | Follow up to #17973 [ci skip]Robin Dupret2015-01-021-9/+10
| | |
* | | Merge pull request #17974 from killthekitten/fix-render-blockRafael Mendonça França2015-01-021-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md
| * | | Make possible to use blocks with short version of render partialNikolay Shebanov2014-12-191-1/+1
| |/ /
* | | Merge pull request #17973 from maurogeorge/file_field_hidden_fieldRafael Mendonça França2015-01-022-0/+32
|\ \ \ | | | | | | | | | | | | Generate a hidden_tag when using a file_field
| * | | Add a hidden_field on the file_fieldMauro George2015-01-022-0/+30
|/ / / | | | | | | | | | | | | This will avoid a error be raised when the only input on the form is the `file_field`.
* | | Fixes simple missprint in docs for #cyle in text_helperBen Woodall2014-12-301-1/+1
| | |
* | | Tiny documentation fixes [ci skip]Robin Dupret2014-12-301-3/+4
| | |
* | | Merge pull request #18130 from claudiob/better-record-identifier-docRobin Dupret2014-12-301-18/+42
|\ \ \ | | | | | | | | Better docs for AV::RecordIdentifier [ci skip]
| * | | Better docs for AV::RecordIdentifierclaudiob2014-12-231-18/+42
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit intends to clarify the scope of ActionView::RecordIdentifier methods `dom_id` and `dom_class`. Most of the current documentation comes from da257eb8 (7 years ago) when the decoupling of ActionView, ActiveRecord and ActiveModel was not a concern. Since then, steps have been taken to reach such decoupling, especially 8ca17926 which duplicated ActionController::ModelNaming into ActionView::ModelNaming explaining that: > These are just a simple helpers for decoupling Active Model, so it does not > make sense to extract it to Active Support, but the point is to decouple also > Action View and Action Pack As of today, ActionView::RecordIdentifier only includes `dom_id` and `dom_class` so it makes sense to explicitly document those two methods, and leaving the details of helpers like `div_for` in the corresponding files. Moreover, I think it's important to mention in the documentation that ActionView::RecordIdentifier **does not strictly depend on the ActiveRecord API**: any class `Post` implementing `post.to_key` and `post.model_name.param_key` will work. [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 06:27:59 +0000