| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
Accept lambda as child_index option in #fields_for method
|
| | | |
|
| |/ |
|
| |\
| |
| | |
correct output of auto_discovery_link_tag [ci skip]
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
4.2.1 introduced a change to the way `translate`/`t` works with an
option of `default: [[]]`. In 4.2.0, this would give a default value of
`[]`, but in 4.2.1, it leads to a missing translation.
`default: [[]]` is again allowed for cases where a default of `[]` is
needed.
This addresses GitHub issue 19640.
|
| |/ |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/ruby/ruby/pull/579 - there is a new optimization
since ruby 2.2
Previously regexp patterns were faster (since a string was converted to
regexp underneath anyway). But now string patterns are faster and
better reflect the purpose.
Benchmark.ips do |bm|
bm.report('regexp') { 'this is ::a random string'.gsub(/::/, '/') }
bm.report('string') { 'this is ::a random string'.gsub('::', '/') }
bm.compare!
end
# string: 753724.4 i/s
# regexp: 501443.1 i/s - 1.50x slower
|
| | |
|
| |\
| |
| | |
[ci skip] Unify the code comment in ActionView::Renderer#render_template...
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| | |
Conflicts:
guides/source/4_0_release_notes.md
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
No need to merge hashes when simply setting options does the job.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous change 92a3c8dcdf174dab5e8759031b6bbe6cd891fe3c improved
this example, but calling .create + #valid? ends up running validations
twice, and we don't want to showcase that.
Lets use the normal use case of building a new object and calling #save
on it, which is what a basic scaffold with Active Record does.
[ci skip]
|
| | | |
|
| | |
| |
| |
| | |
Strip nils out of default translations. Fixes #19419
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This logic was just doing duplicated work, since the button_to helper
relies on tag/content_tag to generate the button html, which already
handles all boolean attributes it knows about.
The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Prevents double escaping errors, such as "&" becoming "&".
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
fix ActionView::Template::Error when using Streaming with capture.
|
| | |/
| |
| |
| | |
can't acquire a encoding from StreamingBuffer. fixes #12001
|
| | | |
|
| |/
|
|
|
| |
_generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we
should be able to move it where it is used in AV::Routing
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous version of rails(4.2.0) you can pass objects
to the default option of translation helper.
For example:
```ruby
t('foo', default: 1)
```
But on rails 4.2.1 version this kind of use stopped to work,
because started only to accept String types.
Now with this fix we can use orther value types on this
helper again.
|
| | |
|
| |\
| |
| |
| |
| | |
Mession/fix_test_dependency_of_erb_template_partial_with_layout
Fix dependency tracker bug
|
| | | |
|
| |\ \
| |/
|/| |
Merge multi_fetch_fragments.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Collections can take advantage of `multi_read` if they render one template
and their partials begin with a cache call.
The cache call must correspond to either what the collections elements are
rendered as, or match the inferred name of the partial.
So with a notifications/_notification.html.erb template like:
```ruby
<% cache notification %>
<%# ... %>
<% end %>
```
A collection would be able to use `multi_read` if rendered like:
```ruby
<%= render @notifications %>
<%= render partial: 'notifications/notification', collection: @notifications, as: :notification %>
```
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Makes caching a collection of template partials faster using `read_multi`
on the Rails cache store.
Some caching implementations have optimized `read_multi` so we don't have
to check in the cache store for every template.
|
| |\ \
| | |
| | | |
move cache_digests rake methods into their own namespace
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
mail_to helper method fix
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
when mail_to generate blank options for any passed options(cc, bcc, body, subject)
then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
Rename default_form_builder to avoid collision
|
| | |/ / / |
|
| | | | |
| | | |
| | | |
| | | | |
The 'selected' option is not doing what it should do.
The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
|
| |\ \ \ \
| | | | |
| | | | | |
Remove RecordTagHelper
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been
extracted to an external gem (source currently lives at
todd/record_tag_helper). Removal notices have also been added for anyone
upgrading that use the extracted methods.
|
