aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Perf optimization for `url_for` called w/ Hashschneems2014-08-141-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmarking the existing code: ```ruby { :only_path => options[:host].nil? }.merge!(options.symbolize_keys)) ``` Against optimized code, that does not require a new hash or a merge: ```ruby options = options.symbolize_keys options[:only_path] = options[:host].nil? unless options.key?(:only_path) options ``` We see a statistically significant performance gain: ![](https://www.dropbox.com/s/onocpc0zfw4kjxl/Screenshot%202014-08-14%2012.45.30.png?dl=1) Updated to not mutate incoming parameters
| * | | Merge pull request #16438 from agrobbin/input-placeholder-i18nJeremy Kemper2014-08-143-0/+40
| |\ \ \ | | | | | | | | | | Add I18n support for `:placeholder` HTML option is passed to form fields
| | * | | add I18n support for `:placeholder` HTML option is passed to form fieldsAlex Robbin2014-08-123-0/+40
| | | | |
| * | | | Missing ActiveSupport require for calling String#firstAkira Matsuda2014-08-141-0/+1
| |/ / /
* | | | Prepare for partial release.Kasper Timm Hansen2014-08-171-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Default to Rails::DeprecatedSanitizer in ActionView::Helpers::SanitizeHelper. - Add upgrade notes. - Add sanitizer to new applications Gemfiles. - Remove 'rails-dom-testing' as a dependency.
* | | | Merge branch 'master' into loofahRafael Mendonça França2014-08-1215-154/+194
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/CHANGELOG.md actionpack/test/controller/integration_test.rb actionview/CHANGELOG.md
| * | | defined? should actually work in current implementationAkira Matsuda2014-08-071-9/+0
| | | | | | | | | | | | | | | | So this trick is not needed to be documented anymore.
| * | | Fixed #select form builder helper to support block with html outputBogdan Gusiev2014-08-051-1/+1
| | |/ | |/|
| * | don't access named routes internalsAaron Patterson2014-07-301-1/+1
| | | | | | | | | | | | just ask whether or not the route is defined
| * | Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-301-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
| * | docs, cleanup mixed indents within `form_options_helper.rb` RDoc.Yves Senn2014-07-291-81/+81
| | | | | | | | | | | | | | | | | | | | | [ci skip] This fixes the broken code block rendering and indents the examples within the parameter list.
| * | Fix that render layout should also be picked up by the template dependency ↵David Heinemeier Hansson2014-07-251-4/+10
| | | | | | | | | | | | tracker, but only half-ways. You can add that layout option on the same render call, and both templates should be added to the dependency tree. But thats going to require a more serious rework of the tracker. Please do help fix this part of it too. For now, render layout needs to be on its own line.
| * | marking private methods which dont work if called on their own anywaysEugene Gilburg2014-07-182-1/+5
| | |
| * | small refactors to actionview renderersEugene Gilburg2014-07-183-16/+15
| | |
| * | Prefer to pass block when logging.Guo Xiang Tan2014-07-181-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
| * | docs, `select` and friends with `multiple=true` include a blank string.Yves Senn2014-07-171-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Jonas Baumann & Yves Senn] The submitted params from a select with `multiple: true` look as follows: ``` {post: {category: [""]}} {post: {category: ["", "Category 1", "Category 2"]}} ``` This is a follow up to #1552.
| * | Fix broken list formatting [ci skip]noinkling2014-07-171-5/+5
| | |
| * | Use &= instead of select with include?Rafael Mendonça França2014-07-161-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The performance is almost the same with both implementations but this is clear. Before this patch: Calculating ------------------------------------- small erb template 1452 i/100ms ------------------------------------------------- small erb template 17462.1 (±13.3%) i/s - 85668 in 5.031395s .Calculating ------------------------------------- small erb template with 1 partial 887 i/100ms ------------------------------------------------- small erb template with 1 partial 8899.6 (±18.8%) i/s - 42576 in 5.009453s .Calculating ------------------------------------- small erb template with 2 partials 666 i/100ms ------------------------------------------------- small erb template with 2 partials 6821.5 (±8.8%) i/s - 33966 in 5.020791s After the patch: Calculating ------------------------------------- small erb template 1479 i/100ms ------------------------------------------------- small erb template 15956.6 (±7.6%) i/s - 79866 in 5.036001s .Calculating ------------------------------------- small erb template with 1 partial 841 i/100ms ------------------------------------------------- small erb template with 1 partial 9242.2 (±6.9%) i/s - 46255 in 5.029497s .Calculating ------------------------------------- small erb template with 2 partials 615 i/100ms ------------------------------------------------- small erb template with 2 partials 6524.7 (±6.8%) i/s - 32595 in 5.020456s You can find the benchmark code at https://gist.github.com/rafaelfranca/dee31120cfdb1ddc3b56
| * | Merge pull request #15917 from luke-gru/actionview_perfRafael Mendonça França2014-07-161-1/+1
| |\ \ | | | | | | | | | | | | remove Set.new from DetailsKey::get, impacts rendering overhead
| | * | remove Set.new from DetailsKey::get, impacts rendering overhead performanceLuke Gruber2014-06-251-1/+1
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | Using ruby-prof, I noticed that Set#add had the largest 'self time' percentage (5% of the overall time spent rendering) when benchmarking the rendering of a small cached ERB template that was 3 lines long. It turns out it was from this line. I don't believe the Set is necessary, either. Removing this line increases the rendering ips using Benchmark::ips accordingly.
| * | Fix typo on the variable nameRafael Mendonça França2014-07-161-8/+8
| | |
| * | Document the PartialIteration objectRafael Mendonça França2014-07-161-3/+9
| | |
| * | Build only one PartialIteration object for loopRafael Mendonça França2014-07-161-11/+18
| | |
| * | No need to have a file to PartialIteration classRafael Mendonça França2014-07-161-1/+17
| | | | | | | | | | | | This class is only used on the PartialRenderer.
| * | Added PartialIteration class used when rendering collectionsJoel Junström2014-07-161-13/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
| * | Merge pull request #16175 from skorks/log_digestor_as_debugRafael Mendonça França2014-07-151-1/+1
| |\ \ | | | | | | | | Log digest as :debug instead of :info
| | * | Log digest as :debug instead of :infoAlan Skorkin2014-07-151-1/+1
| | | |
| * | | Merge pull request #16161 from jpawlyn/masterAndrew White2014-07-151-1/+1
| |\ \ \ | | |/ / | |/| | Fix empty host for an asset url when asset_host proc returns nil
| | * | Return an absolute instead of relative path from an asset url in the case of ↵Jolyon Pawlyn2014-07-151-1/+1
| | | | | | | | | | | | | | | | the `asset_host` proc returning nil
| * | | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip]Santosh Wadghule2014-07-141-1/+1
| |/ /
* | | Use the plugin API to the getter and settersRafael Mendonça França2014-07-151-4/+4
| | | | | | | | | | | | | | | To avoid having to redefine these methods on the deprecated plugin we should be using the sanitizer_vendor API.
* | | We don't need loofah for the assertionsRafael Mendonça França2014-07-151-2/+1
| | | | | | | | | | | | We can just use nokogiri
* | | Merge pull request #11218 from kaspth/loofah-integrationRafael Mendonça França2014-07-109-1868/+71
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md
| * | Make output_buffers used in tests be utf-8 encoded. Fixing unknown encoding ↵Timm2014-06-161-1/+3
| | | | | | | | | | | | ASCII-8BIT test errors.
| * | Don't splat arguments to allowed tags or attributes.Timm2014-06-161-2/+2
| | |
| * | Change sanitizer_vendor to just be a method and reword documentation.Timm2014-06-161-4/+5
| | |
| * | Revert some stuff to use the new sanitizers.Timm2014-06-161-6/+6
| | |
| * | Remove html-scanner and its tests.Timm2014-06-167-1772/+0
| | |
| * | Remove deprecation notice.Timm2014-06-161-2/+0
| | |
| * | Add a layer of indirection making sanitizers pluggable.Timm2014-06-163-3/+23
| | |
| * | Delegate allowed tags and attributes setting to HTML::WhiteListSanitizer.Timm2014-06-161-4/+4
| | |
| * | Changed configuration documentation to no longer state it replaces a Set.Timm2014-06-161-2/+2
| | |
| * | Deprecate configurations and use allowed_tags and allowed_attributes on ↵Timm2014-06-161-99/+22
| | | | | | | | | | | | WhiteListSanitizer.
| * | Made deprecation messages in sanitize_helper more clear.Timm2014-06-161-3/+3
| | |
| * | Completed integration of rails-html-sanitizer in SanitizeHelper. Deprecated ↵Timm2014-06-163-294/+19
| | | | | | | | | | | | protocol_separator accessors and bad_tags=.
| * | Updated html-scanner deprecation message.Timm2014-06-161-1/+1
| | |
| * | Support for changes in SelectorAssertions.Timm2014-06-161-5/+6
| | |
| * | Required rails-dom-testing in test_case.rbTimm2014-06-161-1/+3
| | |
| * | Removed ActionView::Assertions. Getting ready to exchange with ↵Timm2014-06-163-540/+0
| | | | | | | | | | | | Rails::Dom::Testing::Assertions.
| * | Silenced deprecation warnings in the tests. Documentation uses present ↵Timm2014-06-161-3/+4
| | | | | | | | | | | | tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 02:04:07 +0000