Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #19421 from jcoyne/translate_defaults_with_nil | Rafael Mendonça França | 2015-03-20 | 1 | -1/+1 |
| | | | | Strip nils out of default translations. Fixes #19419 | ||||
* | Remove additional handling of boolean attributes on button to helper | Carlos Antonio da Silva | 2015-03-18 | 1 | -30/+0 |
| | | | | | | | | This logic was just doing duplicated work, since the button_to helper relies on tag/content_tag to generate the button html, which already handles all boolean attributes it knows about. The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b. | ||||
* | [ci skip] correct output of select | Kuldeep Aggarwal | 2015-03-13 | 1 | -15/+15 |
| | |||||
* | [CI SKIP] Correct output of options_for_select | Akshay Vishnoi | 2015-03-13 | 1 | -5/+5 |
| | |||||
* | Let strip_tags leave HTML escaping to Rails. | Kasper Timm Hansen | 2015-03-10 | 1 | -1/+1 |
| | | | | Prevents double escaping errors, such as "&" becoming "&". | ||||
* | don't need to rescue Exception in this case | Aaron Patterson | 2015-03-05 | 1 | -1/+1 |
| | |||||
* | [ci skip] Delete excess white in documentation | Anton Davydov | 2015-03-05 | 1 | -1/+1 |
| | |||||
* | [ci skip] Add information about sanitize option in TextHelper#highlight | Anton Davydov | 2015-03-05 | 1 | -1/+6 |
| | |||||
* | Merge pull request #19144 from y-yagi/fix_streaming_buffer | Rafael Mendonça França | 2015-03-04 | 1 | -1/+3 |
|\ | | | | | fix ActionView::Template::Error when using Streaming with capture. | ||||
| * | fix ActionView::Template::Error when using Streaming with capture. | yuuji.yaginuma | 2015-03-01 | 1 | -1/+3 |
| | | | | | | | | can't acquire a encoding from StreamingBuffer. fixes #12001 | ||||
* | | Fix spelling [ci skip] | Yu Haidong | 2015-03-04 | 1 | -8/+8 |
| | | |||||
* | | move _generate_paths_by_default to where it is used | Aaron Patterson | 2015-03-01 | 1 | -0/+6 |
|/ | | | | | _generate_paths_by_default wasn't used in AD::Routing::UrlFor, so we should be able to move it where it is used in AV::Routing | ||||
* | Fix regression when passing a value different of String. | Ulisses Almeida | 2015-02-26 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again. | ||||
* | Fix typos in ActionView::Helpers::FormBuilder comment [ci skip] | Yu Haidong | 2015-02-26 | 1 | -1/+2 |
| | |||||
* | Merge pull request #19074 from ↵ | Rafael Mendonça França | 2015-02-25 | 1 | -4/+15 |
|\ | | | | | | | | | Mession/fix_test_dependency_of_erb_template_partial_with_layout Fix dependency tracker bug | ||||
| * | Fix dependency tracker bug | Juho Leinonen | 2015-02-25 | 1 | -4/+15 |
| | | |||||
* | | Merge pull request #18948 from kaspth/automatic-collection-caching | Rafael Mendonça França | 2015-02-25 | 6 | -2/+145 |
|\ \ | |/ |/| | Merge multi_fetch_fragments. | ||||
| * | Collections automatically cache and fetch partials. | Kasper Timm Hansen | 2015-02-21 | 4 | -2/+70 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ``` | ||||
| * | Merge multi_fetch_fragments. | Kasper Timm Hansen | 2015-02-20 | 4 | -2/+77 |
| | | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template. | ||||
* | | Merge pull request #17069 from modosc/master | Rafael Mendonça França | 2015-02-20 | 1 | -7/+9 |
|\ \ | | | | | | | move cache_digests rake methods into their own namespace | ||||
| * | | move cache_digests rake methods into their own namespace | jonathan schatz | 2014-09-26 | 1 | -7/+9 |
| | | | |||||
* | | | Fix cache_helper comment ERB | Anthony Dmitriyev | 2015-02-20 | 1 | -2/+2 |
| | | | |||||
* | | | Merge pull request #17143 from kuldeepaggarwal/fix-mailTo | Rafael Mendonça França | 2015-02-20 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | mail_to helper method fix | ||||
| * | | | do not generate blank options in mailTo | Kuldeep Aggarwal | 2014-10-02 | 1 | -2/+3 |
| | | | | | | | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options. | ||||
* | | | | Use a name that better reflect the return value | Rafael Mendonça França | 2015-02-20 | 1 | -2/+2 |
| | | | | |||||
* | | | | Merge pull request #17138 from jpcody/rename_default_form_builder | Rafael Mendonça França | 2015-02-20 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | | | | | | Rename default_form_builder to avoid collision | ||||
| * | | | | Rename default_form_builder to avoid collision | Joshua Cody | 2014-10-01 | 1 | -2/+2 |
| |/ / / | |||||
* | | | | Corrects the API to method select_tag | Leandro Nunes | 2015-02-20 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method | ||||
* | | | | Merge pull request #18411 from todd/extract_record_tag_helper | Rafael Mendonça França | 2015-02-18 | 2 | -99/+14 |
|\ \ \ \ | | | | | | | | | | | Remove RecordTagHelper | ||||
| * | | | | Remove RecordTagHelper, add extraction notices | Todd Bealmear | 2015-02-16 | 2 | -99/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods. | ||||
* | | | | | Add nodoc to private constant [ci skip] | Rafael Mendonça França | 2015-02-18 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #18970 from nithinbekal/local-assigns-doc | Rafael Mendonça França | 2015-02-18 | 1 | -0/+8 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | Add documentation for local_assigns [ci skip] | ||||
| * | | | | | Add documentation for local_assigns [ci skip] | Nithin Bekal | 2015-02-17 | 1 | -0/+8 |
| |/ / / / | |||||
* | | | | | Improve documentation of local_assigns | Rafael Mendonça França | 2015-02-18 | 1 | -7/+13 |
| | | | | | |||||
* | | | | | Merge pull request #15700 from maurogeorge/guides-local_assigns | Rafael Mendonça França | 2015-02-18 | 1 | -0/+7 |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | Add docs about local_assigns on guides | ||||
| * | | | | Add RDoc about local_assigns | Mauro George | 2014-06-13 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | | Allow to pass a string value to size option in `image_tag` and `video_tag` | Mehdi Lahmam | 2015-02-16 | 1 | -0/+1 |
| |_|_|/ |/| | | | | | | | | | | | This makes the behavior more consistent with `width` or `height` options | ||||
* | | | | Merge pull request #18845 from bogdan/remove-code-dups-in-action-view | Rafael Mendonça França | 2015-02-11 | 2 | -33/+25 |
|\ \ \ \ | | | | | | | | | | | Remove some code duplication in ActionView tags code | ||||
| * | | | | Remove code duplication in ActionView::Helpers::Tags::Base | Bogdan Gusiev | 2015-02-11 | 2 | -33/+25 |
| | | | | | |||||
* | | | | | Remove warning from ActionView::Helpers::Tags::Translator | Yuki Nishijima | 2015-02-08 | 1 | -1/+3 |
|/ / / / | | | | | | | | | | | | | | | | | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute? | ||||
* | | | | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_for | Miklos Fazekas | 2015-02-06 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model) | ||||
* | | | | Indicate link_to creates an anchor element | Colin Rymer | 2015-02-06 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip] | ||||
* | | | | Rename method to make explicit its intention | Rafael Mendonça França | 2015-02-05 | 3 | -3/+3 |
| | | | | | | | | | | | | | | | | call is too generic | ||||
* | | | | Use kwags to make the argument meaning explicit | Rafael Mendonça França | 2015-02-05 | 3 | -6/+6 |
| | | | | |||||
* | | | | Use new hash syntax | Rafael Mendonça França | 2015-02-05 | 1 | -1/+1 |
| | | | | |||||
* | | | | Change the method visibility | Rafael Mendonça França | 2015-02-05 | 1 | -2/+4 |
| | | | | | | | | | | | | | | | | Thse methods are used only inside this class | ||||
* | | | | Only check if object respond_to to_model once | Rafael Mendonça França | 2015-02-05 | 1 | -6/+2 |
| | | | | |||||
* | | | | placeholder doesn't exist inside this context | Rafael Mendonça França | 2015-02-05 | 1 | -2/+2 |
| | | | | |||||
* | | | | Merge pull request #18647 from mcls/placeholderable-to-model | Rafael Mendonça França | 2015-02-05 | 4 | -28/+47 |
|\ \ \ \ | | | | | | | | | | | | | | | | The `model_name` method should be called on `to_model` | ||||
| * | | | | Reduce duplication when generating translations | Maarten Claes | 2015-01-22 | 4 | -34/+47 |
| | | | | |