| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Currently `:api:` tag has leaked on the doc directly since RDoc doesn't
support `:api:` tag directive.
http://api.rubyonrails.org/v5.1/classes/AbstractController/Rendering.html
So `:api: private` doesn't work as expected. We are using `:nodoc:` for
the purpose.
Related #13989.
|
|\
| |
| | |
Do not pass an instance variable to a private method
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`ActionView::Helpers::Tags::Base` has `@object` and
all passed arguments for
* `#value`
* `#value_before_type_cast`
* `#value_came_from_user?`
are `@object`, so we do not need to pass arguments in this case.
|
| |
| |
| |
| | |
We do not use double assign since 61f92f8bc5fa0b486fc56f249fa23f1102e79759.
|
| |
| |
| |
| | |
`def a() x = x = 1; end` warns since Ruby 2.5 (r59585)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Don't use remove_method or remove_possible_method just before a new
definition: at best the purpose is unclear, and at worst it creates a
race condition.
Instead, prefer redefine_method when practical, and
silence_redefinition_of_method otherwise.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Follow up of #30213
|
| | |
|
|\ \
| | |
| | |
| | | |
Do not generate default alt text for images
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
|
|/ /
| |
| |
| | |
Add back a bit about a resource oriented style of routing.
|
|\ \
| | |
| | | |
Add code formatting and minor grammar clarifications
|
| | |
| | |
| | | |
[ci skip]
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
refs: https://github.com/rails/rails/pull/30161
```
$ echo "+@size+" | rdoc --pipe
<p>+@size+</p>
$ echo "<tt>@size</tt>" | rdoc --pipe
<p><code>@size</code></p>
```
[ci skip]
|
| |
| |
| |
| |
| | |
The `@` ivar format doesn’t work with RDoc's `+` code formatting; needs `<tt>`.
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Extend image_tag to accept ActiveStorage's Attachments and Variants
* Flip resolve_image_source around
* Add tests for the new use-cases of image_tag
* Remove the higher-level test
* Update image_tag documentation
* Add error states into the test suite
* Re-raise polymorhic_url's NoMethodError as ArgumentError
* delegate_missing_to will raise DelegationError instead of NoMethodError
|
|\ \
| | |
| | | |
Add Active Storage to Rails
|
| | |
| | |
| | |
| | | |
FormHelper includes FormTagHelper so we don't need to define two methods
|
| | |
| | |
| | |
| | | |
Also make sure file_field doesn't mutate the original options passed in.
|
| | |
| | |
| | |
| | |
| | | |
When Active Storage is not loaded and direct_upload is used on
file_field_tag we should not raise an exception.
|
| | | |
|
| | |
| | |
| | |
| | | |
helper into actionview
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Explicitly pass a destructed array to the delegate method.
Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
|
|\ \
| | |
| | | |
Use frozen string literal in actionview/
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Delegate respond_to? in ActionView::Helpers::ControllerHelper
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since methods defined in the controller helper are mostly delegated to
the controller, delegate respond_to? as well, so that for example
`respond_to?(:params)` behaves as expected.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
|
| |/
| |
| |
| | |
removed already
|
|/ |
|
| |
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |\
| | |
| | |
| | | |
Enforce frozen string in Rubocop
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | | |
| | | |
| | | |
| | | | |
Plus a couple of related ActionPack patches.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Includes two external changes because they're referenced within the ActiveModel test suite.
|
| |\ \ \
| | |_|/
| |/| |
| | | | |
Add srcset option to image_tag helper
|
| |/ / |
|
|/ / |
|
|/ |
|