aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Include label value in i18n attribute lookupJoshua Cody2014-05-061-2/+2
| | | | | | | | | | | | | | | | | | | | | Previously, only the object and method name from the label tag were used when looking up the translation for a label. If a value is given for the label, this ought to be additionally used. The following: # form.html.erb <%= form_for @post do |f| %> <%= f.label :type, value: "long" %> <% end %> # en.yml en: activerecord: attributes: post/long: "Long-form Post" Used to simply return "long", but now it will return "Long-form Post".
* Typo, grammar and textual changes [ci skip]Akshay Vishnoi2014-05-031-4/+5
|
* Form_tag_helper grammar fix [skip ci]Jon Atack2014-05-021-1/+1
|
* always use File.joinphoet2014-05-011-2/+2
|
* Add documentation to select_tag for :selected optionRizwan Reza2014-04-301-1/+5
|
* split nil / Hash cases in url_forAaron Patterson2014-04-301-4/+4
| | | | | | | this reduces the number of comparisons and method calls `url_for` requires. The nil case no longer calls `symbolize_keys`, we already know options is nil, so no more ||=, and since it is nil we already know that options[:host] will be nil too.
* rewrites the API docs of favicon_link_tag [ci skip]Xavier Noria2014-04-291-9/+16
| | | | Motivated by #14907.
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-04-271-0/+54
|\
| * [ci skip] Added example for number_field_tag methodZENATI YASSINE2014-04-191-0/+28
| |
| * [ci skip] Added example for date_field_tag methodZENATI YASSINE2014-04-191-0/+13
| |
| * [ci skip] Added example for email_field_tag methodZENATI YASSINE2014-04-191-0/+13
| |
* | Fix documentation of extract_handler_and_format_and_variant [ci skip]Prathamesh Sonpatki2014-04-261-1/+1
| |
* | Merge pull request #13335 from glorieux/favicon_link_tag_mimetypeRafael Mendonça França2014-04-221-3/+3
|\ \ | | | | | | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
| * | Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to ↵glorieux2014-04-211-3/+3
| |/ | | | | | | | | | | | | | | image/x-icon. Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon, registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products. The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
* / Add test for using ActionView::Helpers::FormHelper.label with block and htmlZachary Scott2014-04-221-0/+1
|/
* Remove wrapper div for inputs in button_toRafael Mendonça França2014-04-171-1/+1
| | | | Related with cbb917455f306cf5818644b162f22be09f77d4b2
* Merge pull request #14738 from tilsammans/pull/11407Rafael Mendonça França2014-04-171-3/+5
|\ | | | | | | | | | | | | Remove wrapping div with inline styles for hidden form fields. Conflicts: actionview/CHANGELOG.md
| * Remove wrapping div with inline styles for hidden form fields.Joost Baaij2014-04-141-3/+5
| | | | | | | | | | | | We are dropping HTML 4.01 and XHTML strict compliance since input tags directly inside a form are valid HTML5, and the absense of inline styles help in validating for Content Security Policy.
* | [ci skip] Added examples for url_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for telephone_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for search_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | [ci skip] Added examples for color_field_tag methodZENATI YASSINE2014-04-161-0/+13
| |
* | Merge pull request #14642 from tgxworld/fix_notifications_not_unsubscribingYves Senn2014-04-151-1/+2
|\ \ | | | | | | Fix subscriptions not being unsubscribed.
| * | Fix subscriptions not being unsubscribed.Guo Xiang Tan2014-04-141-1/+2
| | |
* | | `collection_check_boxes` respects `:index` option for the hidden filed name.Vasiliy Ermolovich2014-04-141-4/+13
| |/ |/| | | | | closes #14147
* | Merge pull request #14722 from maurogeorge/mg-readonly-collectionSantiago Pastorino2014-04-131-1/+1
|\ \ | | | | | | CollectionHelpers now accepts a readonly option
| * | CollectionHelpers now accepts a readonly optionMauro George2014-04-121-1/+1
| |/
* / Update documentation to use Rails.application insteadMarcel Morgan2014-04-131-1/+1
|/ | | | | | | References to ``AppName::Application` removed in favour of ``Rails.application`` as generated with a new rails 4.1 app. [ci skip]
* Change links to 37signals and svn blog to point to new destinations. [ci skip]Vipul A M2014-04-121-1/+1
|
* Do not overwrite selected and disabled attributesLaura Paredes2014-03-301-2/+2
|
* Fix date_select option overwriting html classesIzumi Wong-Horiuchi2014-03-241-1/+1
| | | | | with_css_classes: true option overwrites other html classes. Concatenate day month and year classes rather than overwriting.
* Digestor should just rely on the finder to know about the format and the ↵David Heinemeier Hansson2014-03-212-73/+32
| | | | variant -- trying to pass it back in makes a mess of things (oh, and doesnt work)
* Log the full path, including variant, that the digestor is trying to findDavid Heinemeier Hansson2014-03-211-3/+4
|
* Fix for digestor to consider variants for partials -- this still needs more ↵David Heinemeier Hansson2014-03-211-2/+2
| | | | testing!!
* Warning removed (...) interpreted as grouped expressionArun Agrawal2014-03-201-1/+1
|
* Reorder conditional logicDavid Pedersen2014-03-181-10/+10
| | | | | | According to the best practice that "unless not" and "unless else" is hard to follow logically the link_to_unless and link_to_if were reversed.
* Merge pull request #12662 from nashby/include-hidden-collectionRafael Mendonça França2014-03-151-3/+7
|\ | | | | | | | | | | | | | | add include_hidden option to collection_check_boxes helper Conflicts: actionview/CHANGELOG.md actionview/test/template/form_collections_helper_test.rb
| * add include_hidden option to collection_check_boxes helperVasiliy Ermolovich2013-10-271-3/+7
| |
* | Clarify AV::Digestor.digest method signature docs and deprecation warningJeremy Kemper2014-03-151-22/+21
| |
* | Fix the resolver cache and stop mutating the lookup_contextRafael Mendonça França2014-03-142-11/+10
| | | | | | | | | | Before we had a bug in the resolver cache so the disable_cache were not working when passing options to find
* | Merge pull request #14329 from pch/digestor-lookup-fixRafael Mendonça França2014-03-146-27/+52
|\ \ | | | | | | | | | Ensure LookupContext in Digestor selects correct variant
| * | Introduce #with_formats_and_variants to prevent problems with mutating ↵Łukasz Strzałkowski2014-03-142-5/+10
| | | | | | | | | | | | finder object
| * | Rename _setup_options to _options_for_digestŁukasz Strzałkowski2014-03-141-3/+3
| | |
| * | Disable LookupContext's cache when looking for templateŁukasz Strzałkowski2014-03-141-2/+6
| | |
| * | Don't pass hash as keys to #find methodŁukasz Strzałkowski2014-03-141-1/+1
| | |
| * | Add variants to Template classŁukasz Strzałkowski2014-03-143-12/+20
| | |
| * | Don't create addition vars, use options[] directlyŁukasz Strzałkowski2014-03-131-7/+2
| | |
| * | Ensure LookupContext in Digestor selects correct variantPiotr Chmolowski2014-03-092-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to: #14242 #14243 14293 Variants passed to LookupContext#find() seem to be ignored, so I've used the setter instead: `finder.variants = [ variant ]`. I've also added some more test cases for variants. Hopefully this time passing tests will mean it actually works.
* | | Fix 'fields_for' doc typo.Cakey | Buddy Magsipoc2014-03-101-2/+2
| | |
* | | Enhance readability of ActionView DateHelper#distance_of_time_in_wordsKenny Meyer2014-03-091-4/+8
|/ / | | | | | | | | | | | | Refactor numerical constants to module constants which give the numbers a contextual meaning. This commit aims to provide quicker understanding for part of the implementation of the DateHelper#distance_of_time_in_words method.