| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | docs, `select` and friends with `multiple=true` include a blank string. | Yves Senn | 2014-07-17 | 1 | -5/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [Jonas Baumann & Yves Senn] The submitted params from a select with `multiple: true` look as follows: ``` {post: {category: [""]}} {post: {category: ["", "Category 1", "Category 2"]}} ``` This is a follow up to #1552. | |||||
| | * | | Fix broken list formatting [ci skip] | noinkling | 2014-07-17 | 1 | -5/+5 | |
| | | | | ||||||
| | * | | Use &= instead of select with include? | Rafael Mendonça França | 2014-07-16 | 1 | -4/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The performance is almost the same with both implementations but this is clear. Before this patch: Calculating ------------------------------------- small erb template 1452 i/100ms ------------------------------------------------- small erb template 17462.1 (±13.3%) i/s - 85668 in 5.031395s .Calculating ------------------------------------- small erb template with 1 partial 887 i/100ms ------------------------------------------------- small erb template with 1 partial 8899.6 (±18.8%) i/s - 42576 in 5.009453s .Calculating ------------------------------------- small erb template with 2 partials 666 i/100ms ------------------------------------------------- small erb template with 2 partials 6821.5 (±8.8%) i/s - 33966 in 5.020791s After the patch: Calculating ------------------------------------- small erb template 1479 i/100ms ------------------------------------------------- small erb template 15956.6 (±7.6%) i/s - 79866 in 5.036001s .Calculating ------------------------------------- small erb template with 1 partial 841 i/100ms ------------------------------------------------- small erb template with 1 partial 9242.2 (±6.9%) i/s - 46255 in 5.029497s .Calculating ------------------------------------- small erb template with 2 partials 615 i/100ms ------------------------------------------------- small erb template with 2 partials 6524.7 (±6.8%) i/s - 32595 in 5.020456s You can find the benchmark code at https://gist.github.com/rafaelfranca/dee31120cfdb1ddc3b56 | |||||
| | * | | Merge pull request #15917 from luke-gru/actionview_perf | Rafael Mendonça França | 2014-07-16 | 1 | -1/+1 | |
| | |\ \ | | | | | | | | | | | | | remove Set.new from DetailsKey::get, impacts rendering overhead | |||||
| | | * | | remove Set.new from DetailsKey::get, impacts rendering overhead performance | Luke Gruber | 2014-06-25 | 1 | -1/+1 | |
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | Using ruby-prof, I noticed that Set#add had the largest 'self time' percentage (5% of the overall time spent rendering) when benchmarking the rendering of a small cached ERB template that was 3 lines long. It turns out it was from this line. I don't believe the Set is necessary, either. Removing this line increases the rendering ips using Benchmark::ips accordingly. | |||||
| | * | | Fix typo on the variable name | Rafael Mendonça França | 2014-07-16 | 1 | -8/+8 | |
| | | | | ||||||
| | * | | Document the PartialIteration object | Rafael Mendonça França | 2014-07-16 | 1 | -3/+9 | |
| | | | | ||||||
| | * | | Build only one PartialIteration object for loop | Rafael Mendonça França | 2014-07-16 | 1 | -11/+18 | |
| | | | | ||||||
| | * | | No need to have a file to PartialIteration class | Rafael Mendonça França | 2014-07-16 | 1 | -1/+17 | |
| | | | | | | | | | | | | | This class is only used on the PartialRenderer. | |||||
| | * | | Added PartialIteration class used when rendering collections | Joel Junström | 2014-07-16 | 1 | -13/+28 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu] | |||||
| | * | | Merge pull request #16175 from skorks/log_digestor_as_debug | Rafael Mendonça França | 2014-07-15 | 1 | -1/+1 | |
| | |\ \ | | | | | | | | | Log digest as :debug instead of :info | |||||
| | | * | | Log digest as :debug instead of :info | Alan Skorkin | 2014-07-15 | 1 | -1/+1 | |
| | | | | | ||||||
| | * | | | Merge pull request #16161 from jpawlyn/master | Andrew White | 2014-07-15 | 1 | -1/+1 | |
| | |\ \ \ | | |/ / | |/| | | Fix empty host for an asset url when asset_host proc returns nil | |||||
| | | * | | Return an absolute instead of relative path from an asset url in the case of ↵ | Jolyon Pawlyn | 2014-07-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | the `asset_host` proc returning nil | |||||
| | * | | | Fix typos like `a html` to `an html` and 'an mail' to 'an email'. [ci skip] | Santosh Wadghule | 2014-07-14 | 1 | -1/+1 | |
| | |/ / | ||||||
| * | | | Use the plugin API to the getter and setters | Rafael Mendonça França | 2014-07-15 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | To avoid having to redefine these methods on the deprecated plugin we should be using the sanitizer_vendor API. | |||||
| * | | | We don't need loofah for the assertions | Rafael Mendonça França | 2014-07-15 | 1 | -2/+1 | |
| | | | | | | | | | | | | | We can just use nokogiri | |||||
| * | | | Merge pull request #11218 from kaspth/loofah-integration | Rafael Mendonça França | 2014-07-10 | 9 | -1868/+71 | |
| |\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | Loofah-integration Conflicts: actionpack/CHANGELOG.md actionview/CHANGELOG.md | |||||
| | * | | Make output_buffers used in tests be utf-8 encoded. Fixing unknown encoding ↵ | Timm | 2014-06-16 | 1 | -1/+3 | |
| | | | | | | | | | | | | | ASCII-8BIT test errors. | |||||
| | * | | Don't splat arguments to allowed tags or attributes. | Timm | 2014-06-16 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | Change sanitizer_vendor to just be a method and reword documentation. | Timm | 2014-06-16 | 1 | -4/+5 | |
| | | | | ||||||
| | * | | Revert some stuff to use the new sanitizers. | Timm | 2014-06-16 | 1 | -6/+6 | |
| | | | | ||||||
| | * | | Remove html-scanner and its tests. | Timm | 2014-06-16 | 7 | -1772/+0 | |
| | | | | ||||||
| | * | | Remove deprecation notice. | Timm | 2014-06-16 | 1 | -2/+0 | |
| | | | | ||||||
| | * | | Add a layer of indirection making sanitizers pluggable. | Timm | 2014-06-16 | 3 | -3/+23 | |
| | | | | ||||||
| | * | | Delegate allowed tags and attributes setting to HTML::WhiteListSanitizer. | Timm | 2014-06-16 | 1 | -4/+4 | |
| | | | | ||||||
| | * | | Changed configuration documentation to no longer state it replaces a Set. | Timm | 2014-06-16 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | Deprecate configurations and use allowed_tags and allowed_attributes on ↵ | Timm | 2014-06-16 | 1 | -99/+22 | |
| | | | | | | | | | | | | | WhiteListSanitizer. | |||||
| | * | | Made deprecation messages in sanitize_helper more clear. | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | | ||||||
| | * | | Completed integration of rails-html-sanitizer in SanitizeHelper. Deprecated ↵ | Timm | 2014-06-16 | 3 | -294/+19 | |
| | | | | | | | | | | | | | protocol_separator accessors and bad_tags=. | |||||
| | * | | Updated html-scanner deprecation message. | Timm | 2014-06-16 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Support for changes in SelectorAssertions. | Timm | 2014-06-16 | 1 | -5/+6 | |
| | | | | ||||||
| | * | | Required rails-dom-testing in test_case.rb | Timm | 2014-06-16 | 1 | -1/+3 | |
| | | | | ||||||
| | * | | Removed ActionView::Assertions. Getting ready to exchange with ↵ | Timm | 2014-06-16 | 3 | -540/+0 | |
| | | | | | | | | | | | | | Rails::Dom::Testing::Assertions. | |||||
| | * | | Silenced deprecation warnings in the tests. Documentation uses present ↵ | Timm | 2014-06-16 | 1 | -3/+4 | |
| | | | | | | | | | | | | | tense. Changed deprecation message to not use you. Also returning from rescue block in catch_invalid_selector to abort reraising the exception. | |||||
| | * | | Added deprecation warning for invalid selectors and skipping assertions. | Timm | 2014-06-16 | 1 | -5/+24 | |
| | | | | ||||||
| | * | | Changed PermitScrubber's direction to bottom up to align better with ↵ | Timm | 2014-06-16 | 1 | -0/+1 | |
| | | | | | | | | | | | | | Loofah's strip scrubber. | |||||
| | * | | Now only requiring Loofah in the places where it is needed. | Timm | 2014-06-16 | 2 | -0/+4 | |
| | | | | ||||||
| | * | | Minor rewording in TargetScrubber documentation. | Timm | 2014-06-16 | 1 | -3/+3 | |
| | | | | ||||||
| | * | | Stylistic improvements in ActionView::Assertions::DomAssertions. | Timm | 2014-06-16 | 1 | -0/+4 | |
| | | | | ||||||
| | * | | Now returning html if html is blank? in FullSanitizer and ↵ | Timm | 2014-06-16 | 1 | -1/+3 | |
| | | | | | | | | | | | | | WhiteListSanitizer. This means it'll return false if called with false, however that is not a valid use case. | |||||
| | * | | Stylistic improvements. Some light documentation for remove_xpaths. | Timm | 2014-06-16 | 1 | -6/+8 | |
| | | | | ||||||
| | * | | Removed require's for html-scanner. | Timm | 2014-06-16 | 1 | -0/+3 | |
| | | | | ||||||
| | * | | Removed dom_assertion method since it created bugs. | Timm | 2014-06-16 | 1 | -8/+6 | |
| | | | | ||||||
| | * | | Removed unnecessary documentation in DomAssertions. | Timm | 2014-06-16 | 1 | -7/+0 | |
| | | | | ||||||
| | * | | Removed case statement in equal_children? used child.element? instead. | Timm | 2014-06-16 | 1 | -2/+1 | |
| | | | | ||||||
| | * | | Reworked some internal documentation for equal_attribute_nodes?. | Timm | 2014-06-16 | 1 | -3/+2 | |
| | | | | ||||||
| | * | | Changed attributes_are_equal? to equal_attribute_nodes? which takes ↵ | Timm | 2014-06-16 | 1 | -7/+8 | |
| | | | | | | | | | | | | | attribute_nodes instead of nodes. | |||||
| | * | | Removed html_strings variable, no splat operator needed. | Timm | 2014-06-16 | 1 | -4/+4 | |
| | | | | ||||||
| | * | | Changed back to =~ or == comparison in HTMLSelector filter. | Timm | 2014-06-16 | 1 | -2/+2 | |
| | | | | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |