aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Changed: put selector extraction into selector_from, which is renamed to ↵Timm2014-06-161-4/+4
| | | | | | | | | | | | extract_selector.
| * | Changed: HTMLSelector comparisons renamed to equality_tests.Timm2014-06-161-9/+6
| | |
| * | Changed: removed @selected and @page variables from HTMLSelector since one ↵Timm2014-06-161-10/+8
| | | | | | | | | | | | method used them. Passed the values directly to there instead.
| * | Changed: return early from compare_doms if the two doms don't have the same ↵Timm2014-06-161-0/+2
| | | | | | | | | | | | number of children.
| * | Changed: remove_xpaths called with String returns String, while called with ↵Timm2014-06-161-2/+2
| | | | | | | | | | | | Loofah fragment returns Loofah fragment. Added tests for this.
| * | Removed duplication in assert_dom_equal and assert_dom_not_equal.Timm2014-06-161-9/+6
| | |
| * | Changed wording of missing selector argument exception message in css_select.Timm2014-06-161-1/+1
| | |
| * | Reworked root and selector conditional assignment in css_select.Timm2014-06-161-5/+2
| | |
| * | Removed :nodoc: from PermitScrubber.Timm2014-06-161-1/+0
| | |
| * | Reworked documentation for PermitScrubber and TargetScrubber.Timm2014-06-161-2/+33
| | |
| * | Fixed: spelling error.Timm2014-06-161-1/+1
| | |
| * | Initialized tags and attributes to nil.Timm2014-06-161-0/+4
| | |
| * | Refactored scrub to keep_node? instead of scrub_node calling it. Also added ↵Timm2014-06-161-6/+5
| | | | | | | | | | | | ability to stop traversing by returning STOP from scrub_node.
| * | Changed PermitScrubber to be even more extensible. Updated TargetScrubber to ↵Timm2014-06-161-39/+40
| | | | | | | | | | | | be compliant. Updated documentation for PermitScrubber and TargetScrubber for clarity.
| * | Changed PermitScrubbers documentation to list override points for ↵Timm2014-06-161-12/+15
| | | | | | | | | | | | subclasses. Renamed should_remove_attributes? to should_scrub_attributes?.
| * | Already killed off LinkScrubber. Changed it instead to be TargetScrubber, ↵Timm2014-06-162-9/+20
| | | | | | | | | | | | which is more general, while still allowing maximum code reuse.
| * | Added LinkScrubber to remove duplication in LinkSanitizer. As such made ↵Timm2014-06-162-11/+22
| | | | | | | | | | | | PermitScrubber easier to subclass.
| * | Changed FullSanitizer sanitize to use tap method instead of temporary variable.Timm2014-06-161-3/+3
| | |
| * | Extracted the common xpaths to remove into XPATHS_TO_REMOVE.Timm2014-06-161-2/+4
| | |
| * | Refactored remove_xpaths to use duck typing and read better.Timm2014-06-161-4/+5
| | |
| * | Changed explanation for no duck typing of custom scrubbers.Timm2014-06-161-1/+2
| | |
| * | Removed copyright notice since we aren't relying on html-scanner anymore.Timm2014-06-161-5/+0
| | |
| * | Removed require for active_support/core_ext/object/inclusion since in? isn't ↵Timm2014-06-161-2/+0
| | | | | | | | | | | | used anywhere.
| * | Moved Dom and Selector assertions from ActionDispatch to ActionView.Timm2014-06-164-0/+549
| | |
| * | Replaced html-scanner with Loofah.Timm2014-06-151-1/+1
| | |
| * | Updated documentation to tell that a custom scrubber takes precedence.Timm2014-06-151-0/+1
| | |
| * | Updated the documentation to reflect the scrubber option.Timm2014-06-151-1/+22
| | |
| * | Marked the private API as not needing code documentation.Timm2014-06-152-0/+2
| | |
| * | Added ability to pass a custom scrubber to sanitize. Includes test coverage.Timm2014-06-151-1/+3
| | |
| * | Moved requiring of Loofah from sanitizers.rb to action_view.rb.Timm2014-06-151-1/+0
| | |
| * | Added ActionView::Sanitizer and moved remove_xpaths to there.Timm2014-06-151-7/+0
| | |
| * | Added comment removal. Changed definitation of remove_xpaths to not use a ↵Timm2014-06-151-11/+24
| | | | | | | | | | | | splat operator.
| * | Extracted the xpath removals into some new API that allows users to remove ↵Timm2014-06-151-2/+8
| | | | | | | | | | | | xpath subtrees.
| * | Added removal of script tags to WhiteListSanitizer.Timm2014-06-151-0/+1
| | |
| * | Added guard clauses to FullSanitizer.Timm2014-06-151-1/+6
| | |
| * | bad_tags include form since we remove it. Also to prevent a ↵Timm2014-06-151-1/+1
| | | | | | | | | | | | should_allow_form_tag test creation.
| * | Removed the contains_bad_protocols? method as well as the tests for it. ↵Timm2014-06-151-8/+2
| | | | | | | | | | | | Loofah already deals with this.
| * | Reordered form removal with stripping.Timm2014-06-151-4/+7
| | |
| * | Added PermitScrubber which allows you to permit elements for sanitization.Timm2014-06-152-13/+85
| | |
| * | Removed duplication in the deprecated methods.Timm2014-06-151-5/+5
| | |
| * | Added Loofah as a dependency in actionview.gemspec.Timm2014-06-112-23/+140
| | | | | | | | | | | | | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah.
* | | Include missing module in tag_helperCarlos Antonio da Silva2014-07-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Since 6857415187810f1289068a448268264d0cf0844f we are using #safe_join to join the content when an Array is given, so we must include the dependent module here to make sure it's available when this module is used alone. This was making Simple Form tests to fail with current master due to the missing dependency.
* | | [ci skip] /javascript/ -> JavaScript - cover whole appAkshay Vishnoi2014-07-041-2/+2
| | |
* | | Use if/elseRafael Mendonça França2014-06-301-2/+5
| | | | | | | | | | | | | | | Since we are using both branches of the code is preferable to use if/else over the early return.
* | | Add String support for min/max attributes on DatetimeFieldTodd Bealmear2014-06-302-2/+55
| | |
* | | Tiny documentation fixes [ci skip]Robin Dupret2014-06-291-1/+1
| | |
* | | Rename options param of #time_ago_in_words to match API changeMax Kramer2014-06-281-2/+2
| |/ |/| | | Rename `include_seconds_or_options` to `options` to match 6b9356a (which removed the deprecation introduced by #6077). This has no functional impact because the parameter is passed directly through, but makes it clearer that the parameter no longer supports a boolean as input.
* | Deal with regex match groups in excerptGareth Rees2014-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original implementation has bugs if the regex contains a match group. Example: excerpt('This is a beautiful? morning', /\b(beau\w*)\b/i, :radius => 5) Expected: "...is a beautiful? mor..." Actual: "...is a beautifulbeaut..." The original phrase was being converted to a regex and returning the text either side of the phrase as expected: 'This is a beautiful? morning'.split(/beautiful/i, 2) # => ["This is a ", "? morning"] When we have a match with groups the match is returned in the array. Quoting the ruby docs: "If pattern is a Regexp, str is divided where the pattern matches. [...] If pattern contains groups, the respective matches will be returned in the array as well." 'This is a beautiful? morning'.split(/\b(beau\w*)\b/iu, 2) # => ["This is a ", "beautiful", "? morning"] If we assume we want to split on the first match – this fix makes that assumption – we can pass the already assigned `phrase` variable as the place to split (because we already know that a match exists from line 168). Originally spotted by Louise Crow (@crowbot) at https://github.com/mysociety/alaveteli/pull/1557
* | Merge pull request #15732 from kuldeepaggarwal/correct-assets-ouputRafael Mendonça França2014-06-232-15/+15
|\ \ | | | | | | [ci skip] correct output for asset_helper methods
| * | [ci skip] correct output for asset_helper methodsKuldeep Aggarwal2014-06-162-15/+15
| | | | | | | | | | | | see cc255d3
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 17:58:16 +0000