Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Do not pass an instance variable to a private method | yui-knk | 2017-09-05 | 13 | -19/+19 | |
| | | | | | | | | | | | | | | | | | | | | | | `ActionView::Helpers::Tags::Base` has `@object` and all passed arguments for * `#value` * `#value_before_type_cast` * `#value_came_from_user?` are `@object`, so we do not need to pass arguments in this case. | |||||
* | | Use tt in doc for ActionView [ci skip] | Yoshiyuki Hirano | 2017-08-27 | 3 | -11/+11 | |
| | | ||||||
* | | Fix broken doc layout for action_view [ci skip] | Yoshiyuki Hirano | 2017-08-27 | 18 | -18/+18 | |
| | | ||||||
* | | Remove `alt` text from `image_tag` example [ci skip] | yuuji.yaginuma | 2017-08-24 | 2 | -7/+7 | |
| | | | | | | | | Follow up of #30213 | |||||
* | | Remove alt generation from image_submit_tag | Rafael Mendonça França | 2017-08-23 | 1 | -6/+6 | |
| | | ||||||
* | | Merge pull request #30213 from ckundo/ccundiff-alt-text-default | Rafael Mendonça França | 2017-08-23 | 1 | -13/+9 | |
|\ \ | | | | | | | | | | Do not generate default alt text for images | |||||
| * | | Do not generate default alt text in image tags | Cameron Cundiff | 2017-08-17 | 1 | -13/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096] | |||||
* | | | [ci skip] form_with in the getting started guide. | Kasper Timm Hansen | 2017-08-21 | 1 | -0/+30 | |
|/ / | | | | | | | Add back a bit about a resource oriented style of routing. | |||||
* | | Add code formatting and minor grammar clarifications | T.J. Schuck | 2017-08-09 | 1 | -10/+10 | |
| | | | | | | [ci skip] | |||||
* | | Fix broken RDoc formatting | T.J. Schuck | 2017-08-09 | 1 | -1/+1 | |
| | | | | | | | | | | The `@` ivar format doesn’t work with RDoc's `+` code formatting; needs `<tt>`. [ci skip] | |||||
* | | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084) | Anton Khamets | 2017-08-07 | 1 | -2/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError | |||||
* | | Merge pull request #30020 from rails/active-storage-import | David Heinemeier Hansson | 2017-08-04 | 2 | -2/+9 | |
|\ \ | | | | | | | Add Active Storage to Rails | |||||
| * | | Remove duplicated convert_direct_upload_option_to_url | Rafael Mendonça França | 2017-08-03 | 2 | -7/+4 | |
| | | | | | | | | | | | | FormHelper includes FormTagHelper so we don't need to define two methods | |||||
| * | | Refactor convert_direct_upload_option_to_url | Rafael Mendonça França | 2017-08-03 | 1 | -3/+4 | |
| | | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in. | |||||
| * | | Make sure Action View doesn't break with Active Storage | Rafael Mendonça França | 2017-08-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception. | |||||
| * | | Add require | David Heinemeier Hansson | 2017-08-01 | 1 | -0/+1 | |
| | | | ||||||
| * | | Move the direct_upload: true convenience option from the activestorage ↵ | David Heinemeier Hansson | 2017-07-31 | 2 | -2/+10 | |
| | | | | | | | | | | | | helper into actionview | |||||
* | | | Allow non-English values for collection_radio_buttons/check_boxes | colorfulfool | 2017-08-02 | 1 | -1/+1 | |
|/ / | ||||||
* | | Suppress warning from actionview controller helper. | Christina Thompson | 2017-07-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com> | |||||
* | | Merge pull request #29897 from kirs/frozen-actionview | Rafael França | 2017-07-24 | 59 | -1/+117 | |
|\ \ | | | | | | | Use frozen string literal in actionview/ | |||||
| * | | Use frozen string literal in actionview/ | Kir Shatrov | 2017-07-24 | 59 | -1/+117 | |
| | | | ||||||
* | | | Merge pull request #29792 from lugray/delegate_respond_to | Rafael França | 2017-07-24 | 1 | -2/+10 | |
|\ \ \ | |/ / |/| | | Delegate respond_to? in ActionView::Helpers::ControllerHelper | |||||
| * | | Delegate respond_to? in ActionView::Helpers::ControllerHelper | Lisa Ugray | 2017-07-19 | 1 | -2/+10 | |
| | | | | | | | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected. | |||||
* | | | Merge pull request #29884 from padi/update_rails_5_upgrade_guide | Rafael França | 2017-07-21 | 1 | -2/+2 | |
|\ \ \ | |/ / |/| | | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper` | |||||
| * | | Suppress documentation for content_tag_for and div_for since they were ↵ | Marc Rendl Ignacio | 2017-07-21 | 1 | -2/+2 | |
| |/ | | | | | | | removed already | |||||
* / | [ci skip]Replace jquery-ujs with rails-ujs | willnet | 2017-07-19 | 1 | -1/+1 | |
|/ | ||||||
* | Merge branch 'master' into require_relative_2017 | Xavier Noria | 2017-07-02 | 4 | -7/+21 | |
|\ | ||||||
| * | Avoid shadowed variable | Matthew Draper | 2017-07-02 | 1 | -2/+2 | |
| | | ||||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 59 | -59/+1 | |
| | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | |||||
| * | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 59 | -1/+59 | |
| |\ | | | | | | | | | | Enforce frozen string in Rubocop | |||||
| | * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 59 | -1/+59 | |
| | | | ||||||
| * | | Merge pull request #29506 from pat/frozen-string-literals | Matthew Draper | 2017-07-02 | 3 | -5/+5 | |
| |\ \ | | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly. | |||||
| | * | | Make ActionView frozen string literal friendly. | Pat Allan | 2017-06-20 | 2 | -3/+3 | |
| | | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches. | |||||
| | * | | Make ActiveModel frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite. | |||||
| * | | | Merge pull request #29349 from robertomiranda/responsive-images | Matthew Draper | 2017-07-02 | 1 | -2/+16 | |
| |\ \ \ | | |_|/ | |/| | | | | | | Add srcset option to image_tag helper | |||||
| | * | | Add `srcset` option to `image_tag` helper | Roberto Miranda | 2017-06-29 | 1 | -1/+15 | |
| |/ / | ||||||
* / / | [Action View] require => require_relative | Akira Matsuda | 2017-07-01 | 14 | -20/+20 | |
|/ / | ||||||
* / | Fix current_page? helper issue with engine root path | savroff | 2017-06-19 | 1 | -1/+4 | |
|/ | ||||||
* | Generate field ids in `collection_check_boxes` and `collection_radio_buttons` | yuuji.yaginuma | 2017-06-11 | 2 | -0/+2 | |
| | | | | | This makes sure that the labels are linked up with the fields. Fixes #29014 | |||||
* | Don't rely on the @view_renderer being defined. | Kasper Timm Hansen | 2017-06-08 | 1 | -2/+2 | |
| | | | | That won't be true for Action Pack and Action Mailer. | |||||
* | Merge pull request https://github.com/rails/rails/pull/28637 from ↵ | Kasper Timm Hansen | 2017-06-08 | 1 | -6/+2 | |
| | | | | st0012/fix-partial-cache-logging | |||||
* | Use a hash to record every partial's cache hit status instead of sharing a ↵ | Stan Lo | 2017-06-08 | 1 | -2/+4 | |
| | | | | boolean. | |||||
* | Move slicing to initializer. | Kasper Timm Hansen | 2017-06-07 | 2 | -2/+2 | |
| | | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca | |||||
* | Use mattr_accessor default: option throughout the project | Genadi Samokovarov | 2017-06-03 | 2 | -6/+3 | |
| | ||||||
* | Add option for class_attribute default (#29270) | David Heinemeier Hansson | 2017-05-29 | 1 | -8/+9 | |
| | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation | |||||
* | Merge pull request #29119 from spohlenz/fix-select-with-enumerable | Matthew Draper | 2017-05-24 | 1 | -1/+1 | |
|\ | | | | | Fix select tag helper used with Enumerable choices | |||||
| * | Fix select tag helper used with Enumerable choices | Sam Pohlenz | 2017-05-17 | 1 | -1/+1 | |
| | | | | | | | | | | | | Allows a custom object implementing Enumerable to be used as the choices parameter for a select tag, which previously wasn't possible due to the call to `empty?` on the choices (which isn't implemented on Enumerable). | |||||
* | | Add :json type to auto_discovery_link_tag | Mike Gunderloy | 2017-05-20 | 1 | -5/+7 | |
| | | | | | | | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information. | |||||
* | | Use recyclable cache keys (#29092) | David Heinemeier Hansson | 2017-05-18 | 1 | -9/+17 | |
|/ | ||||||
* | Merge pull request #20701 from iamvery/date-helper-argument-error | Andrew White | 2017-04-27 | 1 | -18/+26 | |
|\ | | | | | Ensure input to distance_of_time_in_words is not nil |