Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Suppress warning from actionview controller helper. | Christina Thompson | 2017-07-24 | 1 | -1/+1 |
| | | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com> | ||||
* | Merge pull request #29897 from kirs/frozen-actionview | Rafael França | 2017-07-24 | 59 | -1/+117 |
|\ | | | | | Use frozen string literal in actionview/ | ||||
| * | Use frozen string literal in actionview/ | Kir Shatrov | 2017-07-24 | 59 | -1/+117 |
| | | |||||
* | | Merge pull request #29792 from lugray/delegate_respond_to | Rafael França | 2017-07-24 | 1 | -2/+10 |
|\ \ | |/ |/| | Delegate respond_to? in ActionView::Helpers::ControllerHelper | ||||
| * | Delegate respond_to? in ActionView::Helpers::ControllerHelper | Lisa Ugray | 2017-07-19 | 1 | -2/+10 |
| | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected. | ||||
* | | Merge pull request #29884 from padi/update_rails_5_upgrade_guide | Rafael França | 2017-07-21 | 1 | -2/+2 |
|\ \ | |/ |/| | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper` | ||||
| * | Suppress documentation for content_tag_for and div_for since they were ↵ | Marc Rendl Ignacio | 2017-07-21 | 1 | -2/+2 |
| | | | | | | | | removed already | ||||
* | | [ci skip]Replace jquery-ujs with rails-ujs | willnet | 2017-07-19 | 1 | -1/+1 |
|/ | |||||
* | Merge branch 'master' into require_relative_2017 | Xavier Noria | 2017-07-02 | 4 | -7/+21 |
|\ | |||||
| * | Avoid shadowed variable | Matthew Draper | 2017-07-02 | 1 | -2/+2 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 59 | -59/+1 |
| | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 59 | -1/+59 |
| |\ | | | | | | | | | | Enforce frozen string in Rubocop | ||||
| | * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 59 | -1/+59 |
| | | | |||||
| * | | Merge pull request #29506 from pat/frozen-string-literals | Matthew Draper | 2017-07-02 | 3 | -5/+5 |
| |\ \ | | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly. | ||||
| | * | | Make ActionView frozen string literal friendly. | Pat Allan | 2017-06-20 | 2 | -3/+3 |
| | | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches. | ||||
| | * | | Make ActiveModel frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite. | ||||
| * | | | Merge pull request #29349 from robertomiranda/responsive-images | Matthew Draper | 2017-07-02 | 1 | -2/+16 |
| |\ \ \ | | |_|/ | |/| | | | | | | Add srcset option to image_tag helper | ||||
| | * | | Add `srcset` option to `image_tag` helper | Roberto Miranda | 2017-06-29 | 1 | -1/+15 |
| |/ / | |||||
* / / | [Action View] require => require_relative | Akira Matsuda | 2017-07-01 | 14 | -20/+20 |
|/ / | |||||
* / | Fix current_page? helper issue with engine root path | savroff | 2017-06-19 | 1 | -1/+4 |
|/ | |||||
* | Generate field ids in `collection_check_boxes` and `collection_radio_buttons` | yuuji.yaginuma | 2017-06-11 | 2 | -0/+2 |
| | | | | | This makes sure that the labels are linked up with the fields. Fixes #29014 | ||||
* | Don't rely on the @view_renderer being defined. | Kasper Timm Hansen | 2017-06-08 | 1 | -2/+2 |
| | | | | That won't be true for Action Pack and Action Mailer. | ||||
* | Merge pull request https://github.com/rails/rails/pull/28637 from ↵ | Kasper Timm Hansen | 2017-06-08 | 1 | -6/+2 |
| | | | | st0012/fix-partial-cache-logging | ||||
* | Use a hash to record every partial's cache hit status instead of sharing a ↵ | Stan Lo | 2017-06-08 | 1 | -2/+4 |
| | | | | boolean. | ||||
* | Move slicing to initializer. | Kasper Timm Hansen | 2017-06-07 | 2 | -2/+2 |
| | | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca | ||||
* | Use mattr_accessor default: option throughout the project | Genadi Samokovarov | 2017-06-03 | 2 | -6/+3 |
| | |||||
* | Add option for class_attribute default (#29270) | David Heinemeier Hansson | 2017-05-29 | 1 | -8/+9 |
| | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation | ||||
* | Merge pull request #29119 from spohlenz/fix-select-with-enumerable | Matthew Draper | 2017-05-24 | 1 | -1/+1 |
|\ | | | | | Fix select tag helper used with Enumerable choices | ||||
| * | Fix select tag helper used with Enumerable choices | Sam Pohlenz | 2017-05-17 | 1 | -1/+1 |
| | | | | | | | | | | | | Allows a custom object implementing Enumerable to be used as the choices parameter for a select tag, which previously wasn't possible due to the call to `empty?` on the choices (which isn't implemented on Enumerable). | ||||
* | | Add :json type to auto_discovery_link_tag | Mike Gunderloy | 2017-05-20 | 1 | -5/+7 |
| | | | | | | | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information. | ||||
* | | Use recyclable cache keys (#29092) | David Heinemeier Hansson | 2017-05-18 | 1 | -9/+17 |
|/ | |||||
* | Merge pull request #20701 from iamvery/date-helper-argument-error | Andrew White | 2017-04-27 | 1 | -18/+26 |
|\ | | | | | Ensure input to distance_of_time_in_words is not nil | ||||
| * | Ensure input to distance_of_time_in_words is not nil | Jay Hayes | 2017-04-27 | 1 | -18/+26 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Internally all input is converted to time so that it can be treated uniformly. Remove now-unneeded condition * Now that all input is treated is converted to time, we no longer need to type check it. Rename variables to clarify their purpose Extract private method to normalize distance_of_time args to time Update actionview changelog | ||||
* | | Merge pull request #28844 from ↵ | Kasper Timm Hansen | 2017-04-27 | 1 | -1/+1 |
|\ \ | | | | | | | | | | | | | kyuden/remove_unnecessary_attributes_of_select_in_form_with Remove unnecessary `skip_default_ids` and `allow_method_names_outside_object` attributes of select tag in `form_with` | ||||
| * | | Remove unnecessary `skip_default_ids` and ↵ | kyuden | 2017-04-24 | 1 | -1/+1 |
| |/ | | | | | | | `allow_method_names_outside_object` attributes of select tag in `form_with` | ||||
* / | Fix `current_page?` regression: | Edouard CHIN | 2017-04-26 | 1 | -1/+1 |
|/ | | | | | | - `check_parameters` kwargs was added to the `current_page?` method, the implementation was assuming only hashes responds to `delete`. This was causing issues when `current_page?` was called with a Active Model object - ref https://github.com/rails/rails/pull/27549 - Fixes #28846 | ||||
* | Reuse the Parameters#to_h check in the routing helpers | Rafael Mendonça França | 2017-04-18 | 1 | -5/+0 |
| | | | | | Since this protection is now in Parameters we can use it instead of reimplementing again. | ||||
* | Add `form_with_generates_remote_forms` config. | Kasper Timm Hansen | 2017-04-16 | 1 | -1/+3 |
| | | | | | | | Allows users to not have remote forms by default, since there's more JS harness, e.g. bundling rails-ujs, otherwise. Also don't skip creating defaults file anymore. Sprockets isn't the only new config. | ||||
* | Default embed_authenticity_token_in_remote_forms to nil. | Kasper Timm Hansen | 2017-04-16 | 2 | -7/+9 |
| | | | | | | | Effectively treat nil values as "auto", e.g. whatever a form helper chooses to interpret it as. But treat an explicitly assigned false value as disabling. | ||||
* | Fix module name [ci skip] | yuuji.yaginuma | 2017-04-15 | 1 | -10/+10 |
| | | | | Replace `FormOptionHelper` to `FormOptionsHelper`. | ||||
* | Close form_for tag in FormHelper API docs | Alex Muller | 2017-04-13 | 1 | -2/+2 |
| | |||||
* | Fix typo in actionview error message | adamgamble | 2017-03-17 | 1 | -1/+1 |
| | |||||
* | Remove `encode_special_chars` option from `strip_tags` | Andrew Hood | 2017-02-27 | 1 | -4/+10 |
| | |||||
* | Fix grammar 'an hyphen' -> 'a hyphen' [ci skip] | kenta-s | 2017-01-25 | 1 | -1/+1 |
| | |||||
* | Remove unnecessary comments in cache_helper.rb [ci skip] | kenta-s | 2017-01-21 | 1 | -2/+0 |
| | |||||
* | Merge pull request #27665 from kenta-s/improve-compute_asset_extname | Rafael França | 2017-01-18 | 1 | -1/+5 |
|\ | | | | | compute_asset_extname should explicitly return nil in else clause | ||||
| * | should explicitly returns nil in else clause | kenta-s | 2017-01-13 | 1 | -1/+5 |
| | | |||||
* | | Merge pull request #27693 from kenta-s/improve-to_sentence-method | Rafael França | 2017-01-18 | 1 | -1/+1 |
|\ \ | | | | | | | Fix unexpected behavior of `to_sentence` with $, | ||||
| * | | Fix unexpected behavior of with $, | kenta-s | 2017-01-15 | 1 | -1/+1 |
| | | | |||||
* | | | Remove unused variable 'regex' | kenta-s | 2017-01-18 | 1 | -1/+1 |
| | | |