aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Allow an array to be a default translation value.Adam Prescott2015-04-041-1/+1
| | | | | | | | | | | 4.2.1 introduced a change to the way `translate`/`t` works with an option of `default: [[]]`. In 4.2.0, this would give a default value of `[]`, but in 4.2.1, it leads to a missing translation. `default: [[]]` is again allowed for cases where a default of `[]` is needed. This addresses GitHub issue 19640.
* [skip ci] Update information about #link_to attributesAnton Davydov2015-04-041-4/+3
|
* [skip ci] Add information about #link_to target optionAnton Davydov2015-04-011-0/+6
|
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-03-262-1/+2
|\ | | | | | | | | Conflicts: guides/source/4_0_release_notes.md
| * [ci skip] Add a line between code example and docsyui-knk2015-03-211-0/+1
| |
| * [ci skip] Add space after erb block.yui-knk2015-03-121-1/+1
| |
* | Simplify setting button form optionsCarlos Antonio da Silva2015-03-221-2/+3
| | | | | | | | No need to merge hashes when simply setting options does the job.
* | Rework form helper example to use Person.newCarlos Antonio da Silva2015-03-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | The previous change 92a3c8dcdf174dab5e8759031b6bbe6cd891fe3c improved this example, but calling .create + #valid? ends up running validations twice, and we don't want to showcase that. Lets use the normal use case of building a new object and calling #save on it, which is what a basic scaffold with Active Record does. [ci skip]
* | [ci skip] Check a result of `valid?` instead of `create`yui-knk2015-03-211-1/+2
| |
* | Merge pull request #19421 from jcoyne/translate_defaults_with_nilRafael Mendonça França2015-03-201-1/+1
| | | | | | | | Strip nils out of default translations. Fixes #19419
* | Remove additional handling of boolean attributes on button to helperCarlos Antonio da Silva2015-03-181-30/+0
| | | | | | | | | | | | | | | | This logic was just doing duplicated work, since the button_to helper relies on tag/content_tag to generate the button html, which already handles all boolean attributes it knows about. The code dates back to 2005: 43c470fae468ef63e0d5c3dc1e202925685fd47b.
* | [ci skip] correct output of selectKuldeep Aggarwal2015-03-131-15/+15
| |
* | [CI SKIP] Correct output of options_for_selectAkshay Vishnoi2015-03-131-5/+5
| |
* | Let strip_tags leave HTML escaping to Rails.Kasper Timm Hansen2015-03-101-1/+1
| | | | | | | | Prevents double escaping errors, such as "&" becoming "&".
* | don't need to rescue Exception in this caseAaron Patterson2015-03-051-1/+1
| |
* | [ci skip] Add information about sanitize option in TextHelper#highlightAnton Davydov2015-03-051-1/+6
| |
* | Merge pull request #19144 from y-yagi/fix_streaming_bufferRafael Mendonça França2015-03-041-1/+3
|\ \ | | | | | | fix ActionView::Template::Error when using Streaming with capture.
| * | fix ActionView::Template::Error when using Streaming with capture.yuuji.yaginuma2015-03-011-1/+3
| |/ | | | | | | can't acquire a encoding from StreamingBuffer. fixes #12001
* / Fix spelling [ci skip]Yu Haidong2015-03-041-8/+8
|/
* Fix regression when passing a value different of String.Ulisses Almeida2015-02-261-1/+5
| | | | | | | | | | | | | | | | | The previous version of rails(4.2.0) you can pass objects to the default option of translation helper. For example: ```ruby t('foo', default: 1) ``` But on rails 4.2.1 version this kind of use stopped to work, because started only to accept String types. Now with this fix we can use orther value types on this helper again.
* Fix typos in ActionView::Helpers::FormBuilder comment [ci skip]Yu Haidong2015-02-261-1/+2
|
* Merge pull request #18948 from kaspth/automatic-collection-cachingRafael Mendonça França2015-02-251-0/+31
|\ | | | | Merge multi_fetch_fragments.
| * Collections automatically cache and fetch partials.Kasper Timm Hansen2015-02-211-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collections can take advantage of `multi_read` if they render one template and their partials begin with a cache call. The cache call must correspond to either what the collections elements are rendered as, or match the inferred name of the partial. So with a notifications/_notification.html.erb template like: ```ruby <% cache notification %> <%# ... %> <% end %> ``` A collection would be able to use `multi_read` if rendered like: ```ruby <%= render @notifications %> <%= render partial: 'notifications/notification', collection: @notifications, as: :notification %> ```
| * Merge multi_fetch_fragments.Kasper Timm Hansen2015-02-201-0/+8
| | | | | | | | | | | | | | | | Makes caching a collection of template partials faster using `read_multi` on the Rails cache store. Some caching implementations have optimized `read_multi` so we don't have to check in the cache store for every template.
* | Fix cache_helper comment ERBAnthony Dmitriyev2015-02-201-2/+2
| |
* | Merge pull request #17143 from kuldeepaggarwal/fix-mailToRafael Mendonça França2015-02-201-1/+1
|\ \ | | | | | | | | | mail_to helper method fix
| * | do not generate blank options in mailToKuldeep Aggarwal2014-10-021-2/+3
| | | | | | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options.
* | | Use a name that better reflect the return valueRafael Mendonça França2015-02-201-2/+2
| | |
* | | Merge pull request #17138 from jpcody/rename_default_form_builderRafael Mendonça França2015-02-201-2/+2
|\ \ \ | | | | | | | | | | | | Rename default_form_builder to avoid collision
| * | | Rename default_form_builder to avoid collisionJoshua Cody2014-10-011-2/+2
| |/ /
* | | Corrects the API to method select_tagLeandro Nunes2015-02-201-2/+1
| | | | | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method
* | | Remove RecordTagHelper, add extraction noticesTodd Bealmear2015-02-162-99/+14
| | | | | | | | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods.
* | | Allow to pass a string value to size option in `image_tag` and `video_tag`Mehdi Lahmam2015-02-161-0/+1
| |/ |/| | | | | This makes the behavior more consistent with `width` or `height` options
* | Merge pull request #18845 from bogdan/remove-code-dups-in-action-viewRafael Mendonça França2015-02-112-33/+25
|\ \ | | | | | | Remove some code duplication in ActionView tags code
| * | Remove code duplication in ActionView::Helpers::Tags::BaseBogdan Gusiev2015-02-112-33/+25
| | |
* | | Remove warning from ActionView::Helpers::Tags::TranslatorYuki Nishijima2015-02-081-1/+3
|/ / | | | | | | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
* | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_forMiklos Fazekas2015-02-061-1/+1
| | | | | | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model)
* | Indicate link_to creates an anchor elementColin Rymer2015-02-061-2/+2
| | | | | | | | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip]
* | Rename method to make explicit its intentionRafael Mendonça França2015-02-053-3/+3
| | | | | | | | call is too generic
* | Use kwags to make the argument meaning explicitRafael Mendonça França2015-02-053-6/+6
| |
* | Use new hash syntaxRafael Mendonça França2015-02-051-1/+1
| |
* | Change the method visibilityRafael Mendonça França2015-02-051-2/+4
| | | | | | | | Thse methods are used only inside this class
* | Only check if object respond_to to_model onceRafael Mendonça França2015-02-051-6/+2
| |
* | placeholder doesn't exist inside this contextRafael Mendonça França2015-02-051-2/+2
| |
* | Merge pull request #18647 from mcls/placeholderable-to-modelRafael Mendonça França2015-02-054-28/+47
|\ \ | | | | | | | | | The `model_name` method should be called on `to_model`
| * | Reduce duplication when generating translationsMaarten Claes2015-01-224-34/+47
| | |
| * | Convert with `to_model` before calling ActiveModel methods on `object`Maarten Claes2015-01-222-8/+14
| | |
* | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵Vipul A M2015-02-031-1/+0
| | | | | | | | | | | | onwards.
* | | Add missing options to `datetime_select` [ci skip]yachibit2015-01-251-0/+2
|/ /
* | Single instead of double quotes T.J. Schuck2015-01-201-2/+2
| | | | | | [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 00:34:46 +0000