| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Allow custom asset host to be passed in asset_url
|
| |
| |
| |
| | |
Updated CHANGELOG.md with entry about :host in asset_url
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Dup options hash to prevent modifications
|
| |/
| |
| |
| | |
`options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object.
|
|/
|
|
|
|
| |
For some reason, if the hash is empty, we choose "optimized" routes. I
am not sure how or why optimized routes differ from regular routes.
But, if we make sure the hash is empty, we get a nice speed improvement.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, only the object and method name from the label tag were
used when looking up the translation for a label. If a value is
given for the label, this ought to be additionally used. The
following:
# form.html.erb
<%= form_for @post do |f| %>
<%= f.label :type, value: "long" %>
<% end %>
# en.yml
en:
activerecord:
attributes:
post/long: "Long-form Post"
Used to simply return "long", but now it will return "Long-form
Post".
|
| |
|
| |
|
| |
|
|
|
|
| |
Motivated by #14907.
|
|\ |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
|
| |/
| |
| |
| |
| |
| |
| |
| | |
image/x-icon.
Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon,
registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products.
The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
|
|/ |
|
|
|
|
| |
Related with cbb917455f306cf5818644b162f22be09f77d4b2
|
|\
| |
| |
| |
| |
| |
| | |
Remove wrapping div with inline styles for hidden form fields.
Conflicts:
actionview/CHANGELOG.md
|
| |
| |
| |
| |
| |
| | |
We are dropping HTML 4.01 and XHTML strict compliance since input
tags directly inside a form are valid HTML5, and the absense of
inline styles help in validating for Content Security Policy.
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
closes #14147
|
|\
| |
| | |
CollectionHelpers now accepts a readonly option
|
| | |
|
|/
|
|
|
|
|
| |
References to ``AppName::Application` removed in favour of ``Rails.application``
as generated with a new rails 4.1 app.
[ci skip]
|
| |
|
| |
|
|
|
|
|
| |
with_css_classes: true option overwrites other html classes.
Concatenate day month and year classes rather than overwriting.
|
|
|
|
| |
variant -- trying to pass it back in makes a mess of things (oh, and doesnt work)
|
|
|
|
|
|
| |
According to the best practice that "unless not" and "unless else"
is hard to follow logically the link_to_unless and link_to_if
were reversed.
|
|\
| |
| |
| |
| |
| |
| |
| | |
add include_hidden option to collection_check_boxes helper
Conflicts:
actionview/CHANGELOG.md
actionview/test/template/form_collections_helper_test.rb
|
| | |
|
|\ \
| | |
| | |
| | | |
Ensure LookupContext in Digestor selects correct variant
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Related to: #14242 #14243 14293
Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.
I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| | |
Refactor numerical constants to module constants which give the numbers
a contextual meaning. This commit aims to provide quicker understanding
for part of the implementation of the
DateHelper#distance_of_time_in_words method.
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/4_1_release_notes.md
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`render :body` should just not set the `Content-Type` header. By
removing the header, it breaks the compatibility with other parts.
After this commit, `render :body` will returns `text/html` content type,
sets by default from `ActionDispatch::Response`, and it will preserve
the overridden content type if you override it.
Fixes #14197, #14238
This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Take variants into account when calculating template digests in
ActionView::Digest.
Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.
Fixes #14242
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There's no need to rely on Active Support's Hash#reverse_merge for
simple cases with default values, since we can just merge from the
default rather than reverse merge from the options.
This also avoids the creation of one extra hash object by moving to a
Hash#merge! call.
|
| | | |
|
| | | |
|
| | | |
|