aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/lib/action_view/helpers
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #29791 from yui-knk/at_objectRyuta Kamizono2017-09-0513-19/+19
|\ | | | | Do not pass an instance variable to a private method
| * Do not pass an instance variable to a private methodyui-knk2017-09-0513-19/+19
| | | | | | | | | | | | | | | | | | | | | | `ActionView::Helpers::Tags::Base` has `@object` and all passed arguments for * `#value` * `#value_before_type_cast` * `#value_came_from_user?` are `@object`, so we do not need to pass arguments in this case.
* | Use tt in doc for ActionView [ci skip]Yoshiyuki Hirano2017-08-273-11/+11
| |
* | Fix broken doc layout for action_view [ci skip]Yoshiyuki Hirano2017-08-2718-18/+18
| |
* | Remove `alt` text from `image_tag` example [ci skip]yuuji.yaginuma2017-08-242-7/+7
| | | | | | | | Follow up of #30213
* | Remove alt generation from image_submit_tagRafael Mendonça França2017-08-231-6/+6
| |
* | Merge pull request #30213 from ckundo/ccundiff-alt-text-defaultRafael Mendonça França2017-08-231-13/+9
|\ \ | | | | | | | | | Do not generate default alt text for images
| * | Do not generate default alt text in image tagsCameron Cundiff2017-08-171-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Auto-generating content from the filename of an image is not suitable alternative text; alt text that isn't fully considered can be distracting and fatiguing for screen readers users (blind, low vision, dyslexic people). - Setting a filename fallback short circuits screen reader default behavior and configuration for blank descriptions. - Setting poor defaults also creates false negatives for accessibility linting and testing software, that makes it harder to improve application accessibility. *** - After this change, if authors leave images without alt text, screen readers will fallback to default behavior for missing alt text. - Also with this change, Automated linting and testing tools will correctly generate warnings. [Fixes #30096]
* | | [ci skip] form_with in the getting started guide.Kasper Timm Hansen2017-08-211-0/+30
|/ / | | | | | | Add back a bit about a resource oriented style of routing.
* | Add code formatting and minor grammar clarificationsT.J. Schuck2017-08-091-10/+10
| | | | | | [ci skip]
* | Fix broken RDoc formattingT.J. Schuck2017-08-091-1/+1
| | | | | | | | | | The `@` ivar format doesn’t work with RDoc's `+` code formatting; needs `<tt>`. [ci skip]
* | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-071-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* | Merge pull request #30020 from rails/active-storage-importDavid Heinemeier Hansson2017-08-042-2/+9
|\ \ | | | | | | Add Active Storage to Rails
| * | Remove duplicated convert_direct_upload_option_to_urlRafael Mendonça França2017-08-032-7/+4
| | | | | | | | | | | | FormHelper includes FormTagHelper so we don't need to define two methods
| * | Refactor convert_direct_upload_option_to_urlRafael Mendonça França2017-08-031-3/+4
| | | | | | | | | | | | Also make sure file_field doesn't mutate the original options passed in.
| * | Make sure Action View doesn't break with Active StorageRafael Mendonça França2017-08-031-1/+1
| | | | | | | | | | | | | | | When Active Storage is not loaded and direct_upload is used on file_field_tag we should not raise an exception.
| * | Add requireDavid Heinemeier Hansson2017-08-011-0/+1
| | |
| * | Move the direct_upload: true convenience option from the activestorage ↵David Heinemeier Hansson2017-07-312-2/+10
| | | | | | | | | | | | helper into actionview
* | | Allow non-English values for collection_radio_buttons/check_boxescolorfulfool2017-08-021-1/+1
|/ /
* | Suppress warning from actionview controller helper.Christina Thompson2017-07-241-1/+1
| | | | | | | | | | | | Explicitly pass a destructed array to the delegate method. Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
* | Merge pull request #29897 from kirs/frozen-actionviewRafael França2017-07-2459-1/+117
|\ \ | | | | | | Use frozen string literal in actionview/
| * | Use frozen string literal in actionview/Kir Shatrov2017-07-2459-1/+117
| | |
* | | Merge pull request #29792 from lugray/delegate_respond_toRafael França2017-07-241-2/+10
|\ \ \ | |/ / |/| | Delegate respond_to? in ActionView::Helpers::ControllerHelper
| * | Delegate respond_to? in ActionView::Helpers::ControllerHelperLisa Ugray2017-07-191-2/+10
| | | | | | | | | | | | | | | | | | Since methods defined in the controller helper are mostly delegated to the controller, delegate respond_to? as well, so that for example `respond_to?(:params)` behaves as expected.
* | | Merge pull request #29884 from padi/update_rails_5_upgrade_guideRafael França2017-07-211-2/+2
|\ \ \ | |/ / |/| | Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
| * | Suppress documentation for content_tag_for and div_for since they were ↵Marc Rendl Ignacio2017-07-211-2/+2
| |/ | | | | | | removed already
* / [ci skip]Replace jquery-ujs with rails-ujswillnet2017-07-191-1/+1
|/
* Merge branch 'master' into require_relative_2017Xavier Noria2017-07-024-7/+21
|\
| * Avoid shadowed variableMatthew Draper2017-07-021-2/+2
| |
| * Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0259-59/+1
| | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
| * Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0259-1/+59
| |\ | | | | | | | | | Enforce frozen string in Rubocop
| | * Enforce frozen string in RubocopKir Shatrov2017-07-0159-1/+59
| | |
| * | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-023-5/+5
| |\ \ | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| | * | Make ActionView frozen string literal friendly.Pat Allan2017-06-202-3/+3
| | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches.
| | * | Make ActiveModel frozen string literal friendly.Pat Allan2017-06-201-2/+2
| | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite.
| * | | Merge pull request #29349 from robertomiranda/responsive-imagesMatthew Draper2017-07-021-2/+16
| |\ \ \ | | |_|/ | |/| | | | | | Add srcset option to image_tag helper
| | * | Add `srcset` option to `image_tag` helperRoberto Miranda2017-06-291-1/+15
| |/ /
* / / [Action View] require => require_relativeAkira Matsuda2017-07-0114-20/+20
|/ /
* / Fix current_page? helper issue with engine root pathsavroff2017-06-191-1/+4
|/
* Generate field ids in `collection_check_boxes` and `collection_radio_buttons`yuuji.yaginuma2017-06-112-0/+2
| | | | | This makes sure that the labels are linked up with the fields. Fixes #29014
* Don't rely on the @view_renderer being defined.Kasper Timm Hansen2017-06-081-2/+2
| | | | That won't be true for Action Pack and Action Mailer.
* Merge pull request https://github.com/rails/rails/pull/28637 from ↵Kasper Timm Hansen2017-06-081-6/+2
| | | | st0012/fix-partial-cache-logging
* Use a hash to record every partial's cache hit status instead of sharing a ↵Stan Lo2017-06-081-2/+4
| | | | boolean.
* Move slicing to initializer.Kasper Timm Hansen2017-06-072-2/+2
| | | | | | Forgot all about https://github.com/rails/rails/pull/28844/files#r113780934 cc @rafaelfranca
* Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-032-6/+3
|
* Add option for class_attribute default (#29270)David Heinemeier Hansson2017-05-291-8/+9
| | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation
* Merge pull request #29119 from spohlenz/fix-select-with-enumerableMatthew Draper2017-05-241-1/+1
|\ | | | | Fix select tag helper used with Enumerable choices
| * Fix select tag helper used with Enumerable choicesSam Pohlenz2017-05-171-1/+1
| | | | | | | | | | | | Allows a custom object implementing Enumerable to be used as the choices parameter for a select tag, which previously wasn't possible due to the call to `empty?` on the choices (which isn't implemented on Enumerable).
* | Add :json type to auto_discovery_link_tagMike Gunderloy2017-05-201-5/+7
| | | | | | | | | | This allows auto_discovery_link_tag to support the JSON Feed standard. See https://jsonfeed.org/version/1 for more information.
* | Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-181-9/+17
|/
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-17 04:16:05 +0000