Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #17143 from kuldeepaggarwal/fix-mailTo | Rafael Mendonça França | 2015-02-20 | 1 | -1/+1 |
|\ | | | | | | | mail_to helper method fix | ||||
| * | do not generate blank options in mailTo | Kuldeep Aggarwal | 2014-10-02 | 1 | -2/+3 |
| | | | | | | | | | | when mail_to generate blank options for any passed options(cc, bcc, body, subject) then MICROSOFT OUTLOOK treats it differently and set wrong values in different options. | ||||
* | | Use a name that better reflect the return value | Rafael Mendonça França | 2015-02-20 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #17138 from jpcody/rename_default_form_builder | Rafael Mendonça França | 2015-02-20 | 1 | -2/+2 |
|\ \ | | | | | | | | | | Rename default_form_builder to avoid collision | ||||
| * | | Rename default_form_builder to avoid collision | Joshua Cody | 2014-10-01 | 1 | -2/+2 |
| |/ | |||||
* | | Corrects the API to method select_tag | Leandro Nunes | 2015-02-20 | 1 | -2/+1 |
| | | | | | | | | The 'selected' option is not doing what it should do. The expected behavior is to pass the value selected by default for the options_from_collection_for_select method | ||||
* | | Remove RecordTagHelper, add extraction notices | Todd Bealmear | 2015-02-16 | 2 | -99/+14 |
| | | | | | | | | | | | | | | Per DHH in #18337, ActionView::Helpers::RecordTagHelper has been extracted to an external gem (source currently lives at todd/record_tag_helper). Removal notices have also been added for anyone upgrading that use the extracted methods. | ||||
* | | Allow to pass a string value to size option in `image_tag` and `video_tag` | Mehdi Lahmam | 2015-02-16 | 1 | -0/+1 |
| | | | | | | | | This makes the behavior more consistent with `width` or `height` options | ||||
* | | Merge pull request #18845 from bogdan/remove-code-dups-in-action-view | Rafael Mendonça França | 2015-02-11 | 2 | -33/+25 |
|\ \ | | | | | | | Remove some code duplication in ActionView tags code | ||||
| * | | Remove code duplication in ActionView::Helpers::Tags::Base | Bogdan Gusiev | 2015-02-11 | 2 | -33/+25 |
| | | | |||||
* | | | Remove warning from ActionView::Helpers::Tags::Translator | Yuki Nishijima | 2015-02-08 | 1 | -1/+3 |
|/ / | | | | | | | | | | | This removes the following warning: /GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute? | ||||
* | | Fixed undefined method `i18n_key' for nil:NilClass for labels in non AR form_for | Miklos Fazekas | 2015-02-06 | 1 | -1/+1 |
| | | | | | | | | | | Refactoring at #18647 broke using non active record objects in form_for. This patch restores the original behaviour where we only compute i18 key when object.respond_to?(:to_model) | ||||
* | | Indicate link_to creates an anchor element | Colin Rymer | 2015-02-06 | 1 | -2/+2 |
| | | | | | | | | | | | | The `link_to` helper generates an HTML anchor element (consisting of opening and closing anchor tags and an element body). The docs currently state the a link tag is generated (which would indicate a tag like `<link>`, which is another valid HTML tag), so this change clarifies that an anchor element is actually generated. [ci skip] | ||||
* | | Rename method to make explicit its intention | Rafael Mendonça França | 2015-02-05 | 3 | -3/+3 |
| | | | | | | | | call is too generic | ||||
* | | Use kwags to make the argument meaning explicit | Rafael Mendonça França | 2015-02-05 | 3 | -6/+6 |
| | | |||||
* | | Use new hash syntax | Rafael Mendonça França | 2015-02-05 | 1 | -1/+1 |
| | | |||||
* | | Change the method visibility | Rafael Mendonça França | 2015-02-05 | 1 | -2/+4 |
| | | | | | | | | Thse methods are used only inside this class | ||||
* | | Only check if object respond_to to_model once | Rafael Mendonça França | 2015-02-05 | 1 | -6/+2 |
| | | |||||
* | | placeholder doesn't exist inside this context | Rafael Mendonça França | 2015-02-05 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #18647 from mcls/placeholderable-to-model | Rafael Mendonça França | 2015-02-05 | 4 | -28/+47 |
|\ \ | | | | | | | | | | The `model_name` method should be called on `to_model` | ||||
| * | | Reduce duplication when generating translations | Maarten Claes | 2015-01-22 | 4 | -34/+47 |
| | | | |||||
| * | | Convert with `to_model` before calling ActiveModel methods on `object` | Maarten Claes | 2015-01-22 | 2 | -8/+14 |
| | | | |||||
* | | | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | | | | | | | | | onwards. | ||||
* | | | Add missing options to `datetime_select` [ci skip] | yachibit | 2015-01-25 | 1 | -0/+2 |
|/ / | |||||
* | | Single instead of double quotes | T.J. Schuck | 2015-01-20 | 1 | -2/+2 |
| | | | | | | [ci skip] | ||||
* | | Rewrite SanitizeHelper docs | T.J. Schuck | 2015-01-20 | 1 | -77/+50 |
| | | |||||
* | | Fix code formatting in sanitize docs | T.J. Schuck | 2015-01-20 | 1 | -9/+11 |
| | | |||||
* | | fix typo in number_field_tag documentation [ci skip] | yuuji.yaginuma | 2015-01-19 | 1 | -2/+2 |
| | | |||||
* | | Use option url: false to allow entries without a link tag | Daniel Gomez de Souza | 2015-01-16 | 1 | -2/+3 |
| | | |||||
* | | Only use the `_before_type_cast` in the form when from user input | Sean Griffin | 2015-01-14 | 1 | -2/+9 |
| | | | | | | | | | | | | While we don't want to change the form input when validations fail, blindly using `_before_type_cast` will cause the input to display the wrong data for any type which does additional work on database values. | ||||
* | | Revert "Don't use the `_before_type_cast` version of attributes in the form" | Sean Griffin | 2015-01-14 | 3 | -2/+12 |
| | | | | | | | | This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd. | ||||
* | | Don't use the `_before_type_cast` version of attributes in the form | Sean Griffin | 2015-01-14 | 3 | -12/+2 |
| | | | | | | | | | | | | | | | | | | | | | | We should never be ignoring valuable information that the types may need to give us. The reason that it originally used `_before_type_cast` is unclear, but appears to date back long enough that the reasons may not be relevant today. There is only one test that asserts that it uses the before type cast version, but it gives no context as to why and uses a mock which does not simulate the real world. Fixes #18523. | ||||
* | | Merge pull request #17676 from ↵ | Rafael Mendonça França | 2015-01-05 | 1 | -6/+8 |
|\ \ | | | | | | | | | | | | | | | | tigrish/fix_custom_i18n_exception_handler_regression Fix I18n regression introduced by #13832 | ||||
| * | | Fix I18n regression introduced by #13832 | Christopher Dell | 2014-11-19 | 1 | -6/+8 |
| | | | | | | | | | | | | Previously, when the `:raise` options was set to `false`, it would get overwritten to `true`, preventing custom exception handlers to be used. | ||||
* | | | Remove unneeded `require 'as/deprecation'` | claudiob | 2015-01-04 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | Tests should still pass after removing `require 'active_support/deprecation'` from these files since the related deprecations have been removed. | ||||
* | | | Unsafe default translations should not be marked html_safe | Justin Coyne | 2015-01-02 | 1 | -19/+9 |
| | | | | | | | | | | | | | | | | | | Previously default translation keys that didn't end in `_html`, but came after a missing key that ended in `_html` were being returned as html_safe. Now they are not. Fixes #18257 | ||||
* | | | Follow up to #17973 [ci skip] | Robin Dupret | 2015-01-02 | 1 | -9/+10 |
| | | | |||||
* | | | Merge pull request #17974 from killthekitten/fix-render-block | Rafael Mendonça França | 2015-01-02 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use blocks with short version of render partial Conflicts: actionview/CHANGELOG.md | ||||
| * | | | Make possible to use blocks with short version of render partial | Nikolay Shebanov | 2014-12-19 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #17973 from maurogeorge/file_field_hidden_field | Rafael Mendonça França | 2015-01-02 | 2 | -0/+32 |
|\ \ \ \ | | | | | | | | | | | | | | | | Generate a hidden_tag when using a file_field | ||||
| * | | | | Add a hidden_field on the file_field | Mauro George | 2015-01-02 | 2 | -0/+30 |
|/ / / / | | | | | | | | | | | | | | | | | This will avoid a error be raised when the only input on the form is the `file_field`. | ||||
* | | | | Fixes simple missprint in docs for #cyle in text_helper | Ben Woodall | 2014-12-30 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #18107 from mkdynamic/add-reply-to-mail-to | Sean Griffin | 2014-12-24 | 1 | -2/+3 |
|\ \ \ \ | | | | | | | | | | | Add support for Reply-To field in mail_to helper | ||||
| * | | | | Add support for Reply-To field in mail_to helper | Mark Dodwell | 2014-12-20 | 1 | -2/+3 |
| |/ / / | |||||
* / / / | Remove block from super | Jose Añasco | 2014-12-23 | 2 | -10/+12 |
|/ / / | |||||
* | | | [ci skip] Fix HTML format on comment | yui-knk | 2014-12-18 | 1 | -1/+2 |
| | | | |||||
* | | | Revert "Re-enable capture'ing non-String values" | Santiago Pastorino | 2014-12-15 | 1 | -1/+1 |
| | | | | | | | | | | | | This reverts commit c2fe0938d7201d4ce0bb2f25e72bf5f70df128af. | ||||
* | | | Re-enable capture'ing non-String values | Carsten Zimmermann | 2014-12-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | This has been discussed in #17661 and partially reverts the changes made in 9de83050d3a4b260d4aeb5d09ec4eb64f913ba64 and 986cac73e3c56b3dfa22fd1464f6913e38d32cc3 The test case added to content_for acts as a regression / acceptance test. | ||||
* | | | Fix options overwritten by super | Jose Añasco | 2014-12-09 | 2 | -11/+10 |
| | | | |||||
* | | | Merge pull request #17866 from bogdan/default-form-builder | Santiago Pastorino | 2014-12-01 | 1 | -1/+3 |
|\ \ \ | | | | | | | | | Bugfix config.action_view.default_form_builder option |