| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since Rails 6.0 will support Ruby 2.4.1 or higher
`# frozen_string_literal: true` magic comment is enough to make string object frozen.
This magic comment is enabled by `Style/FrozenStringLiteralComment` cop.
* Exclude these files not to auto correct false positive `Regexp#freeze`
- 'actionpack/lib/action_dispatch/journey/router/utils.rb'
- 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'
It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333
Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.
* Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required
- 'actionpack/test/controller/test_case_test.rb'
- 'activemodel/test/cases/type/string_test.rb'
- 'activesupport/lib/active_support/core_ext/string/strip.rb'
- 'activesupport/test/core_ext/string_ext_test.rb'
- 'railties/test/generators/actions_test.rb'
|
| |\
| |
| |
| | |
Use public_send in value_for_collection
|
| | |
| |
| |
| |
| | |
Instead of dropping it completely in case someone is relying (probably
inadvertenly) on it.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Avoid exposing private methods in view's helpers. However, as
`extract_values_from_collection` is only called from
`options_from_collection_for_select` where `value_for_collection` is
previously called, this case was already covered. The change makes
anyway sense for consistency and in case the code changes in the
future.
|
| |/
|
|
|
|
| |
Avoid exposing private methods in view's helpers.
Fixes https://github.com/rails/rails/issues/33546
|
| |
|
|
|
| |
Special form_with attributes `skip_default_ids` and `allow_method_names_outside_object`
attributes are leaking into html attributes of option select tag helpers.
|
| |
|
|
|
|
|
|
| |
The spacing in these comments is fairly inconsistent. Array argument
contents are often separated with a space from the array literal
brackets but in several cases the Hash literal curly braces are tangent
to their contents which makes the documentation harder to read in some
cases.
|
| |
|
|
| |
This broke the doc.
|
| |
|
|
|
|
| |
Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select`
by calls to `value_for_collection(group, ...)`, allowing the use of
procs, lambdas and other callable objects as parameters.
|
| |
|
|
| |
This basically reverts c4d1a4efeec6f0b5b58222993aa0bec85a19b6a8
|
| |
|
|
| |
Follow up of #30862.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| |
|
|
| |
[ci skip] Just some english and `<tt>` tags.
|
| | |
|
| |
|
|
| |
Add ActiveSupport::TimeZone.country_zones helper
|
| | |
|
| |
|
|
|
| |
This will avoid a error be raised when the only input on the form is the
`collection_radio_buttons`.
|
| |
|
|
|
|
| |
content_tag's first argument is will generate a string with an html tag so `:a` will generate: `<a></a>`. When this happens, the symbol is implicitly `to_s`-d so a new string is allocated. We can get around that by using a frozen string instead which
This change buys us 74,236 bytes of memory and 1,855 fewer objects per request.
|
| | |
|
| |
|
|
| |
[ci skip]
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
[skip ci]
|
| |
|
|
|
|
|
| |
[ci skip]
This fixes the broken code block rendering and indents the examples
within the parameter list.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Jonas Baumann & Yves Senn]
The submitted params from a select with `multiple: true` look as follows:
```
{post: {category: [""]}}
{post: {category: ["", "Category 1", "Category 2"]}}
```
This is a follow up to #1552.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
This reverts commit f4a5a9ea4d183f4102796215d4502c46dbe3e52b, reversing
changes made to 7ccb482181ee6c47c765406009018a15172812de.
Reason:
The logic is different, the first call to #option_value_selected? is for
the :selected option (the argument is the "selected" variable), the second
call is for the :disabled option (the argument is the "disabled" variable).
|
| | |
|
| |
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
| |
Example:
= select(report, "campaign_ids") do
- available_campaigns.each do |c|
%option{:data => {:tags => c.tags.to_json}, :value => c.id}= c.name
|
| | |
|
| |
|
|
|
|
| |
content tag already knows which tags are boolean and the values that
should generate them when a truthy value is passed, so leave this logic
for it instead of duplicating when generating options tags.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
because it was deprecated.
|
| | |
|
| | |
|
| |
|
