Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't expect defined protect_against_forgery? in {token,csrf_meta}_tag | Genadi Samokovarov | 2018-12-27 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | The `#csrf_meta_tags` and `#token_tag` Action View helper methods are expecting the class in which are included to explicitly define the method `#protect_against_forgery?` or else they will fail with `NoMethodError`. This is a problem if you want to use Action View outside of Rails applications. For example, in #34788 I used the `#button_to` helper inside of the error pages templates that have a custom `ActionView::Base` subclass, which did not defined `#protect_against_forgery?` and trying to call the button failed. I had to dig inside of Action View to find-out what's was going on. I think we should either set a default method implementation in the helpers or check for the method definition, but don't explicitly require the presence of `#protect_against_forgery?` in every `ActionViews::Base` subclass as the errors are hard to figure out. | ||||
* | Fix broken doc layout for action_view [ci skip] | Yoshiyuki Hirano | 2017-08-27 | 1 | -1/+1 |
| | |||||
* | Use frozen string literal in actionview/ | Kir Shatrov | 2017-07-24 | 1 | -0/+2 |
| | |||||
* | [ci skip]Replace jquery-ujs with rails-ujs | willnet | 2017-07-19 | 1 | -1/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | modernizes hash syntax in actionview | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | |||||
* | applies new string literal convention in actionview/lib | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | be more specific about csrf token and ajax - not whitelisted outside of ↵ | Tim Ruffles | 2013-08-06 | 1 | -2/+5 |
| | | | | jquery-rails [ci skip] | ||||
* | Move actionpack/lib/action_view* into actionview/lib | Piotr Sarnacki | 2013-06-20 | 1 | -0/+30 |